From: Simon Baatz <gmbnomis@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, Andrew Lunn <andrew@lunn.ch>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jason Cooper <jason@lakedaemon.net>, Chris Ball <cjb@laptop.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [RESEND PATCH V3 6/8] mmc: tegra: handle mmc_of_parse() errors during probe
Date: Tue, 11 Jun 2013 00:02:30 +0200 [thread overview]
Message-ID: <20130610220230.GB30680@schnuecks.de> (raw)
In-Reply-To: <51B640F2.8030107@wwwdotorg.org>
Hi Stephen,
On Mon, Jun 10, 2013 at 03:11:14PM -0600, Stephen Warren wrote:
> On 06/09/2013 02:14 PM, Simon Baatz wrote:
> > Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
Thanks!
> (On Seaboard/Springbank board, i.e. Tegra20)
>
> > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
>
> > +err_parse_dt:
> > err_power_req:
> > err_alloc_tegra_host:
>
> Nit: It'd be nice if that new label got inserted into the middle of the
> list, so err_power_req, err_parse_dt, err_alloc_tegra_host. That way if
> we ever needed to add separate code there, they'd be in the right order
> already. Still, this isn't worth fixing unless you have to repost for
> some other reason I guess.
Yes, you are right. I updated the patch locally, so the update will
be in if I need to repost (or if the nicer version is explicitly
requested).
Since this change is only syntactical, I simply assume that your
Tested-by is still valid even with the change ;-)
- Simon
WARNING: multiple messages have this Message-ID (diff)
From: gmbnomis@gmail.com (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH V3 6/8] mmc: tegra: handle mmc_of_parse() errors during probe
Date: Tue, 11 Jun 2013 00:02:30 +0200 [thread overview]
Message-ID: <20130610220230.GB30680@schnuecks.de> (raw)
In-Reply-To: <51B640F2.8030107@wwwdotorg.org>
Hi Stephen,
On Mon, Jun 10, 2013 at 03:11:14PM -0600, Stephen Warren wrote:
> On 06/09/2013 02:14 PM, Simon Baatz wrote:
> > Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
Thanks!
> (On Seaboard/Springbank board, i.e. Tegra20)
>
> > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
>
> > +err_parse_dt:
> > err_power_req:
> > err_alloc_tegra_host:
>
> Nit: It'd be nice if that new label got inserted into the middle of the
> list, so err_power_req, err_parse_dt, err_alloc_tegra_host. That way if
> we ever needed to add separate code there, they'd be in the right order
> already. Still, this isn't worth fixing unless you have to repost for
> some other reason I guess.
Yes, you are right. I updated the patch locally, so the update will
be in if I need to repost (or if the nicer version is explicitly
requested).
Since this change is only syntactical, I simply assume that your
Tested-by is still valid even with the change ;-)
- Simon
next prev parent reply other threads:[~2013-06-10 22:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 20:14 [RESEND PATCH V3 0/8] mmc_of_parse() adaptations, switch mvsdio to mmc_of_parse() Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 1/8] mmc: return mmc_of_parse() errors to caller Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 2/8] mmc: sh_mmcif: handle mmc_of_parse() errors during probe Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 3/8] mmc: tmio-mmc: " Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 4/8] mmc: mxcmmc: " Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 5/8] mmc: sdhci-pxav3: " Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 6/8] mmc: tegra: " Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-10 21:11 ` Stephen Warren
2013-06-10 21:11 ` Stephen Warren
2013-06-10 22:02 ` Simon Baatz [this message]
2013-06-10 22:02 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 7/8] ARM: mvebu: Use standard MMC binding for all users of mvsdio Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-09 20:14 ` [RESEND PATCH V3 8/8] mmc: mvsdio: use standard MMC device-tree binding parser mmc_of_parse() Simon Baatz
2013-06-09 20:14 ` Simon Baatz
2013-06-10 19:05 ` [RESEND PATCH V3 0/8] mmc_of_parse() adaptations, switch mvsdio to mmc_of_parse() Andrew Lunn
2013-06-10 19:05 ` Andrew Lunn
2013-06-27 14:26 ` Chris Ball
2013-06-27 14:26 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610220230.GB30680@schnuecks.de \
--to=gmbnomis@gmail.com \
--cc=andrew@lunn.ch \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=g.liakhovetski@gmx.de \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.