From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ferruh Yigit <fery@cypress.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 3/3] Input: cyttsp4 - leak on error path in probe()
Date: Wed, 03 Jul 2013 13:50:13 +0000 [thread overview]
Message-ID: <20130703135013.GU5714@mwanda> (raw)
In-Reply-To: <51D42350.10504@cypress.com>
On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote:
> On 07/03/2013 12:44 AM, Dan Carpenter wrote:
> >We leak "cd" if the cd->xfer_buf allocation fails. It was weird to
> >"goto error_gpio_irq" so I changed the label name. (Label names should
> >reflect the label location not the goto location otherwise you get an
> >"all roads lead to Rome problem").
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> xfer_buf still may not be freed, I propose following one instead:
>
That's a good point. I missed that leak. The problem is that my
patch was already applied so this patch would have to be re-written
on top of that. Also this patch is whitespace dammaged and won't
apply.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ferruh Yigit <fery@cypress.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 3/3] Input: cyttsp4 - leak on error path in probe()
Date: Wed, 3 Jul 2013 16:50:13 +0300 [thread overview]
Message-ID: <20130703135013.GU5714@mwanda> (raw)
In-Reply-To: <51D42350.10504@cypress.com>
On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote:
> On 07/03/2013 12:44 AM, Dan Carpenter wrote:
> >We leak "cd" if the cd->xfer_buf allocation fails. It was weird to
> >"goto error_gpio_irq" so I changed the label name. (Label names should
> >reflect the label location not the goto location otherwise you get an
> >"all roads lead to Rome problem").
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> xfer_buf still may not be freed, I propose following one instead:
>
That's a good point. I missed that leak. The problem is that my
patch was already applied so this patch would have to be re-written
on top of that. Also this patch is whitespace dammaged and won't
apply.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-03 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 21:44 [patch 3/3] Input: cyttsp4 - leak on error path in probe() Dan Carpenter
2013-07-02 21:44 ` Dan Carpenter
2013-07-03 13:12 ` Ferruh Yigit
2013-07-03 13:12 ` Ferruh Yigit
2013-07-03 13:50 ` Dan Carpenter [this message]
2013-07-03 13:50 ` Dan Carpenter
2013-07-03 13:53 ` Ferruh Yigit
2013-07-03 13:53 ` Ferruh Yigit
2013-07-03 17:14 ` [PATCH] Input: cyttsp4 - kfree xfer_buf " Ferruh Yigit
2013-07-03 17:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703135013.GU5714@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fery@cypress.com \
--cc=javier@dowhile0.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.