From: Stephen Rothwell <sfr@canb.auug.org.au> To: Daniel Vetter <daniel.vetter@ffwll.ch>, <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <ben@bwidawsk.net> Subject: linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree Date: Tue, 16 Jul 2013 12:05:23 +1000 [thread overview] Message-ID: <20130716120523.32e132972134f55a0655d3c9@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 2537 bytes --] Hi all, Today's linux-next merge of the drm-intel tree got a conflict in drivers/gpu/drm/i915/i915_gem.c between commits 19b2dbde5732 ("drm/i915: Restore fences after resume and GPU resets") from Linus' tree and d18b96190342 ("drm/i915: Fix incoherence with fence updates on Sandybridge+") from the drm-intel-fixes tree and commits f343c5f64773 ("drm/i915: Getter/setter for object attributes") and db1b76ca6a79 ("drm/i915: don't frob mm.suspended when not using ums") from the drm-intel tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au diff --cc drivers/gpu/drm/i915/i915_gem.c index 97afd26,20b10a0..0000000 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@@ -2666,27 -2673,12 +2665,27 @@@ static void i965_write_fence_reg(struc fence_pitch_shift = I965_FENCE_PITCH_SHIFT; } + fence_reg += reg * 8; + + /* To w/a incoherency with non-atomic 64-bit register updates, + * we split the 64-bit update into two 32-bit writes. In order + * for a partial fence not to be evaluated between writes, we + * precede the update with write to turn off the fence register, + * and only enable the fence as the last step. + * + * For extra levels of paranoia, we make sure each step lands + * before applying the next step. + */ + I915_WRITE(fence_reg, 0); + POSTING_READ(fence_reg); + if (obj) { - u32 size = obj->gtt_space->size; + u32 size = i915_gem_obj_ggtt_size(obj); + uint64_t val; - val = (uint64_t)((obj->gtt_offset + size - 4096) & + val = (uint64_t)((i915_gem_obj_ggtt_offset(obj) + size - 4096) & 0xfffff000) << 32; - val |= obj->gtt_offset & 0xfffff000; + val |= i915_gem_obj_ggtt_offset(obj) & 0xfffff000; val |= (uint64_t)((obj->stride / 128) - 1) << fence_pitch_shift; if (obj->tiling_mode == I915_TILING_Y) val |= 1 << I965_FENCE_TILING_Y_SHIFT; @@@ -3992,11 -4008,8 +3980,6 @@@ i915_gem_idle(struct drm_device *dev if (!drm_core_check_feature(dev, DRIVER_MODESET)) i915_gem_evict_everything(dev); - /* Hack! Don't let anybody do execbuf while we don't control the chip. - * We need to replace this with a semaphore, or something. - * And not confound mm.suspended! - */ - dev_priv->mm.suspended = 1; - i915_gem_reset_fences(dev); - del_timer_sync(&dev_priv->gpu_error.hangcheck_timer); i915_kernel_lost_context(dev); [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <ben@bwidawsk.net> Subject: linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree Date: Tue, 16 Jul 2013 12:05:23 +1000 [thread overview] Message-ID: <20130716120523.32e132972134f55a0655d3c9@canb.auug.org.au> (raw) [-- Attachment #1: Type: text/plain, Size: 2537 bytes --] Hi all, Today's linux-next merge of the drm-intel tree got a conflict in drivers/gpu/drm/i915/i915_gem.c between commits 19b2dbde5732 ("drm/i915: Restore fences after resume and GPU resets") from Linus' tree and d18b96190342 ("drm/i915: Fix incoherence with fence updates on Sandybridge+") from the drm-intel-fixes tree and commits f343c5f64773 ("drm/i915: Getter/setter for object attributes") and db1b76ca6a79 ("drm/i915: don't frob mm.suspended when not using ums") from the drm-intel tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au diff --cc drivers/gpu/drm/i915/i915_gem.c index 97afd26,20b10a0..0000000 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@@ -2666,27 -2673,12 +2665,27 @@@ static void i965_write_fence_reg(struc fence_pitch_shift = I965_FENCE_PITCH_SHIFT; } + fence_reg += reg * 8; + + /* To w/a incoherency with non-atomic 64-bit register updates, + * we split the 64-bit update into two 32-bit writes. In order + * for a partial fence not to be evaluated between writes, we + * precede the update with write to turn off the fence register, + * and only enable the fence as the last step. + * + * For extra levels of paranoia, we make sure each step lands + * before applying the next step. + */ + I915_WRITE(fence_reg, 0); + POSTING_READ(fence_reg); + if (obj) { - u32 size = obj->gtt_space->size; + u32 size = i915_gem_obj_ggtt_size(obj); + uint64_t val; - val = (uint64_t)((obj->gtt_offset + size - 4096) & + val = (uint64_t)((i915_gem_obj_ggtt_offset(obj) + size - 4096) & 0xfffff000) << 32; - val |= obj->gtt_offset & 0xfffff000; + val |= i915_gem_obj_ggtt_offset(obj) & 0xfffff000; val |= (uint64_t)((obj->stride / 128) - 1) << fence_pitch_shift; if (obj->tiling_mode == I915_TILING_Y) val |= 1 << I965_FENCE_TILING_Y_SHIFT; @@@ -3992,11 -4008,8 +3980,6 @@@ i915_gem_idle(struct drm_device *dev if (!drm_core_check_feature(dev, DRIVER_MODESET)) i915_gem_evict_everything(dev); - /* Hack! Don't let anybody do execbuf while we don't control the chip. - * We need to replace this with a semaphore, or something. - * And not confound mm.suspended! - */ - dev_priv->mm.suspended = 1; - i915_gem_reset_fences(dev); - del_timer_sync(&dev_priv->gpu_error.hangcheck_timer); i915_kernel_lost_context(dev); [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2013-07-16 2:05 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-16 2:05 Stephen Rothwell [this message] 2013-07-16 2:05 ` linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree Stephen Rothwell 2013-07-18 1:44 Stephen Rothwell 2013-07-18 1:44 ` Stephen Rothwell 2013-07-18 2:07 Stephen Rothwell 2013-07-18 2:07 ` Stephen Rothwell 2013-07-26 3:10 Stephen Rothwell 2013-07-26 3:10 ` Stephen Rothwell 2013-07-26 3:14 Stephen Rothwell 2013-07-26 3:14 ` Stephen Rothwell 2013-09-20 1:40 Stephen Rothwell 2013-09-20 1:40 ` Stephen Rothwell 2013-09-25 2:00 Stephen Rothwell 2013-09-25 2:00 ` Stephen Rothwell 2013-12-02 1:04 Stephen Rothwell 2013-12-02 1:04 ` Stephen Rothwell 2013-12-02 1:13 ` Stephen Rothwell 2013-12-02 1:13 ` Stephen Rothwell 2013-12-16 1:45 Stephen Rothwell 2013-12-16 1:45 ` Stephen Rothwell 2014-04-30 2:37 Stephen Rothwell 2014-04-30 2:37 ` Stephen Rothwell 2014-05-22 5:58 Stephen Rothwell 2014-05-22 5:58 ` Stephen Rothwell 2015-01-09 2:06 Stephen Rothwell 2015-01-09 2:06 ` Stephen Rothwell 2015-02-25 1:05 Stephen Rothwell 2015-02-25 1:05 ` Stephen Rothwell 2015-02-26 0:15 Stephen Rothwell 2015-02-26 0:15 ` Stephen Rothwell 2015-02-27 0:36 Stephen Rothwell 2015-02-27 0:36 ` Stephen Rothwell 2015-07-10 2:08 Stephen Rothwell 2015-07-10 2:08 ` Stephen Rothwell 2015-07-10 2:15 Stephen Rothwell 2015-07-10 2:15 ` Stephen Rothwell 2015-07-14 2:11 Stephen Rothwell 2015-07-14 2:11 ` Stephen Rothwell 2015-07-14 7:34 ` Daniel Vetter 2015-07-14 7:34 ` Daniel Vetter 2015-07-15 0:15 Stephen Rothwell 2015-07-15 0:15 ` Stephen Rothwell 2015-09-24 1:25 Stephen Rothwell 2015-09-24 1:25 ` Stephen Rothwell 2015-09-24 8:57 ` Jani Nikula 2015-09-24 8:57 ` Jani Nikula 2015-09-24 11:52 ` Stephen Rothwell 2015-09-30 1:32 Stephen Rothwell 2015-09-30 1:32 ` Stephen Rothwell 2015-11-18 0:30 Stephen Rothwell 2015-11-18 0:30 ` Stephen Rothwell 2016-06-22 1:40 Stephen Rothwell 2016-06-22 1:40 ` Stephen Rothwell 2016-08-24 1:32 Stephen Rothwell 2016-08-24 1:32 ` Stephen Rothwell 2016-08-24 1:42 Stephen Rothwell 2016-08-24 1:42 ` Stephen Rothwell 2017-03-21 0:37 Stephen Rothwell 2017-03-21 0:37 ` Stephen Rothwell 2017-06-08 3:04 Stephen Rothwell 2017-06-08 3:07 Stephen Rothwell 2017-10-12 18:36 Mark Brown 2017-10-12 18:36 ` Mark Brown 2017-10-12 18:44 Mark Brown 2017-10-12 18:44 ` Mark Brown 2017-10-16 11:35 Mark Brown 2017-10-16 11:35 ` Mark Brown 2017-10-17 8:11 ` Arnd Bergmann 2017-10-17 8:11 ` Arnd Bergmann 2017-10-17 8:30 ` Mark Brown 2017-10-17 8:30 ` Mark Brown 2017-10-18 9:27 Mark Brown 2017-10-18 9:27 ` Mark Brown 2019-03-21 23:57 Stephen Rothwell 2019-03-21 23:57 ` Stephen Rothwell 2019-03-31 22:59 ` Stephen Rothwell 2020-03-11 2:36 Stephen Rothwell 2020-03-11 2:36 ` Stephen Rothwell 2020-03-20 1:57 ` Stephen Rothwell 2020-03-20 1:57 ` Stephen Rothwell 2020-06-30 1:52 Stephen Rothwell 2020-06-30 1:52 ` Stephen Rothwell 2020-07-06 1:51 ` Stephen Rothwell 2020-07-06 1:51 ` Stephen Rothwell 2021-08-02 15:18 Mark Brown 2022-02-02 23:59 Stephen Rothwell 2022-02-02 23:59 ` Stephen Rothwell 2022-02-23 14:46 broonie 2022-02-23 14:46 ` broonie 2022-02-25 17:08 broonie 2022-02-25 17:08 ` broonie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130716120523.32e132972134f55a0655d3c9@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=ben@bwidawsk.net \ --cc=chris@chris-wilson.co.uk \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.