From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [FAILURE] omap4430-sdp allnoconfig
Date: Thu, 1 Aug 2013 19:27:07 +0100 [thread overview]
Message-ID: <20130801182707.GB23053@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <51FAA4C6.10203@ti.com>
On Thu, Aug 01, 2013 at 02:11:18PM -0400, Santosh Shilimkar wrote:
> On Thursday 01 August 2013 01:52 PM, Russell King - ARM Linux wrote:
> > My allnoconfig fails with this error:
> >
> > arch/arm/mach-omap2/built-in.o: In function `omap4_local_timer_init':
> > dss-common.c:(.init.text+0x1d90): undefined reference to `twd_local_timer_register'
> >
> > Might be worth looking into whatever's missing?
>
> Looks like coming from below snippet but am just wondering how ?
Well, looking at the config allnoconfig generated, it doesn't have SMP
and therefore it doesn't have local timers.
The build tree has this in it:
#ifdef CONFIG_ARCH_OMAP4
static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29);
void __init omap4_local_timer_init(void)
{
omap4_sync32k_timer_init();
/* Local timers are not supprted on OMAP4430 ES1.0 */
if (omap_rev() != OMAP4430_REV_ES1_0) {
int err;
if (of_have_populated_dt()) {
clocksource_of_init();
return;
}
err = twd_local_timer_register(&twd_local_timer);
if (err)
pr_err("twd_local_timer_register failed %d\n", err);
}
}
#endif /* CONFIG_ARCH_OMAP4 */
which is changed from your version thanks to this commit:
commit ef3160cd2f0a400751f2cf6fd2811225fee1d5a7
Author: Stephen Boyd <sboyd@codeaurora.org>
Date: Mon Mar 4 19:24:35 2013 -0800
ARM: OMAP2+: Divorce from local timer API
Now that the TWD doesn't rely on the local timer API, OMAP can
stop selecting it in Kconfig and relying on the config option to
decide if it should call smp_twd functions.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
So it seems LOCAL_TIMER is still actually required...
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [FAILURE] omap4430-sdp allnoconfig
Date: Thu, 1 Aug 2013 19:27:07 +0100 [thread overview]
Message-ID: <20130801182707.GB23053@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <51FAA4C6.10203@ti.com>
On Thu, Aug 01, 2013 at 02:11:18PM -0400, Santosh Shilimkar wrote:
> On Thursday 01 August 2013 01:52 PM, Russell King - ARM Linux wrote:
> > My allnoconfig fails with this error:
> >
> > arch/arm/mach-omap2/built-in.o: In function `omap4_local_timer_init':
> > dss-common.c:(.init.text+0x1d90): undefined reference to `twd_local_timer_register'
> >
> > Might be worth looking into whatever's missing?
>
> Looks like coming from below snippet but am just wondering how ?
Well, looking at the config allnoconfig generated, it doesn't have SMP
and therefore it doesn't have local timers.
The build tree has this in it:
#ifdef CONFIG_ARCH_OMAP4
static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29);
void __init omap4_local_timer_init(void)
{
omap4_sync32k_timer_init();
/* Local timers are not supprted on OMAP4430 ES1.0 */
if (omap_rev() != OMAP4430_REV_ES1_0) {
int err;
if (of_have_populated_dt()) {
clocksource_of_init();
return;
}
err = twd_local_timer_register(&twd_local_timer);
if (err)
pr_err("twd_local_timer_register failed %d\n", err);
}
}
#endif /* CONFIG_ARCH_OMAP4 */
which is changed from your version thanks to this commit:
commit ef3160cd2f0a400751f2cf6fd2811225fee1d5a7
Author: Stephen Boyd <sboyd@codeaurora.org>
Date: Mon Mar 4 19:24:35 2013 -0800
ARM: OMAP2+: Divorce from local timer API
Now that the TWD doesn't rely on the local timer API, OMAP can
stop selecting it in Kconfig and relying on the config option to
decide if it should call smp_twd functions.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
So it seems LOCAL_TIMER is still actually required...
next prev parent reply other threads:[~2013-08-01 18:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:52 [FAILURE] omap4430-sdp allnoconfig Russell King - ARM Linux
2013-08-01 17:52 ` Russell King - ARM Linux
2013-08-01 18:11 ` Santosh Shilimkar
2013-08-01 18:11 ` Santosh Shilimkar
2013-08-01 18:27 ` Russell King - ARM Linux [this message]
2013-08-01 18:27 ` Russell King - ARM Linux
2013-08-01 18:31 ` Santosh Shilimkar
2013-08-01 18:31 ` Santosh Shilimkar
2013-08-01 18:34 ` Stephen Boyd
2013-08-01 18:34 ` Stephen Boyd
2013-08-01 18:37 ` Stephen Boyd
2013-08-01 18:37 ` Stephen Boyd
2013-08-01 18:48 ` Santosh Shilimkar
2013-08-01 18:48 ` Santosh Shilimkar
2013-08-01 18:59 ` Stephen Boyd
2013-08-01 18:59 ` Stephen Boyd
2013-08-01 19:01 ` Santosh Shilimkar
2013-08-01 19:01 ` Santosh Shilimkar
2013-08-01 19:02 ` Russell King - ARM Linux
2013-08-01 19:02 ` Russell King - ARM Linux
2013-08-01 20:06 ` Olof Johansson
2013-08-01 20:06 ` Olof Johansson
2013-08-02 20:44 ` Stephen Boyd
2013-08-02 20:44 ` Stephen Boyd
2013-08-02 20:50 ` Olof Johansson
2013-08-02 20:50 ` Olof Johansson
2013-08-02 20:56 ` Stephen Boyd
2013-08-02 20:56 ` Stephen Boyd
2013-08-02 20:59 ` Olof Johansson
2013-08-02 20:59 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801182707.GB23053@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.