From: David Miller <davem@davemloft.net>
To: pmoore@redhat.com
Cc: amwang@redhat.com, netdev@vger.kernel.org,
james.l.morris@oracle.com, sds@tycho.nsa.gov,
eparis@parisplace.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [Patch net-next v2 8/8] selinux: use generic union inet_addr
Date: Fri, 02 Aug 2013 14:51:46 -0700 (PDT) [thread overview]
Message-ID: <20130802.145146.215059840395396296.davem@davemloft.net> (raw)
In-Reply-To: <4528870.px4VD3WrY3@sifl>
From: Paul Moore <pmoore@redhat.com>
Date: Fri, 02 Aug 2013 10:34:07 -0400
> On Friday, August 02, 2013 03:14:34 PM Cong Wang wrote:
>> From: Cong Wang <amwang@redhat.com>
>>
>> selinux has some similar definition like union inet_addr,
>> it can re-use the generic union inet_addr too.
>>
>> Cc: James Morris <james.l.morris@oracle.com>
>> Cc: Stephen Smalley <sds@tycho.nsa.gov>
>> Cc: Eric Paris <eparis@parisplace.org>
>> Cc: Paul Moore <pmoore@redhat.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-security-module@vger.kernel.org
>> Signed-off-by: Cong Wang <amwang@redhat.com>
>
> Perhaps I'm confusing this with another patch but I though DaveM said he
> wasn't going to merge these patches?
I didn't like how he added completely unused bloat to various
datastructures because he unconditionally put a port field into
there.
He removed that problem this time, but there are still a lot of
things I don't like about this patch series.
prev parent reply other threads:[~2013-08-02 21:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 7:14 [Patch net-next v2 0/8] net: introduce generic type and helpers for IP address Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 1/8] net: introduce generic union inet_addr Cong Wang
2013-08-02 21:50 ` David Miller
2013-08-05 3:09 ` Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 2/8] net: introduce generic simple_inet_pton() Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 3/8] inetpeer: use generic struct in_addr_gen Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 4/8] bridge: " Cong Wang
[not found] ` <1375427674-21735-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-02 7:14 ` [Patch net-next v2 5/8] sunrpc: use generic union inet_addr Cong Wang
2013-08-02 7:14 ` Cong Wang
2013-08-02 13:36 ` Jeff Layton
[not found] ` <20130802093625.2c70a330-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-05 3:14 ` Cong Wang
2013-08-05 3:14 ` Cong Wang
2013-08-06 10:28 ` Jeff Layton
2013-08-06 10:28 ` Jeff Layton
[not found] ` <20130806062801.67714276-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-07 12:27 ` Cong Wang
2013-08-07 12:27 ` Cong Wang
2013-08-07 13:21 ` Jeff Layton
[not found] ` <20130807092123.451e93db-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-08 1:37 ` Cong Wang
2013-08-08 1:37 ` Cong Wang
2013-08-07 13:30 ` Jim Rees
2013-08-07 13:30 ` Jim Rees
2013-08-02 7:14 ` [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions Cong Wang
2013-08-02 7:14 ` [Cluster-devel] " Cong Wang
2013-08-02 10:31 ` Christoph Hellwig
2013-08-02 10:31 ` Christoph Hellwig
[not found] ` <20130802103107.GA17244-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-08-05 3:16 ` Cong Wang
2013-08-05 3:16 ` Cong Wang
2013-08-05 3:16 ` Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 7/8] sctp: use generic union inet_addr Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 8/8] selinux: " Cong Wang
2013-08-02 14:34 ` Paul Moore
2013-08-02 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802.145146.215059840395396296.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmoore@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.