From: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Trond Myklebust
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [Cluster-devel] [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions
Date: Mon, 05 Aug 2013 11:16:54 +0800 [thread overview]
Message-ID: <1375672614.32485.9.camel@cr0> (raw)
In-Reply-To: <20130802103107.GA17244-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Fri, 2013-08-02 at 03:31 -0700, Christoph Hellwig wrote:
> On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
> > From: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> > nfs and cifs define some helper functions for sockaddr,
> > they can use the generic functions for union inet_addr too.
> >
> > Since some dlm code needs to compare ->sin_port, introduce a
> > generic function inet_addr_equal_strict() for it.
>
> Would sound more useful to have a sockaddr_equal case that can be used
> on any sockaddr. For cases that no current user handles just return
> false.
>
Ok, since you and other people ask for it.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: netdev@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-nfs@vger.kernel.org, cluster-devel@redhat.com,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Cluster-devel] [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions
Date: Mon, 05 Aug 2013 11:16:54 +0800 [thread overview]
Message-ID: <1375672614.32485.9.camel@cr0> (raw)
In-Reply-To: <20130802103107.GA17244@infradead.org>
On Fri, 2013-08-02 at 03:31 -0700, Christoph Hellwig wrote:
> On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> >
> > nfs and cifs define some helper functions for sockaddr,
> > they can use the generic functions for union inet_addr too.
> >
> > Since some dlm code needs to compare ->sin_port, introduce a
> > generic function inet_addr_equal_strict() for it.
>
> Would sound more useful to have a sockaddr_equal case that can be used
> on any sockaddr. For cases that no current user handles just return
> false.
>
Ok, since you and other people ask for it.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions
Date: Mon, 05 Aug 2013 11:16:54 +0800 [thread overview]
Message-ID: <1375672614.32485.9.camel@cr0> (raw)
In-Reply-To: <20130802103107.GA17244@infradead.org>
On Fri, 2013-08-02 at 03:31 -0700, Christoph Hellwig wrote:
> On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> >
> > nfs and cifs define some helper functions for sockaddr,
> > they can use the generic functions for union inet_addr too.
> >
> > Since some dlm code needs to compare ->sin_port, introduce a
> > generic function inet_addr_equal_strict() for it.
>
> Would sound more useful to have a sockaddr_equal case that can be used
> on any sockaddr. For cases that no current user handles just return
> false.
>
Ok, since you and other people ask for it.
Thanks.
next prev parent reply other threads:[~2013-08-05 3:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 7:14 [Patch net-next v2 0/8] net: introduce generic type and helpers for IP address Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 1/8] net: introduce generic union inet_addr Cong Wang
2013-08-02 21:50 ` David Miller
2013-08-05 3:09 ` Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 2/8] net: introduce generic simple_inet_pton() Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 3/8] inetpeer: use generic struct in_addr_gen Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 4/8] bridge: " Cong Wang
[not found] ` <1375427674-21735-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-02 7:14 ` [Patch net-next v2 5/8] sunrpc: use generic union inet_addr Cong Wang
2013-08-02 7:14 ` Cong Wang
2013-08-02 13:36 ` Jeff Layton
[not found] ` <20130802093625.2c70a330-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-05 3:14 ` Cong Wang
2013-08-05 3:14 ` Cong Wang
2013-08-06 10:28 ` Jeff Layton
2013-08-06 10:28 ` Jeff Layton
[not found] ` <20130806062801.67714276-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-07 12:27 ` Cong Wang
2013-08-07 12:27 ` Cong Wang
2013-08-07 13:21 ` Jeff Layton
[not found] ` <20130807092123.451e93db-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-08 1:37 ` Cong Wang
2013-08-08 1:37 ` Cong Wang
2013-08-07 13:30 ` Jim Rees
2013-08-07 13:30 ` Jim Rees
2013-08-02 7:14 ` [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions Cong Wang
2013-08-02 7:14 ` [Cluster-devel] " Cong Wang
2013-08-02 10:31 ` Christoph Hellwig
2013-08-02 10:31 ` Christoph Hellwig
[not found] ` <20130802103107.GA17244-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-08-05 3:16 ` Cong Wang [this message]
2013-08-05 3:16 ` Cong Wang
2013-08-05 3:16 ` Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 7/8] sctp: use generic union inet_addr Cong Wang
2013-08-02 7:14 ` [Patch net-next v2 8/8] selinux: " Cong Wang
2013-08-02 14:34 ` Paul Moore
2013-08-02 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375672614.32485.9.camel@cr0 \
--to=amwang-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.