From: Mark Brown <broonie@kernel.org>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Padmavathi Venna <padma.v@samsung.com>,
abrestic@chromium.org, Tomasz Figa <t.figa@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 2/3] ASoC: Samsung: I2S: Add quirks as driver data in I2S
Date: Thu, 8 Aug 2013 11:31:24 +0100 [thread overview]
Message-ID: <20130808103124.GU6427@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-BdpsgQk8myq7OOk5zJ8Zxy+J6LUPb3-d40+iE2aNwdwDw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 616 bytes --]
On Thu, Aug 08, 2013 at 01:13:02PM +0530, Padma Venkat wrote:
> If legacy platforms not required to change then I need to introduce a
> new samsung_i2s_dai_data structure which holds only dai_type for
> non-dt platforms. If I change legacy platforms it breaks the older
> platforms now. Is it okay adding a samsung_i2s_dai_data structure for
> non-dt platforms which will be removed later?
This is totally fine and looks much nicer - you're not creating DT style
names in the platform bus, nor making names that are so long that we
need to expand the maximum length of a plaform device name (which isn't
awesome).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/3] ASoC: Samsung: I2S: Add quirks as driver data in I2S
Date: Thu, 8 Aug 2013 11:31:24 +0100 [thread overview]
Message-ID: <20130808103124.GU6427@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-BdpsgQk8myq7OOk5zJ8Zxy+J6LUPb3-d40+iE2aNwdwDw@mail.gmail.com>
On Thu, Aug 08, 2013 at 01:13:02PM +0530, Padma Venkat wrote:
> If legacy platforms not required to change then I need to introduce a
> new samsung_i2s_dai_data structure which holds only dai_type for
> non-dt platforms. If I change legacy platforms it breaks the older
> platforms now. Is it okay adding a samsung_i2s_dai_data structure for
> non-dt platforms which will be removed later?
This is totally fine and looks much nicer - you're not creating DT style
names in the platform bus, nor making names that are so long that we
need to expand the maximum length of a plaform device name (which isn't
awesome).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130808/3311f5b7/attachment.sig>
next prev parent reply other threads:[~2013-08-08 10:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 8:45 [PATCH V3 0/3] Add audio support on smdk5420 Padmavathi Venna
2013-08-07 8:45 ` Padmavathi Venna
2013-08-07 8:45 ` [PATCH V3 1/3] platform: Increase platform name size Padmavathi Venna
2013-08-07 8:45 ` Padmavathi Venna
2013-08-07 14:00 ` Mark Brown
2013-08-07 14:00 ` Mark Brown
2013-08-07 8:45 ` [PATCH V3 2/3] ASoC: Samsung: I2S: Add quirks as driver data in I2S Padmavathi Venna
2013-08-07 8:45 ` Padmavathi Venna
2013-08-07 11:02 ` Tomasz Figa
2013-08-07 11:02 ` Tomasz Figa
2013-08-07 12:03 ` Padma Venkat
2013-08-07 12:03 ` Padma Venkat
2013-08-07 11:13 ` Tomasz Figa
2013-08-07 11:13 ` Tomasz Figa
2013-08-08 7:43 ` Padma Venkat
2013-08-08 7:43 ` Padma Venkat
2013-08-08 8:10 ` Tomasz Figa
2013-08-08 8:10 ` Tomasz Figa
2013-08-08 10:31 ` Mark Brown [this message]
2013-08-08 10:31 ` Mark Brown
2013-08-07 8:45 ` [PATCH V3 3/3] ASoC: Samsung: I2S: Modify the I2S driver to support I2S on Exynos5420 Padmavathi Venna
2013-08-07 8:45 ` Padmavathi Venna
2013-08-08 23:05 ` Tomasz Figa
2013-08-08 23:05 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808103124.GU6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.