From: Will Deacon <will.deacon@arm.com>
To: Mark Salter <msalter@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: add screen_info for console support
Date: Tue, 20 Aug 2013 14:37:33 +0100 [thread overview]
Message-ID: <20130820133733.GF26129@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1376842970.11104.11.camel@t520.redhat.com>
Hi Mark,
On Sun, Aug 18, 2013 at 05:22:50PM +0100, Mark Salter wrote:
> The arm64 port doesn't provide a screen_info struct for console support
> which leads to a build failure with some configurations:
>
> drivers/video/console/vgacon.c:820: undefined reference to `screen_info'
>
> This patch adds an empty declaration of screen_info to fix the build
> problem. Some additional runtime code is needed to actually make it
> useful.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
> ---
> arch/arm64/kernel/setup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index add6ea6..eb9f93a 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -64,6 +64,10 @@ static const char *cpu_name;
> static const char *machine_name;
> phys_addr_t __fdt_pointer __initdata;
>
> +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_DUMMY_CONSOLE)
> +struct screen_info screen_info;
> +#endif
You may be able to do something similar to the proposal for PARPORT here and
factor out the lengthy "depends on" clause for VGA_CONSOLE instead of adding
the dummy info.
Unfortunately, I can't make any promise of further bonus points :)
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add screen_info for console support
Date: Tue, 20 Aug 2013 14:37:33 +0100 [thread overview]
Message-ID: <20130820133733.GF26129@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1376842970.11104.11.camel@t520.redhat.com>
Hi Mark,
On Sun, Aug 18, 2013 at 05:22:50PM +0100, Mark Salter wrote:
> The arm64 port doesn't provide a screen_info struct for console support
> which leads to a build failure with some configurations:
>
> drivers/video/console/vgacon.c:820: undefined reference to `screen_info'
>
> This patch adds an empty declaration of screen_info to fix the build
> problem. Some additional runtime code is needed to actually make it
> useful.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
> ---
> arch/arm64/kernel/setup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index add6ea6..eb9f93a 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -64,6 +64,10 @@ static const char *cpu_name;
> static const char *machine_name;
> phys_addr_t __fdt_pointer __initdata;
>
> +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_DUMMY_CONSOLE)
> +struct screen_info screen_info;
> +#endif
You may be able to do something similar to the proposal for PARPORT here and
factor out the lengthy "depends on" clause for VGA_CONSOLE instead of adding
the dummy info.
Unfortunately, I can't make any promise of further bonus points :)
Will
next prev parent reply other threads:[~2013-08-20 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 16:22 [PATCH] arm64: add screen_info for console support Mark Salter
2013-08-18 16:22 ` Mark Salter
2013-08-20 13:37 ` Will Deacon [this message]
2013-08-20 13:37 ` Will Deacon
2013-08-20 17:14 ` Catalin Marinas
2013-08-20 17:14 ` Catalin Marinas
2013-08-20 18:04 ` Mark Salter
2013-08-20 18:04 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820133733.GF26129@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.