All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>,
	Nobuyuki HIRAI <nobuyuki.hirai.xe@renesas.com>,
	Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH 5/6] ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal
Date: Wed, 25 Sep 2013 07:12:27 +0000	[thread overview]
Message-ID: <20130925071226.GP6663@verge.net.au> (raw)
In-Reply-To: <1373484077-10460-6-git-send-email-g.liakhovetski@gmx.de>

On Wed, Jul 10, 2013 at 09:21:16PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on ape6evm.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-ape6evm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index e9e2108e..96a6994 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> @@ -77,6 +77,7 @@ static struct sh_mmcif_plat_data mmcif0_pdata = {
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> +	.ccs_unsupported = true,
>  };
>  
>  static struct resource mmcif0_resources[] = {

Thanks, I have queued up the following for v3.13.


From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal

MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on ape6evm.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/board-ape6evm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index 02be420..0365d2e 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -162,6 +162,7 @@ static struct regulator_consumer_supply vcc_sdhi1_consumers[]  /* MMCIF */
 static const struct sh_mmcif_plat_data mmcif0_pdata __initconst = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.ccs_unsupported = true,
 };
 
 static const struct resource mmcif0_resources[] __initconst = {
-- 
1.8.4


WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>,
	Nobuyuki HIRAI <nobuyuki.hirai.xe@renesas.com>,
	Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH 5/6] ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal
Date: Wed, 25 Sep 2013 16:12:27 +0900	[thread overview]
Message-ID: <20130925071226.GP6663@verge.net.au> (raw)
In-Reply-To: <1373484077-10460-6-git-send-email-g.liakhovetski@gmx.de>

On Wed, Jul 10, 2013 at 09:21:16PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on ape6evm.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-ape6evm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index e9e2108e..96a6994 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> @@ -77,6 +77,7 @@ static struct sh_mmcif_plat_data mmcif0_pdata = {
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> +	.ccs_unsupported = true,
>  };
>  
>  static struct resource mmcif0_resources[] = {

Thanks, I have queued up the following for v3.13.


From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal

MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on ape6evm.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/board-ape6evm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index 02be420..0365d2e 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -162,6 +162,7 @@ static struct regulator_consumer_supply vcc_sdhi1_consumers[] =
 /* MMCIF */
 static const struct sh_mmcif_plat_data mmcif0_pdata __initconst = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.ccs_unsupported = true,
 };
 
 static const struct resource mmcif0_resources[] __initconst = {
-- 
1.8.4


  reply	other threads:[~2013-09-25  7:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
2013-07-10 19:21 ` Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 2/6] mmc: sh_mmcif: revision-specific CLK_CTRL2 handling Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-09-25  7:12     ` Simon Horman
2013-09-25  7:12   ` Simon Horman
2013-09-25  7:12     ` Simon Horman
2013-07-10 19:21 ` [PATCH 4/6] ARM: shmobile: kzm9g: " Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-09-25  7:12     ` Simon Horman
2013-07-10 19:21 ` [PATCH 5/6] ARM: shmobile: ape6evm: " Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman [this message]
2013-09-25  7:12     ` Simon Horman
2013-07-10 19:21 ` [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2 Guennadi Liakhovetski
2013-07-10 19:21   ` Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-09-25  7:12     ` Simon Horman
2013-08-25  4:12 ` [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Chris Ball
2013-08-25  4:12   ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130925071226.GP6663@verge.net.au \
    --to=horms@verge.net.au \
    --cc=cjb@laptop.org \
    --cc=g.liakhovetski+renesas@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=nobuyuki.hirai.xe@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.