From: Benjamin LaHaise <bcrl@kvack.org> To: Christoph Hellwig <hch@infradead.org> Cc: Dave Kleikamp <dave.kleikamp@oracle.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, "Maxim V. Patlasov" <mpatlasov@parallels.com>, Zach Brown <zab@zabbo.net>, linux-aio@kvack.org Subject: Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec Date: Tue, 15 Oct 2013 13:14:47 -0400 [thread overview] Message-ID: <20131015171447.GE31920@kvack.org> (raw) In-Reply-To: <20131015165520.GA13021@infradead.org> On Tue, Oct 15, 2013 at 09:55:20AM -0700, Christoph Hellwig wrote: > On Mon, Oct 14, 2013 at 05:29:10PM -0400, Benjamin LaHaise wrote: > > On Mon, Oct 14, 2013 at 08:07:01AM -0700, Christoph Hellwig wrote: > > > Ben, > > > > > > are you fine with the series now? It's been in linux-next for a while > > > and it would be really helpful to get it in for the avarious places > > > trying to do in-kernel file aio without going through the page cache. > > > > No, I am not okay with it. The feedback I provided 2 months ago has yet to > > be addressed. > > Maybe I'm missing something, but the only big discussion item was that > you'd want something totally unrelated (notification for blocking) > mashed into this patch set. No, that is not what I was refering to. > While I agree that getting that would be useful it is something that has > nothing to do with issueing aio from kernel space and holding this > patchset hostage for something you'd like to see but that was > complicated enough that no one even tried it for many years seems > entirely unreasonable. > > If there are any other issues left that I have missed it would be nice > to get a pointer to it, or a quick brief. The item I was refering to is to removing the opcodes used for in-kernel purposes from out of the range that the userland accessible opcodes can reach. That is, put them above the 16 bit limit for userspace opcodes. There is absolutely no reason to expose kernel internal opcodes via the userspace exported includes. It's a simple and reasonable change, and I see no reason for Dave not to make that modification. Until that is done, I will nak the changes. -ben -- "Thought is the essence of where you are now."
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin LaHaise <bcrl@kvack.org> To: Christoph Hellwig <hch@infradead.org> Cc: Dave Kleikamp <dave.kleikamp@oracle.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, "Maxim V. Patlasov" <mpatlasov@parallels.com>, Zach Brown <zab@zabbo.net>, linux-aio@kvack.org Subject: Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec Date: Tue, 15 Oct 2013 13:14:47 -0400 [thread overview] Message-ID: <20131015171447.GE31920@kvack.org> (raw) In-Reply-To: <20131015165520.GA13021@infradead.org> On Tue, Oct 15, 2013 at 09:55:20AM -0700, Christoph Hellwig wrote: > On Mon, Oct 14, 2013 at 05:29:10PM -0400, Benjamin LaHaise wrote: > > On Mon, Oct 14, 2013 at 08:07:01AM -0700, Christoph Hellwig wrote: > > > Ben, > > > > > > are you fine with the series now? It's been in linux-next for a while > > > and it would be really helpful to get it in for the avarious places > > > trying to do in-kernel file aio without going through the page cache. > > > > No, I am not okay with it. The feedback I provided 2 months ago has yet to > > be addressed. > > Maybe I'm missing something, but the only big discussion item was that > you'd want something totally unrelated (notification for blocking) > mashed into this patch set. No, that is not what I was refering to. > While I agree that getting that would be useful it is something that has > nothing to do with issueing aio from kernel space and holding this > patchset hostage for something you'd like to see but that was > complicated enough that no one even tried it for many years seems > entirely unreasonable. > > If there are any other issues left that I have missed it would be nice > to get a pointer to it, or a quick brief. The item I was refering to is to removing the opcodes used for in-kernel purposes from out of the range that the userland accessible opcodes can reach. That is, put them above the 16 bit limit for userspace opcodes. There is absolutely no reason to expose kernel internal opcodes via the userspace exported includes. It's a simple and reasonable change, and I see no reason for Dave not to make that modification. Until that is done, I will nak the changes. -ben -- "Thought is the essence of where you are now." -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2013-10-15 17:14 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-25 17:50 [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 01/33] iov_iter: move into its own file Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 02/33] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 03/33] iov_iter: add copy_to_user support Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 04/33] iov_iter: add __iovec_copy_to_user() Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 05/33] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 06/33] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 07/33] iov_iter: ii_iovec_copy_to_user should pre-fault user pages Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 08/33] iov_iter: add bvec support Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 09/33] iov_iter: add a shorten call Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 10/33] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 11/33] dio: Convert direct_IO to use iov_iter Dave Kleikamp 2013-08-23 15:48 ` Geert Uytterhoeven 2013-08-23 15:48 ` Geert Uytterhoeven 2013-07-25 17:50 ` [PATCH V8 12/33] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 13/33] fs: pull iov_iter use higher up the stack Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 14/33] aio: add aio_kernel_() interface Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 15/33] aio: add aio support for iov_iter arguments Dave Kleikamp 2013-08-21 13:55 ` Benjamin LaHaise 2013-08-30 20:05 ` Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 16/33] bio: add bvec_length(), like iov_length() Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 17/33] loop: use aio to perform io on the underlying file Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 18/33] fs: create file_readable() and file_writable() functions Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 19/33] fs: use read_iter and write_iter rather than aio_read and aio_write Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 20/33] fs: add read_iter and write_iter to several file systems Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 21/33] ocfs2: add support for read_iter and write_iter Dave Kleikamp 2013-07-25 17:50 ` [Ocfs2-devel] " Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 22/33] ext4: " Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 23/33] nfs: add support for read_iter, write_iter Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 24/33] nfs: simplify swap Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 25/33] btrfs: add support for read_iter and write_iter Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 26/33] block_dev: add support for read_iter, write_iter Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 27/33] xfs: add support for read_iter and write_iter Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-26 11:51 ` Dave Chinner 2013-07-26 11:51 ` Dave Chinner 2013-07-25 17:50 ` [PATCH V8 28/33] gfs2: Convert aio_read/write ops to read/write_iter Dave Kleikamp 2013-07-25 17:50 ` [Cluster-devel] " Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 29/33] udf: convert file ops from aio_read/write " Dave Kleikamp 2013-07-25 21:34 ` Jan Kara 2013-07-25 17:50 ` [PATCH V8 30/33] afs: add support for read_iter and write_iter Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 31/33] ecrpytfs: Convert aio_read/write ops to read/write_iter Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 32/33] ubifs: convert file ops from aio_read/write " Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-25 17:50 ` Dave Kleikamp 2013-07-25 17:50 ` [PATCH V8 33/33] tmpfs: add support for read_iter and write_iter Dave Kleikamp 2013-07-30 21:28 ` [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec Andrew Morton 2013-07-31 0:43 ` Dave Chinner 2013-07-31 6:40 ` Sedat Dilek 2013-07-31 8:41 ` Sedat Dilek 2013-07-31 11:22 ` Sedat Dilek 2013-07-31 9:51 ` Maxim Patlasov 2013-08-01 8:58 ` Christoph Hellwig 2013-08-01 13:04 ` Dave Kleikamp 2013-08-02 10:48 ` Christoph Hellwig 2013-08-20 13:00 ` Christoph Hellwig 2013-08-20 19:13 ` Dave Kleikamp 2013-08-21 0:14 ` Stephen Rothwell 2013-08-21 5:35 ` Sedat Dilek 2013-08-20 22:46 ` Andrew Morton 2013-08-21 13:02 ` Benjamin LaHaise 2013-08-21 13:02 ` Benjamin LaHaise 2013-08-21 16:30 ` Dave Kleikamp 2013-08-21 16:30 ` Dave Kleikamp 2013-08-21 16:39 ` Benjamin LaHaise 2013-08-21 16:39 ` Benjamin LaHaise 2013-08-21 17:12 ` Dave Kleikamp 2013-08-21 17:12 ` Dave Kleikamp 2013-08-21 19:30 ` Andrew Morton 2013-08-21 19:30 ` Andrew Morton 2013-08-21 20:24 ` Benjamin LaHaise 2013-08-21 20:24 ` Benjamin LaHaise 2013-10-14 15:07 ` Christoph Hellwig 2013-10-14 21:29 ` Benjamin LaHaise 2013-10-14 21:29 ` Benjamin LaHaise 2013-10-15 16:55 ` Christoph Hellwig 2013-10-15 17:14 ` Benjamin LaHaise [this message] 2013-10-15 17:14 ` Benjamin LaHaise 2013-10-15 17:18 ` Christoph Hellwig 2013-10-15 17:18 ` Christoph Hellwig 2013-10-15 17:53 ` Dave Kleikamp 2013-10-15 17:53 ` Dave Kleikamp 2014-12-31 20:38 ` Sedat Dilek 2014-12-31 21:52 ` Dave Kleikamp 2014-12-31 22:35 ` Sedat Dilek 2015-01-01 0:52 ` Ming Lei 2015-01-05 19:24 ` Maxim Patlasov 2015-01-06 13:18 ` Ming Lei 2015-01-10 16:51 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20131015171447.GE31920@kvack.org \ --to=bcrl@kvack.org \ --cc=akpm@linux-foundation.org \ --cc=dave.kleikamp@oracle.com \ --cc=hch@infradead.org \ --cc=linux-aio@kvack.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mpatlasov@parallels.com \ --cc=zab@zabbo.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.