All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brown <davidb@codeaurora.org>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: Kumar Gala <galak@codeaurora.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Russell King <linux@arm.linux.org.uk>,
	Daniel Walker <dwalker@fifo99.com>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCHv6 2/4] ARM: msm: Add support for APQ8074 Dragonboard
Date: Thu, 17 Oct 2013 13:51:32 -0700	[thread overview]
Message-ID: <20131017205132.GA3459@codeaurora.org> (raw)
In-Reply-To: <1382034310-31147-1-git-send-email-rvaswani@codeaurora.org>

On Thu, Oct 17, 2013 at 11:25:10AM -0700, Rohit Vaswani wrote:
>This patch adds basic board support for APQ8074 Dragonboard
>which belongs to the Snapdragon 800 family.
>For now, just support a basic machine with device tree.
>
>Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
>---

Do you mind putting some history in the commentary part of your
patches, especially, like this one, when you make it to v6.  Just a
brief description of what you've changed makes it a lot easier for
reviewers to determine if their concern has been addressed, and what
else might have changed.

This missed yesterday's pull request, so I'll probably make another
one to include this.

David

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 2/4] ARM: msm: Add support for APQ8074 Dragonboard
Date: Thu, 17 Oct 2013 13:51:32 -0700	[thread overview]
Message-ID: <20131017205132.GA3459@codeaurora.org> (raw)
In-Reply-To: <1382034310-31147-1-git-send-email-rvaswani@codeaurora.org>

On Thu, Oct 17, 2013 at 11:25:10AM -0700, Rohit Vaswani wrote:
>This patch adds basic board support for APQ8074 Dragonboard
>which belongs to the Snapdragon 800 family.
>For now, just support a basic machine with device tree.
>
>Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
>---

Do you mind putting some history in the commentary part of your
patches, especially, like this one, when you make it to v6.  Just a
brief description of what you've changed makes it a lot easier for
reviewers to determine if their concern has been addressed, and what
else might have changed.

This missed yesterday's pull request, so I'll probably make another
one to include this.

David

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

  parent reply	other threads:[~2013-10-17 20:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 18:25 [PATCHv6 2/4] ARM: msm: Add support for APQ8074 Dragonboard Rohit Vaswani
2013-10-17 18:25 ` Rohit Vaswani
2013-10-17 18:28 ` Kumar Gala
2013-10-17 18:28   ` Kumar Gala
2013-10-17 20:51 ` David Brown [this message]
2013-10-17 20:51   ` David Brown
2013-10-17 21:31 ` [PATCH 0/3] APQ8074 updates Stephen Boyd
2013-10-17 21:31   ` Stephen Boyd
2013-10-17 21:31   ` [PATCH 1/3] ARM: msm: Simplify ARCH_MSM_DT config Stephen Boyd
2013-10-17 21:31     ` Stephen Boyd
2013-10-17 21:31   ` [PATCH 2/3] ARM: dts: MSM8974: Add restart node Stephen Boyd
2013-10-17 21:31     ` Stephen Boyd
2013-10-17 21:31   ` [PATCH 3/3] ARM: dts: MSM8974: Add MMIO architected timer node Stephen Boyd
2013-10-17 21:31     ` Stephen Boyd
2013-10-18 17:56 ` [PATCH v2 0/4] APQ8074 updates Stephen Boyd
2013-10-18 17:56   ` Stephen Boyd
2013-10-18 17:56   ` Stephen Boyd
2013-10-18 17:56   ` [PATCH v2 1/4] ARM: msm: Simplify ARCH_MSM_DT config Stephen Boyd
2013-10-18 17:56     ` Stephen Boyd
2013-10-18 17:56   ` [PATCH v2 2/4] ARM: dts: MSM8974: Add restart node Stephen Boyd
2013-10-18 17:56     ` Stephen Boyd
2013-10-18 17:56   ` [PATCH v2 3/4] ARM: dts: MSM8974: Add MMIO architected timer node Stephen Boyd
2013-10-18 17:56     ` Stephen Boyd
2013-10-18 17:56   ` [PATCH v2 4/4] ARM: msm_defconfig: Enable restart driver Stephen Boyd
2013-10-18 17:56     ` Stephen Boyd
2013-10-18 17:56     ` Stephen Boyd
2013-10-25 17:12 ` [PATCHv6 2/4] ARM: msm: Add support for APQ8074 Dragonboard Josh Cartwright
2013-10-25 17:12   ` Josh Cartwright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017205132.GA3459@codeaurora.org \
    --to=davidb@codeaurora.org \
    --cc=bryanh@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dwalker@fifo99.com \
    --cc=galak@codeaurora.org \
    --cc=ian.campbell@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rvaswani@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.