From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
Cc: "Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Rob Herring"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Stephen Warren"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver.
Date: Thu, 24 Oct 2013 16:15:34 +0800 [thread overview]
Message-ID: <20131024081531.GA13614@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1382601665-6830-3-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
On Thu, Oct 24, 2013 at 10:01:01AM +0200, Denis Carikli wrote:
> Without that patch, a user can't select the imxfb driver when the i.MX25 and/or
> the i.MX27 device tree board are selected and that no boards that selects
> IMX_HAVE_PLATFORM_IMX_FB are compiled in.
>
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> Cc: Eric Bénard <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
>
> Signed-off-by: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
> ---
> ChangeLog v5->v6:
> - Reworked the patch not to make DT boards depend on IMX_HAVE_PLATFORM_IMX_FB.
> - Added better explanations of why that patch is needed in the commit message.
> ---
> arch/arm/mach-imx/Kconfig | 5 +++++
> arch/arm/mach-imx/devices/Kconfig | 1 +
> drivers/video/Kconfig | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 9f67338..3ccb5d5 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -64,6 +64,9 @@ config ARCH_HAS_RNGA
> config HAVE_IMX_ANATOP
> bool
>
> +config HAVE_IMX_FB
> + bool
> +
> config HAVE_IMX_GPC
> bool
>
> @@ -254,6 +257,7 @@ endchoice
> config MACH_IMX25_DT
> bool "Support i.MX25 platforms from device tree"
> select SOC_IMX25
> + select HAVE_IMX_FB
> help
> Include support for Freescale i.MX25 based platforms
> using the device tree for discovery
> @@ -442,6 +446,7 @@ config MACH_IMX27IPCAM
> config MACH_IMX27_DT
> bool "Support i.MX27 platforms from device tree"
> select SOC_IMX27
> + select HAVE_IMX_FB
> help
> Include support for Freescale i.MX27 based platforms
> using the device tree for discovery
> diff --git a/arch/arm/mach-imx/devices/Kconfig b/arch/arm/mach-imx/devices/Kconfig
> index 68c74fb..a7af9f4 100644
> --- a/arch/arm/mach-imx/devices/Kconfig
> +++ b/arch/arm/mach-imx/devices/Kconfig
> @@ -26,6 +26,7 @@ config IMX_HAVE_PLATFORM_IMXDI_RTC
> bool
>
> config IMX_HAVE_PLATFORM_IMX_FB
> + select HAVE_IMX_FB
> bool
>
> config IMX_HAVE_PLATFORM_IMX_I2C
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 14317b7..a97529f 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -363,7 +363,7 @@ config FB_SA1100
>
> config FB_IMX
> tristate "Freescale i.MX1/21/25/27 LCD support"
> - depends on FB && IMX_HAVE_PLATFORM_IMX_FB
> + depends on FB && HAVE_IMX_FB
Or simply have it depend on ARCH_MXC?
depends on FB && ARCH_MXC
Shawn
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver.
Date: Thu, 24 Oct 2013 16:15:34 +0800 [thread overview]
Message-ID: <20131024081531.GA13614@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1382601665-6830-3-git-send-email-denis@eukrea.com>
On Thu, Oct 24, 2013 at 10:01:01AM +0200, Denis Carikli wrote:
> Without that patch, a user can't select the imxfb driver when the i.MX25 and/or
> the i.MX27 device tree board are selected and that no boards that selects
> IMX_HAVE_PLATFORM_IMX_FB are compiled in.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: devicetree at vger.kernel.org
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Eric B?nard <eric@eukrea.com>
>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
> ChangeLog v5->v6:
> - Reworked the patch not to make DT boards depend on IMX_HAVE_PLATFORM_IMX_FB.
> - Added better explanations of why that patch is needed in the commit message.
> ---
> arch/arm/mach-imx/Kconfig | 5 +++++
> arch/arm/mach-imx/devices/Kconfig | 1 +
> drivers/video/Kconfig | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 9f67338..3ccb5d5 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -64,6 +64,9 @@ config ARCH_HAS_RNGA
> config HAVE_IMX_ANATOP
> bool
>
> +config HAVE_IMX_FB
> + bool
> +
> config HAVE_IMX_GPC
> bool
>
> @@ -254,6 +257,7 @@ endchoice
> config MACH_IMX25_DT
> bool "Support i.MX25 platforms from device tree"
> select SOC_IMX25
> + select HAVE_IMX_FB
> help
> Include support for Freescale i.MX25 based platforms
> using the device tree for discovery
> @@ -442,6 +446,7 @@ config MACH_IMX27IPCAM
> config MACH_IMX27_DT
> bool "Support i.MX27 platforms from device tree"
> select SOC_IMX27
> + select HAVE_IMX_FB
> help
> Include support for Freescale i.MX27 based platforms
> using the device tree for discovery
> diff --git a/arch/arm/mach-imx/devices/Kconfig b/arch/arm/mach-imx/devices/Kconfig
> index 68c74fb..a7af9f4 100644
> --- a/arch/arm/mach-imx/devices/Kconfig
> +++ b/arch/arm/mach-imx/devices/Kconfig
> @@ -26,6 +26,7 @@ config IMX_HAVE_PLATFORM_IMXDI_RTC
> bool
>
> config IMX_HAVE_PLATFORM_IMX_FB
> + select HAVE_IMX_FB
> bool
>
> config IMX_HAVE_PLATFORM_IMX_I2C
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 14317b7..a97529f 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -363,7 +363,7 @@ config FB_SA1100
>
> config FB_IMX
> tristate "Freescale i.MX1/21/25/27 LCD support"
> - depends on FB && IMX_HAVE_PLATFORM_IMX_FB
> + depends on FB && HAVE_IMX_FB
Or simply have it depend on ARCH_MXC?
depends on FB && ARCH_MXC
Shawn
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-10-24 8:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:00 [PATCHv6][ 1/7] video: imxfb: Introduce regulator support Denis Carikli
2013-10-24 8:00 ` Denis Carikli
[not found] ` <1382601665-6830-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-10-24 8:01 ` [PATCHv6][ 2/7] video: imxfb: Also add pwmr for the device tree Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 3/7] ARM: imx{25, 27} " Denis Carikli
[not found] ` <1382601665-6830-3-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-10-24 8:15 ` Shawn Guo [this message]
2013-10-24 8:15 ` [PATCHv6][ 3/7] ARM: imx{25,27} " Shawn Guo
2013-10-24 8:20 ` Eric Bénard
2013-10-24 8:20 ` Eric Bénard
2013-10-24 8:31 ` Shawn Guo
2013-10-24 8:31 ` Shawn Guo
[not found] ` <20131024083143.GB13614-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2013-10-24 8:36 ` Eric Bénard
2013-10-24 8:36 ` Eric Bénard
2013-10-24 8:01 ` [PATCHv6][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 5/7] ARM: dts: imx25.dtsi: Add some pinmux pins Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 6/7] ARM: dts: Add support for the cpuimx25 board from Eukrea and its baseboard Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 7/7] ARM: imx_v4_v5_defconfig: Enable gpio regulator and gpio button/keyboard Denis Carikli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024081531.GA13614@S2101-09.ap.freescale.net \
--to=shawn.guo-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.