From: Grant Likely <grant.likely@secretlab.ca> To: Sascha Hauer <kernel@pengutronix.de> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Stephen Warren <swarren@wwwdotorg.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Rob Herring <rob.herring@calxeda.com>, Denis Carikli <denis@eukrea.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Shawn Guo <shawn.guo@linaro.org>, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv7][ 2/6] video: imxfb: Also add pwmr for the device tree. Date: Thu, 24 Oct 2013 11:13:06 +0100 [thread overview] Message-ID: <20131024101306.C8882C4039D@trevor.secretlab.ca> (raw) In-Reply-To: <1382605103-9595-2-git-send-email-denis@eukrea.com> [-- Attachment #1: Type: text/plain, Size: 2516 bytes --] On Thu, 24 Oct 2013 10:58:19 +0200, Denis Carikli <denis@eukrea.com> wrote: > pwmr has to be set to get the imxfb backlight work, > though pwmr was only configurable trough the platform data. > > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: devicetree@vger.kernel.org > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: linux-arm-kernel@lists.infradead.org > Cc: Eric Bénard <eric@eukrea.com> > Signed-off-by: Denis Carikli <denis@eukrea.com> > Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> For binding: Acked-by: Grant Likely <grant.likely@linaro.org> > --- > .../devicetree/bindings/video/fsl,imx-fb.txt | 3 +++ > drivers/video/imxfb.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > index 46da08d..ac457ae 100644 > --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > @@ -17,6 +17,9 @@ Required nodes: > Optional properties: > - fsl,dmacr: DMA Control Register value. This is optional. By default, the > register is not modified as recommended by the datasheet. > +- fsl,pwmr: LCDC PWM Contrast Control Register value. That property is > + optional, but defining it is necessary to get the backlight working. If that > + property is ommited, the register is zeroed. > - fsl,lscr1: LCDC Sharp Configuration Register value. > > Example: > diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c > index 4bf3837..f09372d 100644 > --- a/drivers/video/imxfb.c > +++ b/drivers/video/imxfb.c > @@ -833,6 +833,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) > > of_property_read_u32(np, "fsl,dmacr", &fbi->dmacr); > > + of_property_read_u32(np, "fsl,pwmr", &fbi->pwmr); > + > /* These two function pointers could be used by some specific > * platforms. */ > fbi->lcd_power = NULL; > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv7][ 2/6] video: imxfb: Also add pwmr for the device tree. Date: Thu, 24 Oct 2013 11:13:06 +0100 [thread overview] Message-ID: <20131024101306.C8882C4039D@trevor.secretlab.ca> (raw) In-Reply-To: <1382605103-9595-2-git-send-email-denis@eukrea.com> On Thu, 24 Oct 2013 10:58:19 +0200, Denis Carikli <denis@eukrea.com> wrote: > pwmr has to be set to get the imxfb backlight work, > though pwmr was only configurable trough the platform data. > > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: devicetree at vger.kernel.org > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev at vger.kernel.org > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: linux-arm-kernel at lists.infradead.org > Cc: Eric B??nard <eric@eukrea.com> > Signed-off-by: Denis Carikli <denis@eukrea.com> > Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> For binding: Acked-by: Grant Likely <grant.likely@linaro.org> > --- > .../devicetree/bindings/video/fsl,imx-fb.txt | 3 +++ > drivers/video/imxfb.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > index 46da08d..ac457ae 100644 > --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > @@ -17,6 +17,9 @@ Required nodes: > Optional properties: > - fsl,dmacr: DMA Control Register value. This is optional. By default, the > register is not modified as recommended by the datasheet. > +- fsl,pwmr: LCDC PWM Contrast Control Register value. That property is > + optional, but defining it is necessary to get the backlight working. If that > + property is ommited, the register is zeroed. > - fsl,lscr1: LCDC Sharp Configuration Register value. > > Example: > diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c > index 4bf3837..f09372d 100644 > --- a/drivers/video/imxfb.c > +++ b/drivers/video/imxfb.c > @@ -833,6 +833,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) > > of_property_read_u32(np, "fsl,dmacr", &fbi->dmacr); > > + of_property_read_u32(np, "fsl,pwmr", &fbi->pwmr); > + > /* These two function pointers could be used by some specific > * platforms. */ > fbi->lcd_power = NULL; > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2013-10-24 10:13 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-24 8:58 [PATCHv7][ 1/6] video: imxfb: Introduce regulator support Denis Carikli 2013-10-24 8:58 ` Denis Carikli [not found] ` <1382605103-9595-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org> 2013-10-24 8:58 ` [PATCHv7][ 2/6] video: imxfb: Also add pwmr for the device tree Denis Carikli 2013-10-24 8:58 ` Denis Carikli 2013-10-24 8:58 ` Denis Carikli 2013-10-24 10:13 ` Grant Likely [this message] 2013-10-24 10:13 ` Grant Likely 2013-10-24 8:58 ` [PATCHv7][ 3/6] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver Denis Carikli 2013-10-24 8:58 ` [PATCHv7][ 3/6] ARM: imx{25, 27} " Denis Carikli [not found] ` <1382605103-9595-3-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org> 2013-10-25 1:46 ` [PATCHv7][ 3/6] ARM: imx{25,27} " Shawn Guo 2013-10-25 1:46 ` Shawn Guo [not found] ` <20131025014652.GH14529-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> 2013-10-25 11:03 ` Jean-Christophe PLAGNIOL-VILLARD 2013-10-25 11:03 ` Jean-Christophe PLAGNIOL-VILLARD 2013-10-24 8:58 ` [PATCHv7][ 4/6] pinctrl: pinctrl-imx: add imx25 pinctrl driver Denis Carikli 2013-10-24 8:58 ` Denis Carikli 2013-10-24 10:14 ` Grant Likely 2013-10-24 10:14 ` Grant Likely 2013-10-24 8:58 ` [PATCHv7][ 5/6] ARM: dts: imx25.dtsi: Add some pinmux pins Denis Carikli 2013-10-24 8:58 ` Denis Carikli 2013-10-24 8:58 ` [PATCHv7][ 6/6] ARM: dts: Add support for the cpuimx25 board from Eukrea and its baseboard Denis Carikli 2013-10-24 8:58 ` Denis Carikli 2013-10-25 11:07 ` [PATCHv7][ 1/6] video: imxfb: Introduce regulator support Jean-Christophe PLAGNIOL-VILLARD 2013-10-25 11:07 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20131024101306.C8882C4039D@trevor.secretlab.ca \ --to=grant.likely@secretlab.ca \ --cc=denis@eukrea.com \ --cc=devicetree@vger.kernel.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=plagnioj@jcrosoft.com \ --cc=rob.herring@calxeda.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=shawn.guo@linaro.org \ --cc=swarren@wwwdotorg.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.