From: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
Cc: "Shawn Guo" <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Rob Herring"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Stephen Warren"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCHv11][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver
Date: Tue, 5 Nov 2013 15:56:02 +0100 [thread overview]
Message-ID: <20131105145602.GF15098@pengutronix.de> (raw)
In-Reply-To: <1383662354-22417-4-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
On Tue, Nov 05, 2013 at 03:39:11PM +0100, Denis Carikli wrote:
> This is mostly cut and paste from the imx35 pinctrl driver.
> The data was generated using sed and awk on
> arch/arm/plat-mxc/include/mach/iomux-mx25.h.
>
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Eric Bénard <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
> Acked-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> ChangeLog v9->v10:
> - Added a imx25-pingrp.h header.
> - Removed backslash-newline at end of imx25-pingrp.h
>
> ChangeLog v8->v9:
> - Whitespace cleanup betwen the CC: and Signed-off-by.
> - Kconfig: rebased to make it apply on the new HEAD.
> ---
> .../bindings/pinctrl/fsl,imx25-pinctrl.txt | 25 +
> arch/arm/boot/dts/imx25-pinfunc.h | 494 ++++++++++++++++++++
> arch/arm/boot/dts/imx25-pingrp.h | 79 ++++
> arch/arm/boot/dts/imx25.dtsi | 1 +
> drivers/pinctrl/Kconfig | 9 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-imx25.c | 351 ++++++++++++++
> 7 files changed, 960 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> create mode 100644 arch/arm/boot/dts/imx25-pinfunc.h
> create mode 100644 arch/arm/boot/dts/imx25-pingrp.h
> create mode 100644 drivers/pinctrl/pinctrl-imx25.c
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> new file mode 100644
> index 0000000..1d6dae2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> @@ -0,0 +1,25 @@
> +* Freescale IMX25 IOMUX Controller
> +
> +Please refer to fsl,imx-pinctrl.txt in this directory for common binding part
> +and usage.
> +
> +CONFIG bits definition:
> +PAD_CTL_DRIVE_VOLAGAGE_18 (1 << 13)
> +PAD_CTL_DRIVE_VOLAGAGE_33 (0 << 13)
> +PAD_CTL_HYS (1 << 8)
> +PAD_CTL_PKE (1 << 7)
> +PAD_CTL_PUE (1 << 6)
> +PAD_CTL_PUS_100K_DOWN (0 << 4)
> +PAD_CTL_PUS_47K_UP (1 << 4)
> +PAD_CTL_PUS_100K_UP (2 << 4)
> +PAD_CTL_PUS_22K_UP (3 << 4)
> +PAD_CTL_ODE_CMOS (0 << 3)
> +PAD_CTL_ODE_OPENDRAIN (1 << 3)
> +PAD_CTL_DSE_NOMINAL (0 << 1)
> +PAD_CTL_DSE_HIGH (1 << 1)
> +PAD_CTL_DSE_MAX (2 << 1)
> +PAD_CTL_SRE_FAST (1 << 0)
> +PAD_CTL_SRE_SLOW (0 << 0)
You removed the group control registers in v11? Are these config bits
used for other pinctl registers? Especially "DRIVE_VOLTAGE" seems to be
only for those registers you removed.
Regards
Markus Pargmann
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv11][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver
Date: Tue, 5 Nov 2013 15:56:02 +0100 [thread overview]
Message-ID: <20131105145602.GF15098@pengutronix.de> (raw)
In-Reply-To: <1383662354-22417-4-git-send-email-denis@eukrea.com>
On Tue, Nov 05, 2013 at 03:39:11PM +0100, Denis Carikli wrote:
> This is mostly cut and paste from the imx35 pinctrl driver.
> The data was generated using sed and awk on
> arch/arm/plat-mxc/include/mach/iomux-mx25.h.
>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: devicetree at vger.kernel.org
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Eric B?nard <eric@eukrea.com>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> ChangeLog v9->v10:
> - Added a imx25-pingrp.h header.
> - Removed backslash-newline at end of imx25-pingrp.h
>
> ChangeLog v8->v9:
> - Whitespace cleanup betwen the CC: and Signed-off-by.
> - Kconfig: rebased to make it apply on the new HEAD.
> ---
> .../bindings/pinctrl/fsl,imx25-pinctrl.txt | 25 +
> arch/arm/boot/dts/imx25-pinfunc.h | 494 ++++++++++++++++++++
> arch/arm/boot/dts/imx25-pingrp.h | 79 ++++
> arch/arm/boot/dts/imx25.dtsi | 1 +
> drivers/pinctrl/Kconfig | 9 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-imx25.c | 351 ++++++++++++++
> 7 files changed, 960 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> create mode 100644 arch/arm/boot/dts/imx25-pinfunc.h
> create mode 100644 arch/arm/boot/dts/imx25-pingrp.h
> create mode 100644 drivers/pinctrl/pinctrl-imx25.c
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> new file mode 100644
> index 0000000..1d6dae2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt
> @@ -0,0 +1,25 @@
> +* Freescale IMX25 IOMUX Controller
> +
> +Please refer to fsl,imx-pinctrl.txt in this directory for common binding part
> +and usage.
> +
> +CONFIG bits definition:
> +PAD_CTL_DRIVE_VOLAGAGE_18 (1 << 13)
> +PAD_CTL_DRIVE_VOLAGAGE_33 (0 << 13)
> +PAD_CTL_HYS (1 << 8)
> +PAD_CTL_PKE (1 << 7)
> +PAD_CTL_PUE (1 << 6)
> +PAD_CTL_PUS_100K_DOWN (0 << 4)
> +PAD_CTL_PUS_47K_UP (1 << 4)
> +PAD_CTL_PUS_100K_UP (2 << 4)
> +PAD_CTL_PUS_22K_UP (3 << 4)
> +PAD_CTL_ODE_CMOS (0 << 3)
> +PAD_CTL_ODE_OPENDRAIN (1 << 3)
> +PAD_CTL_DSE_NOMINAL (0 << 1)
> +PAD_CTL_DSE_HIGH (1 << 1)
> +PAD_CTL_DSE_MAX (2 << 1)
> +PAD_CTL_SRE_FAST (1 << 0)
> +PAD_CTL_SRE_SLOW (0 << 0)
You removed the group control registers in v11? Are these config bits
used for other pinctl registers? Especially "DRIVE_VOLTAGE" seems to be
only for those registers you removed.
Regards
Markus Pargmann
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-11-05 14:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 14:39 [PATCHv11][ 1/7] video: imxfb: Introduce regulator support Denis Carikli
2013-11-05 14:39 ` Denis Carikli
[not found] ` <1383662354-22417-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-11-05 14:39 ` [PATCHv11][ 2/7] video: imxfb: Also add pwmr for the device tree Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` [PATCHv11][ 3/7] video: Kconfig: Allow more broad selection of the imxfb framebuffer driver Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` [PATCHv11][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver Denis Carikli
2013-11-05 14:39 ` Denis Carikli
[not found] ` <1383662354-22417-4-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-11-05 14:56 ` Markus Pargmann [this message]
2013-11-05 14:56 ` Markus Pargmann
2013-11-05 14:39 ` [PATCHv11][ 5/7] ARM: dts: imx25.dtsi: Permit to use the iomuxc in the dts Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` [PATCHv11][ 6/7] ARM i.MX25: build in pinctrl support Denis Carikli
2013-11-05 14:39 ` Denis Carikli
2013-11-05 14:39 ` [PATCHv11][ 7/7] ARM: dts: Add support for the cpuimx25 board from Eukrea and its baseboard Denis Carikli
2013-11-05 14:39 ` Denis Carikli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105145602.GF15098@pengutronix.de \
--to=mpa-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.