From: Will Deacon <will.deacon@arm.com>
To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised
Date: Fri, 29 Nov 2013 14:41:57 +0000 [thread overview]
Message-ID: <20131129144157.GD31000@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1385729844.1871.24.camel@smile>
On Fri, Nov 29, 2013 at 12:57:50PM +0000, Shevchenko, Andriy wrote:
> On Fri, 2013-11-29 at 11:50 +0000, Will Deacon wrote:
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index 98641eaca080..79e52a94f054 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -2492,14 +2492,8 @@ static dma_cookie_t pl330_tx_submit(struct dma_async_tx_descriptor *tx)
> >
> > static inline void _init_desc(struct dma_pl330_desc *desc)
> > {
> > - desc->pchan = NULL;
> > desc->req.x = &desc->px;
> > desc->req.token = desc;
> > - desc->rqcfg.swap = SWAP_NO;
> > - desc->rqcfg.privileged = 0;
> > - desc->rqcfg.insnaccess = 0;
> > - desc->rqcfg.scctl = SCCTRL0;
> > - desc->rqcfg.dcctl = DCCTRL0;
> > desc->req.cfg = &desc->rqcfg;
> > desc->req.xfer_cb = dma_pl330_rqcb;
> > desc->txd.tx_submit = pl330_tx_submit;
> > @@ -2517,7 +2511,7 @@ static int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
> > if (!pdmac)
> > return 0;
> >
> > - desc = kmalloc(count * sizeof(*desc), flg);
> > + desc = kzalloc(count * sizeof(*desc), flg);
>
> Maybe kcalloc() ?
Yup, that could work. I'll include that in v2 pending any other comments.
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised
Date: Fri, 29 Nov 2013 14:41:57 +0000 [thread overview]
Message-ID: <20131129144157.GD31000@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1385729844.1871.24.camel@smile>
On Fri, Nov 29, 2013 at 12:57:50PM +0000, Shevchenko, Andriy wrote:
> On Fri, 2013-11-29 at 11:50 +0000, Will Deacon wrote:
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index 98641eaca080..79e52a94f054 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -2492,14 +2492,8 @@ static dma_cookie_t pl330_tx_submit(struct dma_async_tx_descriptor *tx)
> >
> > static inline void _init_desc(struct dma_pl330_desc *desc)
> > {
> > - desc->pchan = NULL;
> > desc->req.x = &desc->px;
> > desc->req.token = desc;
> > - desc->rqcfg.swap = SWAP_NO;
> > - desc->rqcfg.privileged = 0;
> > - desc->rqcfg.insnaccess = 0;
> > - desc->rqcfg.scctl = SCCTRL0;
> > - desc->rqcfg.dcctl = DCCTRL0;
> > desc->req.cfg = &desc->rqcfg;
> > desc->req.xfer_cb = dma_pl330_rqcb;
> > desc->txd.tx_submit = pl330_tx_submit;
> > @@ -2517,7 +2511,7 @@ static int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
> > if (!pdmac)
> > return 0;
> >
> > - desc = kmalloc(count * sizeof(*desc), flg);
> > + desc = kzalloc(count * sizeof(*desc), flg);
>
> Maybe kcalloc() ?
Yup, that could work. I'll include that in v2 pending any other comments.
Cheers,
Will
next prev parent reply other threads:[~2013-11-29 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 11:50 [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised Will Deacon
2013-11-29 11:50 ` Will Deacon
2013-11-29 12:57 ` Shevchenko, Andriy
2013-11-29 12:57 ` Shevchenko, Andriy
2013-11-29 14:41 ` Will Deacon [this message]
2013-11-29 14:41 ` Will Deacon
2013-11-29 15:18 ` Jassi Brar
2013-11-29 15:18 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129144157.GD31000@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=andriy.shevchenko@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.