From: Stephen Boyd <sboyd@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Brown <davidb@codeaurora.org>,
arm@kernel.org, Rohit Vaswani <rvaswani@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: msm: Add support for APQ8074 Dragonboard
Date: Fri, 20 Dec 2013 22:21:50 -0800 [thread overview]
Message-ID: <20131221062150.GE31766@codeaurora.org> (raw)
In-Reply-To: <201312202134.42027.arnd@arndb.de>
On 12/20, Arnd Bergmann wrote:
> On Friday 20 December 2013, David Brown wrote:
> > diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c
> > index 16e6183..1f11d93 100644
> > --- a/arch/arm/mach-msm/board-dt.c
> > +++ b/arch/arm/mach-msm/board-dt.c
> > @@ -26,7 +26,16 @@ static const char * const msm_dt_match[] __initconst = {
> > NULL
> > };
> >
> > +static const char * const apq8074_dt_match[] __initconst = {
> > + "qcom,apq8074-dragonboard",
> > + NULL
> > +};
> > +
> > DT_MACHINE_START(MSM_DT, "Qualcomm MSM (Flattened Device Tree)")
> > .smp = smp_ops(msm_smp_ops),
> > .dt_compat = msm_dt_match,
> > MACHINE_END
> > +
> > +DT_MACHINE_START(APQ_DT, "Qualcomm MSM (Flattened Device Tree)")
> > + .dt_compat = apq8074_dt_match,
> > +MACHINE_END
> > --
>
> Why can't you reuse the MSM_DT definition and just add the dragonboard
> to the list of compatible machines? The presence of the smp_ops pointer
> should not matter if you don't support SMP.
>
If the smp_ops are present we'll try to boot the secondary CPUs
with the Scorpion boot sequence instead of the Krait boot
sequence. This will quickly hang the system. We can properly
handle this with my SMP patches[1]. In fact, we can delete this
entire file if those patches are accepted. Please take a look.
I'll Cc you on them when I resend.
[1] https://lkml.org/lkml/2013/11/1/622
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: msm: Add support for APQ8074 Dragonboard
Date: Fri, 20 Dec 2013 22:21:50 -0800 [thread overview]
Message-ID: <20131221062150.GE31766@codeaurora.org> (raw)
In-Reply-To: <201312202134.42027.arnd@arndb.de>
On 12/20, Arnd Bergmann wrote:
> On Friday 20 December 2013, David Brown wrote:
> > diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c
> > index 16e6183..1f11d93 100644
> > --- a/arch/arm/mach-msm/board-dt.c
> > +++ b/arch/arm/mach-msm/board-dt.c
> > @@ -26,7 +26,16 @@ static const char * const msm_dt_match[] __initconst = {
> > NULL
> > };
> >
> > +static const char * const apq8074_dt_match[] __initconst = {
> > + "qcom,apq8074-dragonboard",
> > + NULL
> > +};
> > +
> > DT_MACHINE_START(MSM_DT, "Qualcomm MSM (Flattened Device Tree)")
> > .smp = smp_ops(msm_smp_ops),
> > .dt_compat = msm_dt_match,
> > MACHINE_END
> > +
> > +DT_MACHINE_START(APQ_DT, "Qualcomm MSM (Flattened Device Tree)")
> > + .dt_compat = apq8074_dt_match,
> > +MACHINE_END
> > --
>
> Why can't you reuse the MSM_DT definition and just add the dragonboard
> to the list of compatible machines? The presence of the smp_ops pointer
> should not matter if you don't support SMP.
>
If the smp_ops are present we'll try to boot the secondary CPUs
with the Scorpion boot sequence instead of the Krait boot
sequence. This will quickly hang the system. We can properly
handle this with my SMP patches[1]. In fact, we can delete this
entire file if those patches are accepted. Please take a look.
I'll Cc you on them when I resend.
[1] https://lkml.org/lkml/2013/11/1/622
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-12-21 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 19:09 [PATCH 0/7] MSM patches for 3.14 David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 1/7] ARM: msm: trout: fix uninit var warning David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 2/7] ARM: msm: Add support for APQ8074 Dragonboard David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 20:34 ` Arnd Bergmann
2013-12-20 20:34 ` Arnd Bergmann
2013-12-21 6:21 ` Stephen Boyd [this message]
2013-12-21 6:21 ` Stephen Boyd
2013-12-20 19:09 ` [PATCH 3/7] defconfig: msm_defconfig: Enable CONFIG_ARCH_MSM8974 David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 4/7] ARM: msm: Simplify ARCH_MSM_DT config David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 5/7] ARM: dts: MSM8974: Add restart node David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 6/7] ARM: dts: MSM8974: Add MMIO architected timer node David Brown
2013-12-20 19:09 ` David Brown
2013-12-20 19:09 ` [PATCH 7/7] ARM: msm_defconfig: Enable restart driver David Brown
2013-12-20 19:09 ` David Brown
2014-01-02 18:31 ` [PATCH 0/7] MSM patches for 3.14 Olof Johansson
2014-01-02 18:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221062150.GE31766@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.