From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers
Date: Sat, 28 Dec 2013 14:52:09 +0000 [thread overview]
Message-ID: <20131228145209.GF31886@sirena.org.uk> (raw)
In-Reply-To: <20131226194133.GJ31766@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
On Thu, Dec 26, 2013 at 11:41:33AM -0800, Stephen Boyd wrote:
> On 12/24, Mark Brown wrote:
> > Not a big deal but could these just be inlined in the headers?
> Sure, I can do that if I need to resend? The only benefit I see
> is two less symbols exported.
It also means that everything will be marginally faster since there
will be one less level of function call but yeah, there's little
practical benefit - it's a stylistic thing rather than a practical one.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers
Date: Sat, 28 Dec 2013 14:52:09 +0000 [thread overview]
Message-ID: <20131228145209.GF31886@sirena.org.uk> (raw)
In-Reply-To: <20131226194133.GJ31766@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Thu, Dec 26, 2013 at 11:41:33AM -0800, Stephen Boyd wrote:
> On 12/24, Mark Brown wrote:
> > Not a big deal but could these just be inlined in the headers?
> Sure, I can do that if I need to resend? The only benefit I see
> is two less symbols exported.
It also means that everything will be marginally faster since there
will be one less level of function call but yeah, there's little
practical benefit - it's a stylistic thing rather than a practical one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers
Date: Sat, 28 Dec 2013 14:52:09 +0000 [thread overview]
Message-ID: <20131228145209.GF31886@sirena.org.uk> (raw)
In-Reply-To: <20131226194133.GJ31766@codeaurora.org>
On Thu, Dec 26, 2013 at 11:41:33AM -0800, Stephen Boyd wrote:
> On 12/24, Mark Brown wrote:
> > Not a big deal but could these just be inlined in the headers?
> Sure, I can do that if I need to resend? The only benefit I see
> is two less symbols exported.
It also means that everything will be marginally faster since there
will be one less level of function call but yeah, there's little
practical benefit - it's a stylistic thing rather than a practical one.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131228/a41149d2/attachment.sig>
next prev parent reply other threads:[~2013-12-28 14:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 20:45 [PATCH v2 0/7] Modernize pm8921 with irqdomains, regmap, DT Stephen Boyd
2013-12-23 20:45 ` Stephen Boyd
2013-12-23 20:45 ` Stephen Boyd
2013-12-23 20:45 ` [PATCH v2 1/7] mfd: Move pm8xxx-irq.c contents into only driver that uses it Stephen Boyd
2013-12-23 20:45 ` Stephen Boyd
2014-01-06 14:47 ` Lee Jones
2014-01-06 14:47 ` Lee Jones
2013-12-23 20:45 ` [PATCH v2 2/7] mfd: pm8921: Update for genirq changes Stephen Boyd
2013-12-23 20:45 ` Stephen Boyd
2013-12-23 20:45 ` [PATCH v2 3/7] mfd: pm8921: Migrate to irqdomains Stephen Boyd
2013-12-23 20:45 ` Stephen Boyd
2014-01-06 15:53 ` Lee Jones
2014-01-06 15:53 ` Lee Jones
2014-01-06 20:33 ` Stephen Boyd
2014-01-06 20:33 ` Stephen Boyd
2014-01-07 8:22 ` Lee Jones
2014-01-07 8:22 ` Lee Jones
2014-01-07 19:54 ` Stephen Boyd
2014-01-07 19:54 ` Stephen Boyd
2014-01-08 8:14 ` Lee Jones
2014-01-08 8:14 ` Lee Jones
2013-12-23 20:46 ` [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers Stephen Boyd
2013-12-23 20:46 ` Stephen Boyd
2013-12-24 12:54 ` Mark Brown
2013-12-24 12:54 ` Mark Brown
2013-12-26 19:41 ` Stephen Boyd
2013-12-26 19:41 ` Stephen Boyd
2013-12-28 14:52 ` Mark Brown [this message]
2013-12-28 14:52 ` Mark Brown
2013-12-28 14:52 ` Mark Brown
2014-01-06 11:50 ` Lee Jones
2014-01-06 11:50 ` Lee Jones
2014-01-06 22:26 ` Stephen Boyd
2014-01-06 22:26 ` Stephen Boyd
2013-12-23 20:46 ` [PATCH v2 5/7] mfd: pm8921: Use ssbi regmap Stephen Boyd
2013-12-23 20:46 ` Stephen Boyd
2013-12-30 12:34 ` Mark Brown
2013-12-30 12:34 ` Mark Brown
2013-12-23 20:46 ` [PATCH v2 6/7] mfd: pm8921: Add DT match table Stephen Boyd
2013-12-23 20:46 ` Stephen Boyd
2014-01-06 11:52 ` Lee Jones
2014-01-06 11:52 ` Lee Jones
2014-01-06 18:03 ` Stephen Boyd
2014-01-06 18:03 ` Stephen Boyd
[not found] ` <1387831563-13535-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-12-23 20:46 ` [PATCH v2 7/7] devicetree: bindings: Document PM8921/8058 PMICs Stephen Boyd
2013-12-23 20:46 ` Stephen Boyd
2013-12-23 20:46 ` Stephen Boyd
2014-01-06 11:53 ` Lee Jones
2014-01-06 11:53 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228145209.GF31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.