From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs
Date: Thu, 2 Jan 2014 11:17:57 -0800 [thread overview]
Message-ID: <20140102191757.GA2025@core.coreip.homeip.net> (raw)
In-Reply-To: <20140102184959.GI31886@sirena.org.uk>
On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote:
> On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:
> > On Tue, Dec 10, 2013 at 03:43:11PM -0800, Stephen Boyd wrote:
>
> > > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > > + if (!regmap)
> > > + return -ENODEV;
>
> > And you are leaking memory here...
>
> He's not, dev_get_regmap() just gets a pointer to an existing regmap -
> no reference is taken and nothing is allocated. It's a helper that's
> mainly there so that generic code can be written without needing the
> regmap to be passed around. The caller is responsible for ensuring that
> it will stick around for as long as it's used (generally by having it
> lifetime managed with the device).
I was not talking about data returned by dev_get_regmap() but all other
memory that was allocated before as this was pre devm conversion of the
driver.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs
Date: Thu, 2 Jan 2014 11:17:57 -0800 [thread overview]
Message-ID: <20140102191757.GA2025@core.coreip.homeip.net> (raw)
In-Reply-To: <20140102184959.GI31886@sirena.org.uk>
On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote:
> On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:
> > On Tue, Dec 10, 2013 at 03:43:11PM -0800, Stephen Boyd wrote:
>
> > > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > > + if (!regmap)
> > > + return -ENODEV;
>
> > And you are leaking memory here...
>
> He's not, dev_get_regmap() just gets a pointer to an existing regmap -
> no reference is taken and nothing is allocated. It's a helper that's
> mainly there so that generic code can be written without needing the
> regmap to be passed around. The caller is responsible for ensuring that
> it will stick around for as long as it's used (generally by having it
> lifetime managed with the device).
I was not talking about data returned by dev_get_regmap() but all other
memory that was allocated before as this was pre devm conversion of the
driver.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs
Date: Thu, 2 Jan 2014 11:17:57 -0800 [thread overview]
Message-ID: <20140102191757.GA2025@core.coreip.homeip.net> (raw)
In-Reply-To: <20140102184959.GI31886@sirena.org.uk>
On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote:
> On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:
> > On Tue, Dec 10, 2013 at 03:43:11PM -0800, Stephen Boyd wrote:
>
> > > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > > + if (!regmap)
> > > + return -ENODEV;
>
> > And you are leaking memory here...
>
> He's not, dev_get_regmap() just gets a pointer to an existing regmap -
> no reference is taken and nothing is allocated. It's a helper that's
> mainly there so that generic code can be written without needing the
> regmap to be passed around. The caller is responsible for ensuring that
> it will stick around for as long as it's used (generally by having it
> lifetime managed with the device).
I was not talking about data returned by dev_get_regmap() but all other
memory that was allocated before as this was pre devm conversion of the
driver.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-01-02 19:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 23:43 [PATCH 0/7] Use regmap+devm in pm8xxx input drivers Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-10 23:43 ` [PATCH 1/7] Input: pmic8xxx-pwrkey - Pass input device directly to interrupt Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-15 11:21 ` Dmitry Torokhov
2013-12-15 11:21 ` Dmitry Torokhov
2013-12-16 19:59 ` Stephen Boyd
2013-12-16 19:59 ` Stephen Boyd
2013-12-10 23:43 ` [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-15 11:33 ` Dmitry Torokhov
2013-12-15 11:33 ` Dmitry Torokhov
2014-01-02 18:49 ` Mark Brown
2014-01-02 18:49 ` Mark Brown
2014-01-02 19:17 ` Dmitry Torokhov [this message]
2014-01-02 19:17 ` Dmitry Torokhov
2014-01-02 19:17 ` Dmitry Torokhov
2014-01-03 0:50 ` Mark Brown
2014-01-03 0:50 ` Mark Brown
2014-01-21 9:34 ` bug fix for mmc queue.c Wang, Yalin
2014-01-21 9:34 ` Wang, Yalin
2013-12-10 23:43 ` [PATCH 3/7] Input: pm8xxx-vibrator - Migrate to devm_* APIs Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-10 23:43 ` [PATCH 4/7] Input: pm8xxx-vibrator - Migrate to regmap APIs Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-10 23:43 ` [PATCH 5/7] genirq: Add devm_request_any_context_irq() Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-15 10:42 ` Dmitry Torokhov
2013-12-15 10:42 ` Dmitry Torokhov
2013-12-10 23:43 ` [PATCH 6/7] Input: pmic8xxx-keypad - Migrate to devm_* APIs Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
2013-12-16 15:37 ` Dmitry Torokhov
2013-12-16 15:37 ` Dmitry Torokhov
2013-12-17 2:01 ` spamassassin system account
2013-12-17 2:01 ` spamassassin system account
2013-12-10 23:43 ` [PATCH 7/7] Input: pmic8xxx-keypad - Migrate to regmap APIs Stephen Boyd
2013-12-10 23:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102191757.GA2025@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.