From: Dave Chinner <david@fromorbit.com>
To: Koen De Wit <koen.de.wit@oracle.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks
Date: Tue, 11 Feb 2014 09:04:00 +1100 [thread overview]
Message-ID: <20140210220400.GV13647@dastard> (raw)
In-Reply-To: <1392068362-14049-1-git-send-email-koen.de.wit@oracle.com>
On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:
> Tests Btrfs filesystems with all possible metadata block sizes, by
> setting large extended attributes on files.
>
> Signed-off-by: Koen De Wit <koen.de.wit@oracle.com>
....
> +
> +_test_illegal_leafsize() {
> + _scratch_mkfs -l $1 >>$seqres.full 2>&1
> + [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
> + "leafsize option, mkfs should have failed."
> +}
You just re-implemented run_check....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Koen De Wit <koen.de.wit@oracle.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks
Date: Tue, 11 Feb 2014 09:04:00 +1100 [thread overview]
Message-ID: <20140210220400.GV13647@dastard> (raw)
In-Reply-To: <1392068362-14049-1-git-send-email-koen.de.wit@oracle.com>
On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:
> Tests Btrfs filesystems with all possible metadata block sizes, by
> setting large extended attributes on files.
>
> Signed-off-by: Koen De Wit <koen.de.wit@oracle.com>
....
> +
> +_test_illegal_leafsize() {
> + _scratch_mkfs -l $1 >>$seqres.full 2>&1
> + [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
> + "leafsize option, mkfs should have failed."
> +}
You just re-implemented run_check....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-10 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 21:39 [PATCH v3] xfstests: Btrfs: add test for large metadata blocks Koen De Wit
2014-02-10 21:39 ` Koen De Wit
2014-02-10 22:04 ` Dave Chinner [this message]
2014-02-10 22:04 ` Dave Chinner
2014-02-11 19:01 ` Koen De Wit
2014-02-17 1:57 ` Dave Chinner
2014-02-17 1:57 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210220400.GV13647@dastard \
--to=david@fromorbit.com \
--cc=koen.de.wit@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.