Re: [PATCH 1/1] mxc_nand : allow swapping the Bad block Indicator for NFC v1.

From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Gaëtan Carlier" <gcembed@gmail.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	J.Lambrecht@televic.com, Juergen Beisert <jbe@pengutronix.de>,
	linux-mtd@lists.infradead.org,
	Sascha Hauer <kernel@pengutronix.de>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] mxc_nand : allow swapping the Bad block Indicator for NFC v1.
Date: Fri, 28 Mar 2014 10:11:42 +0100	[thread overview]
Message-ID: <20140328091142.GE17250@pengutronix.de> (raw)
In-Reply-To: <5332DBDD.4090802@gmail.com>

On Wed, Mar 26, 2014 at 02:53:33PM +0100, Gaëtan Carlier wrote:
> Hi,
> I don't see where the problem is. The fact that bad block marker are
> used or not, is not related to "my" patch. This patch just places
> data where they should be. If I take the Nand and connect it to a
> not-bugged NFC controller, all data will be read correctly with data
> is main area and OOB is spare area.
> >
> >In this form the patch is simply not correct and should be dropped.
> >
> Now I want to adapt and publish my platform file to latest kernel
> version and I am still stopped with this biswap patch that is not
> applied. As I said before, I must not be the only that have used
> this damned original patch from Freescale that swaps byte in their
> ATK programming soft, redboot and Kernel and it is impossible to
> fallback to current NAND handling (without swapping).
> 
> Is there any chance that if I send this patch against
> linux-next/master branch, it will be finally accepted. Only people
> that needs it will use it. There is so much option in menuconfig
> with so little explaination and mark as "Only say Yes if you known
> what you do".

I'm ok with supporting a devicetree option that decides whether to do
bad block marker swapping or not. It shouldn't be a Kconfig option.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |