From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC 1/5] PCI: tegra: Overhaul regulator usage
Date: Tue, 8 Apr 2014 21:52:41 +0200 [thread overview]
Message-ID: <20140408195240.GA21978@ulmo.nvidia.com> (raw)
In-Reply-To: <53444AE3.6030603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Tue, Apr 08, 2014 at 09:15:47PM +0200, Stephen Warren wrote:
> On 04/04/2014 08:49 AM, Thierry Reding wrote:
> > The current usage of regulators for the Tegra PCIe block is wrong. It
> > doesn't accurately reflect the actual supply inputs of the IP block and
> > therefore isn't as flexible as it should be. Rectify this by describing
> > all possible supply inputs in the device tree binding documentation and
> > deprecate the old supply properties.
>
> > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
>
> > +Power supplies for Tegra30:
> ...
> > +- Optional:
> > + - If port 0 is enabled:
> > + - avdd-pexa-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexa-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> > + - If at least one of ports 1 and 2 is enabled:
> > + - avdd-pexb-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexb-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
>
> Did you get confirmation from HW/... that the mapping from pexa/b to
> PCIe ports you document above is correct? IIRC the two supplies might be
> related to lanes rather than ports?
Not yet, which is the primary reason this is still RFC. Just wanted to
get early feedback on the general direction of the series.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [RFC 1/5] PCI: tegra: Overhaul regulator usage
Date: Tue, 8 Apr 2014 21:52:41 +0200 [thread overview]
Message-ID: <20140408195240.GA21978@ulmo.nvidia.com> (raw)
In-Reply-To: <53444AE3.6030603@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Tue, Apr 08, 2014 at 09:15:47PM +0200, Stephen Warren wrote:
> On 04/04/2014 08:49 AM, Thierry Reding wrote:
> > The current usage of regulators for the Tegra PCIe block is wrong. It
> > doesn't accurately reflect the actual supply inputs of the IP block and
> > therefore isn't as flexible as it should be. Rectify this by describing
> > all possible supply inputs in the device tree binding documentation and
> > deprecate the old supply properties.
>
> > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
>
> > +Power supplies for Tegra30:
> ...
> > +- Optional:
> > + - If port 0 is enabled:
> > + - avdd-pexa-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexa-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> > + - If at least one of ports 1 and 2 is enabled:
> > + - avdd-pexb-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexb-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
>
> Did you get confirmation from HW/... that the mapping from pexa/b to
> PCIe ports you document above is correct? IIRC the two supplies might be
> related to lanes rather than ports?
Not yet, which is the primary reason this is still RFC. Just wanted to
get early feedback on the general direction of the series.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: treding@nvidia.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/5] PCI: tegra: Overhaul regulator usage
Date: Tue, 8 Apr 2014 21:52:41 +0200 [thread overview]
Message-ID: <20140408195240.GA21978@ulmo.nvidia.com> (raw)
In-Reply-To: <53444AE3.6030603@wwwdotorg.org>
On Tue, Apr 08, 2014 at 09:15:47PM +0200, Stephen Warren wrote:
> On 04/04/2014 08:49 AM, Thierry Reding wrote:
> > The current usage of regulators for the Tegra PCIe block is wrong. It
> > doesn't accurately reflect the actual supply inputs of the IP block and
> > therefore isn't as flexible as it should be. Rectify this by describing
> > all possible supply inputs in the device tree binding documentation and
> > deprecate the old supply properties.
>
> > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
>
> > +Power supplies for Tegra30:
> ...
> > +- Optional:
> > + - If port 0 is enabled:
> > + - avdd-pexa-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexa-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> > + - If at least one of ports 1 and 2 is enabled:
> > + - avdd-pexb-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> > + - vdd-pexb-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
>
> Did you get confirmation from HW/... that the mapping from pexa/b to
> PCIe ports you document above is correct? IIRC the two supplies might be
> related to lanes rather than ports?
Not yet, which is the primary reason this is still RFC. Just wanted to
get early feedback on the general direction of the series.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140408/03e93392/attachment-0001.sig>
next prev parent reply other threads:[~2014-04-08 19:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:49 [RFC 0/5] PCI: tegra: Overhaul regulator usage Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
[not found] ` <1396622969-17837-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-04 14:49 ` [RFC 1/5] " Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-08 19:15 ` Stephen Warren
2014-04-08 19:15 ` Stephen Warren
[not found] ` <53444AE3.6030603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-08 19:52 ` Thierry Reding [this message]
2014-04-08 19:52 ` Thierry Reding
2014-04-08 19:52 ` Thierry Reding
2014-04-04 14:49 ` [RFC 2/5] ARM: tegra: Add new PCIe regulator properties Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
[not found] ` <1396622969-17837-3-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-08 19:17 ` Stephen Warren
2014-04-08 19:17 ` Stephen Warren
2014-04-08 19:17 ` Stephen Warren
2014-04-08 19:54 ` Thierry Reding
2014-04-08 19:54 ` Thierry Reding
2014-04-04 14:49 ` [RFC 3/5] PCI: tegra: Implement accurate power supply scheme Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-08 19:20 ` Stephen Warren
2014-04-08 19:20 ` Stephen Warren
2014-04-08 19:55 ` Thierry Reding
2014-04-08 19:55 ` Thierry Reding
2014-04-04 14:49 ` [RFC 4/5] PCI: tegra: Remove deprecated power supply properties Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` [RFC 5/5] ARM: tegra: Remove legacy PCIe " Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-04 14:49 ` Thierry Reding
2014-04-08 19:21 ` [RFC 0/5] PCI: tegra: Overhaul regulator usage Stephen Warren
2014-04-08 19:21 ` Stephen Warren
2014-04-08 19:21 ` Stephen Warren
2014-04-25 16:57 ` Bjorn Helgaas
2014-04-25 16:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408195240.GA21978@ulmo.nvidia.com \
--to=treding-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.