From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
t.figa@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, arm@kernel.org
Subject: Re: [PATCH 2/4] ARM: S3C24XX: trim down debug uart handling
Date: Thu, 24 Apr 2014 11:34:55 +0100 [thread overview]
Message-ID: <20140424103455.GJ26756@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1410234.AYxfyBcLWB@phil>
On Thu, Apr 24, 2014 at 12:24:31PM +0200, Heiko Stübner wrote:
> +choice
> + prompt "S3C24XX low-level debugging port type"
> + depends on DEBUG_LL && ARCH_S3C24XX
> +
> + config DEBUG_S3C24XX_UART_S3C2440
> + bool "S3C2440 uart type"
> + help
> + Select this if you're debugging S3C2416, S3C2440, S3C2442,
> + S3C2443 or S3C2450 SoCs.
> +
> + config DEBUG_S3C24XX_UART_S3C2410
> + bool "S3C2410 uart type"
> + help
> + Select this if you're debugging S3C2410 or S3C2412 SoCs.
> +endchoice
Why does this need to be a separate choice statement? What's special
about S3C24XX? Is there something wrong with the main choice statement
just above this where everyone else lists their debugging UART?
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: S3C24XX: trim down debug uart handling
Date: Thu, 24 Apr 2014 11:34:55 +0100 [thread overview]
Message-ID: <20140424103455.GJ26756@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1410234.AYxfyBcLWB@phil>
On Thu, Apr 24, 2014 at 12:24:31PM +0200, Heiko St?bner wrote:
> +choice
> + prompt "S3C24XX low-level debugging port type"
> + depends on DEBUG_LL && ARCH_S3C24XX
> +
> + config DEBUG_S3C24XX_UART_S3C2440
> + bool "S3C2440 uart type"
> + help
> + Select this if you're debugging S3C2416, S3C2440, S3C2442,
> + S3C2443 or S3C2450 SoCs.
> +
> + config DEBUG_S3C24XX_UART_S3C2410
> + bool "S3C2410 uart type"
> + help
> + Select this if you're debugging S3C2410 or S3C2412 SoCs.
> +endchoice
Why does this need to be a separate choice statement? What's special
about S3C24XX? Is there something wrong with the main choice statement
just above this where everyone else lists their debugging UART?
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-04-24 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:23 [PATCH 0/4] ARM: S3C24XX: cleanup debug macro/earlyprintk Heiko Stübner
2014-04-24 10:23 ` Heiko Stübner
2014-04-24 10:24 ` [PATCH 1/4] ARM: compressed/head.S: remove s3c24xx special case Heiko Stübner
2014-04-24 10:24 ` Heiko Stübner
2014-04-24 10:24 ` [PATCH 2/4] ARM: S3C24XX: trim down debug uart handling Heiko Stübner
2014-04-24 10:24 ` Heiko Stübner
2014-04-24 10:34 ` Russell King - ARM Linux [this message]
2014-04-24 10:34 ` Russell King - ARM Linux
2014-04-24 10:48 ` Heiko Stübner
2014-04-24 10:48 ` Heiko Stübner
2014-04-24 10:25 ` [PATCH 3/4] ARM: S3C24XX: use generic DEBUG_UART_PHY/_VIRT in debug macro Heiko Stübner
2014-04-24 10:25 ` Heiko Stübner
2014-04-24 10:25 ` [PATCH 4/4] ARM: S3C24XX: move debug-macro.S into the common space Heiko Stübner
2014-04-24 10:25 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424103455.GJ26756@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arm@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.