Re: [PATCH V4 3/6] drm/i915:Initialize the second BSD ring on BDW GT3 machine

From: Daniel Vetter <daniel@ffwll.ch>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V4 3/6] drm/i915:Initialize the second BSD ring on BDW GT3 machine
Date: Thu, 24 Apr 2014 17:21:46 +0200	[thread overview]
Message-ID: <20140424152146.GF26374@phenom.ffwll.local> (raw)
In-Reply-To: <1397702260-2309-4-git-send-email-yakui.zhao@intel.com>

On Thu, Apr 17, 2014 at 10:37:37AM +0800, Zhao Yakui wrote:
> Based on the hardware spec, the BDW GT3 machine has two independent
> BSD ring that can be used to dispatch the video commands.
> So just initialize it.
> 
> V3->V4: Follow Imre's comment to do some minor updates. For example:
> more comments are added to describe the semaphore between ring.
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
[snip]

> +/**
> + * Initialize the second BSD ring for Broadwell GT3.
> + * It is noted that this only exists on Broadwell GT3.
> + */
> +int intel_init_bsd2_ring_buffer(struct drm_device *dev)
> +{
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct intel_ring_buffer *ring = &dev_priv->ring[VCS2];
> +
> +	if ((INTEL_INFO(dev)->gen != 8) ) {

Checkpatch complained about the space here, I've fixed it up quickly.
Running checkpatch before submitting patches is highly recommended so that
we all nicely follow the official linux kernel Coding Style.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch