Re: [PATCH V4 0/6] drm/i915: Add the support of dual BSD rings on BDW GT3

From: Daniel Vetter <daniel@ffwll.ch>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V4 0/6] drm/i915: Add the support of dual BSD rings on BDW GT3
Date: Thu, 24 Apr 2014 17:22:53 +0200	[thread overview]
Message-ID: <20140424152253.GG26374@phenom.ffwll.local> (raw)
In-Reply-To: <1397702260-2309-1-git-send-email-yakui.zhao@intel.com>

On Thu, Apr 17, 2014 at 10:37:34AM +0800, Zhao Yakui wrote:
> This is the patch set that tries to add the support of dual BSD rings on BDW
> GT3. Based on hardware spec, the BDW GT3 has two independent BSD rings, which
> can be used to process the video commands. To be simpler, it is transparent 
> to user-space driver/middleware. In such case the kernel driver will decide
> which ring is to dispatch the BSD video command.
> 
> As every BSD ring is powerful, it is enough to dispatch the BSD video command
> based on the drm fd. In such case the different BSD ring is used for video playing
> back and encoding. 
> 
> V1->V2: Follow Daniel's comment to do the following update:
>    a. consider the stolen check for BDW in kernel/early-quirks.c in patch 01
>    b. update the comment in Patch 04
>    c. use the simple ping-pong mechanism to add the support of dual BSD rings.
> The further optimization will be considered in another patch set.
> 
> V2->V3: Follow Daniel's comment to use the struct_mutext instead of
> atomic_t during determining which ring can be used to dispatch Video command.
> 
> V3->V4: Follow Imre's comment to adjust the patch order and do some minor updates.
> For example: add some comments to describe the semaphore in Patch 03 and update
> the ring name for the second bsd ring.
> 
> Zhao Yakui (6):
>   drm/i915: Split the BDW device definition to prepare for dual BSD
>     rings on BDW GT3
>   drm/i915: Update the restrict check to filter out wrong Ring ID
>     passed by user-space
>   drm/i915:Initialize the second BSD ring on BDW GT3 machine
>   drm/i915:Handle the irq interrupt for the second BSD ring
>   drm/i915:Add the VCS2 switch in Intel_ring_setup_status_page for Gen7
>     to remove the switch check warning
>   drm/i915: Use the coarse ping-pong mechanism based on drm fd to
>     dispatch the BSD command on BDW GT3

Entire series merged, thanks for patches&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch