From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Chander Kashyap <chander.kashyap@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Chander Kashyap <k.chander@samsung.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>
Subject: Re: [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420
Date: Wed, 14 May 2014 15:06:29 +0100 [thread overview]
Message-ID: <20140514140628.GA25241@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <5587958.90ud9NuKXm@wuerfel>
On Wed, May 14, 2014 at 02:04:51PM +0100, Arnd Bergmann wrote:
> On Wednesday 14 May 2014 13:33:55 Chander Kashyap wrote:
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> > index 4cd02bd..344d79fa 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -165,6 +165,7 @@ static int __init bl_idle_driver_init(struct cpuidle_driver *drv, int cpu_id)
> >
> > static const struct of_device_id compatible_machine_match[] = {
> > { .compatible = "arm,vexpress,v2p-ca15_a7" },
> > + { .compatible = "samsung,exynos5420" },
> > {},
> > };
>
> Does the cpuidle-big_little driver actually care about the platform?
No, platform specific bits are hidden behind MCPM. Apart from idle states
data, that will soon be initialized through DT too.
Actually, when idle for arm64 is merged we can even rework it and end up
with a single driver, DT based, that's the ultimate goal.
> If not, it would be good to add a generic string here as well, for
> future platforms to match.
Yes, you have a point.
> It still makes sense to list both the generic string and the platform
> specific one though, in case we have to work around subtle differences.
Agreed, but subtle differences do not belong in this driver, that's the
purpose of abstracting it the best we can. I have no problem in leaving
platform specific compatible there though.
Lorenzo
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420
Date: Wed, 14 May 2014 15:06:29 +0100 [thread overview]
Message-ID: <20140514140628.GA25241@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <5587958.90ud9NuKXm@wuerfel>
On Wed, May 14, 2014 at 02:04:51PM +0100, Arnd Bergmann wrote:
> On Wednesday 14 May 2014 13:33:55 Chander Kashyap wrote:
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> > index 4cd02bd..344d79fa 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -165,6 +165,7 @@ static int __init bl_idle_driver_init(struct cpuidle_driver *drv, int cpu_id)
> >
> > static const struct of_device_id compatible_machine_match[] = {
> > { .compatible = "arm,vexpress,v2p-ca15_a7" },
> > + { .compatible = "samsung,exynos5420" },
> > {},
> > };
>
> Does the cpuidle-big_little driver actually care about the platform?
No, platform specific bits are hidden behind MCPM. Apart from idle states
data, that will soon be initialized through DT too.
Actually, when idle for arm64 is merged we can even rework it and end up
with a single driver, DT based, that's the ultimate goal.
> If not, it would be good to add a generic string here as well, for
> future platforms to match.
Yes, you have a point.
> It still makes sense to list both the generic string and the platform
> specific one though, in case we have to work around subtle differences.
Agreed, but subtle differences do not belong in this driver, that's the
purpose of abstracting it the best we can. I have no problem in leaving
platform specific compatible there though.
Lorenzo
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2014-05-14 14:06 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ANuQgHGSPJ45tbrVppAVpOqF0OfHacPWfX=S5mOVxTPr66f7vg@mail.gmail.com>
2014-05-14 8:03 ` [PATCH v5 0/6] add cpuidle support for Exynos5420 Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 1/6] driver: cpuidle-big-little: add of_device_id structure Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 2/6] arm: exynos: add generic function to calculate cpu number Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 8:03 ` [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420 Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 13:04 ` Arnd Bergmann
2014-05-14 13:04 ` Arnd Bergmann
2014-05-14 14:06 ` Lorenzo Pieralisi [this message]
2014-05-14 14:06 ` Lorenzo Pieralisi
2014-05-14 14:06 ` Lorenzo Pieralisi
2014-05-14 8:03 ` [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration " Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-15 21:26 ` Tomasz Figa
2014-05-15 21:26 ` Tomasz Figa
2014-05-16 4:01 ` Chander Kashyap
2014-05-16 4:01 ` Chander Kashyap
2014-05-16 4:01 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 0/6] add cpuidle support " Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 1/6] driver: cpuidle-big-little: add of_device_id structure Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-28 8:58 ` Daniel Lezcano
2014-05-28 8:58 ` Daniel Lezcano
2014-05-16 8:03 ` [PATCH v6 2/6] arm: exynos: add generic function to calculate cpu number Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-28 9:00 ` Daniel Lezcano
2014-05-28 9:00 ` Daniel Lezcano
2014-05-16 8:03 ` [PATCH v6 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420 Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 5/6] exynos: cpuidle: do not allow cpuidle registration " Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` [PATCH v6 6/6] mcpm: exynos: populate suspend and powered_up callbacks Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-16 8:03 ` Chander Kashyap
2014-05-19 5:40 ` [PATCH v6 0/6] add cpuidle support for Exynos5420 Chander Kashyap
2014-05-19 5:40 ` Chander Kashyap
2014-05-19 5:40 ` Chander Kashyap
2014-05-26 4:40 ` Chander Kashyap
2014-05-26 4:40 ` Chander Kashyap
2014-05-26 4:40 ` Chander Kashyap
2014-05-26 10:29 ` Tomasz Figa
2014-05-26 10:29 ` Tomasz Figa
2014-05-28 4:28 ` Chander Kashyap
2014-05-28 4:28 ` Chander Kashyap
2014-05-28 4:28 ` Chander Kashyap
2014-05-28 4:35 ` Kukjin Kim
2014-05-28 4:35 ` Kukjin Kim
2014-05-28 9:02 ` Daniel Lezcano
2014-05-28 9:02 ` Daniel Lezcano
2014-05-29 4:37 ` Chander Kashyap
2014-05-29 4:37 ` Chander Kashyap
2014-05-29 4:37 ` Chander Kashyap
2014-06-10 12:38 ` Chander M. Kashyap
2014-06-10 12:38 ` Chander M. Kashyap
2014-06-10 12:38 ` Chander M. Kashyap
2014-05-14 8:03 ` [PATCH v5 6/6] mcpm: exynos: populate suspend and powered_up callbacks Chander Kashyap
2014-05-14 8:03 ` Chander Kashyap
2014-05-14 9:56 ` [PATCH v5 0/6] add cpuidle support for Exynos5420 Daniel Lezcano
2014-05-14 9:56 ` Daniel Lezcano
2014-05-14 10:43 ` Chander Kashyap
2014-05-14 10:43 ` Chander Kashyap
2014-05-14 10:43 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514140628.GA25241@e102568-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=chander.kashyap@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=k.chander@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.