From: Grant Likely <grant.likely@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Liviu Dudau <Liviu.Dudau@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robherring2@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/2] pci: Add IORESOURCE_BIT entry for PCIe ECAM resources.
Date: Mon, 02 Jun 2014 17:23:06 +0100 [thread overview]
Message-ID: <20140602162306.4AB0FC40476@trevor.secretlab.ca> (raw)
In-Reply-To: <390B3F94-C058-47D6-82CE-0393E60014FF@codeaurora.org>
On Mon, 2 Jun 2014 10:40:30 -0500, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Jun 2, 2014, at 10:09 AM, Grant Likely <grant.likely@linaro.org> wrote:
>
> > On Sat, 31 May 2014 20:41:04 +0200, Arnd Bergmann <arnd@arndb.de> wrote:
> >> On Saturday 31 May 2014 01:36:40 Liviu Dudau wrote:
> >>> We would like to be able to describe PCIe ECAM resources as
> >>> IORESOURCE_MEM blocks while distinguish them from standard
> >>> memory resources. Add an IORESOURCE_BIT entry for this case.
> >>>
> >>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >>
> >> I still don't see any value in this at all. What is the advantage
> >> of doing this opposed to just having a standardized 'reg' property
> >> for a particular compatible string?
> >
> > I'm inclined to agree. It doesn't seem appropriate to put config space
> > in ranges, and the host controller binding is responsible for
> > identifying how config space is memory mapped.
> >
> > g.
>
> I don’t agree when it comes to ECAM, but we can drop this for now
> until someone really does that.
Okay, humor me then. What would a ranges property look like for ECAM? Do
you have an example? I believe there would need to be a separate entry
for each and every PCI device on the bus to get the config spaces to be
contiguous.
> However, what do we do with the 2 cases that exist in upstream that
> are using ranges for cfg space?
Ignore them in the core code? Make the specific host controller handle
them I would think.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Liviu Dudau <Liviu.Dudau@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robherring2@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/2] pci: Add IORESOURCE_BIT entry for PCIe ECAM resources.
Date: Mon, 02 Jun 2014 17:23:06 +0100 [thread overview]
Message-ID: <20140602162306.4AB0FC40476@trevor.secretlab.ca> (raw)
In-Reply-To: <390B3F94-C058-47D6-82CE-0393E60014FF@codeaurora.org>
On Mon, 2 Jun 2014 10:40:30 -0500, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Jun 2, 2014, at 10:09 AM, Grant Likely <grant.likely@linaro.org> wrote:
>
> > On Sat, 31 May 2014 20:41:04 +0200, Arnd Bergmann <arnd@arndb.de> wrote:
> >> On Saturday 31 May 2014 01:36:40 Liviu Dudau wrote:
> >>> We would like to be able to describe PCIe ECAM resources as
> >>> IORESOURCE_MEM blocks while distinguish them from standard
> >>> memory resources. Add an IORESOURCE_BIT entry for this case.
> >>>
> >>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >>
> >> I still don't see any value in this at all. What is the advantage
> >> of doing this opposed to just having a standardized 'reg' property
> >> for a particular compatible string?
> >
> > I'm inclined to agree. It doesn't seem appropriate to put config space
> > in ranges, and the host controller binding is responsible for
> > identifying how config space is memory mapped.
> >
> > g.
>
> I don’t agree when it comes to ECAM, but we can drop this for now
> until someone really does that.
Okay, humor me then. What would a ranges property look like for ECAM? Do
you have an example? I believe there would need to be a separate entry
for each and every PCI device on the bus to get the config spaces to be
contiguous.
> However, what do we do with the 2 cases that exist in upstream that
> are using ranges for cfg space?
Ignore them in the core code? Make the specific host controller handle
them I would think.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Liviu Dudau <Liviu.Dudau@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robherring2@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/2] pci: Add IORESOURCE_BIT entry for PCIe ECAM resources.
Date: Mon, 02 Jun 2014 17:23:06 +0100 [thread overview]
Message-ID: <20140602162306.4AB0FC40476@trevor.secretlab.ca> (raw)
In-Reply-To: <390B3F94-C058-47D6-82CE-0393E60014FF@codeaurora.org>
On Mon, 2 Jun 2014 10:40:30 -0500, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Jun 2, 2014, at 10:09 AM, Grant Likely <grant.likely@linaro.org> wrote:
>
> > On Sat, 31 May 2014 20:41:04 +0200, Arnd Bergmann <arnd@arndb.de> wrote:
> >> On Saturday 31 May 2014 01:36:40 Liviu Dudau wrote:
> >>> We would like to be able to describe PCIe ECAM resources as
> >>> IORESOURCE_MEM blocks while distinguish them from standard
> >>> memory resources. Add an IORESOURCE_BIT entry for this case.
> >>>
> >>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >>
> >> I still don't see any value in this at all. What is the advantage
> >> of doing this opposed to just having a standardized 'reg' property
> >> for a particular compatible string?
> >
> > I'm inclined to agree. It doesn't seem appropriate to put config space
> > in ranges, and the host controller binding is responsible for
> > identifying how config space is memory mapped.
> >
> > g.
>
> I don’t agree when it comes to ECAM, but we can drop this for now
> until someone really does that.
Okay, humor me then. What would a ranges property look like for ECAM? Do
you have an example? I believe there would need to be a separate entry
for each and every PCI device on the bus to get the config spaces to be
contiguous.
> However, what do we do with the 2 cases that exist in upstream that
> are using ranges for cfg space?
Ignore them in the core code? Make the specific host controller handle
them I would think.
g.
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@linaro.org (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pci: Add IORESOURCE_BIT entry for PCIe ECAM resources.
Date: Mon, 02 Jun 2014 17:23:06 +0100 [thread overview]
Message-ID: <20140602162306.4AB0FC40476@trevor.secretlab.ca> (raw)
In-Reply-To: <390B3F94-C058-47D6-82CE-0393E60014FF@codeaurora.org>
On Mon, 2 Jun 2014 10:40:30 -0500, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Jun 2, 2014, at 10:09 AM, Grant Likely <grant.likely@linaro.org> wrote:
>
> > On Sat, 31 May 2014 20:41:04 +0200, Arnd Bergmann <arnd@arndb.de> wrote:
> >> On Saturday 31 May 2014 01:36:40 Liviu Dudau wrote:
> >>> We would like to be able to describe PCIe ECAM resources as
> >>> IORESOURCE_MEM blocks while distinguish them from standard
> >>> memory resources. Add an IORESOURCE_BIT entry for this case.
> >>>
> >>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >>
> >> I still don't see any value in this at all. What is the advantage
> >> of doing this opposed to just having a standardized 'reg' property
> >> for a particular compatible string?
> >
> > I'm inclined to agree. It doesn't seem appropriate to put config space
> > in ranges, and the host controller binding is responsible for
> > identifying how config space is memory mapped.
> >
> > g.
>
> I don???t agree when it comes to ECAM, but we can drop this for now
> until someone really does that.
Okay, humor me then. What would a ranges property look like for ECAM? Do
you have an example? I believe there would need to be a separate entry
for each and every PCI device on the bus to get the config spaces to be
contiguous.
> However, what do we do with the 2 cases that exist in upstream that
> are using ranges for cfg space?
Ignore them in the core code? Make the specific host controller handle
them I would think.
g.
next prev parent reply other threads:[~2014-06-02 16:23 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 16:03 [PATCH] of: treat PCI config space as IORESOURCE_MEM type Kumar Gala
2014-05-29 16:03 ` Kumar Gala
2014-05-29 20:44 ` Rob Herring
2014-05-29 20:44 ` Rob Herring
2014-05-29 20:44 ` Rob Herring
2014-05-29 20:51 ` Kumar Gala
2014-05-29 20:51 ` Kumar Gala
2014-05-29 20:51 ` Kumar Gala
2014-05-29 21:50 ` Rob Herring
2014-05-29 21:50 ` Rob Herring
2014-05-29 21:50 ` Rob Herring
2014-05-30 0:56 ` Liviu Dudau
2014-05-30 0:56 ` Liviu Dudau
2014-05-30 0:56 ` Liviu Dudau
[not found] ` <20140530005602.GE1677-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
2014-05-30 1:29 ` Bjorn Helgaas
2014-05-30 1:29 ` Bjorn Helgaas
2014-05-30 1:29 ` Bjorn Helgaas
2014-05-30 1:29 ` Bjorn Helgaas
2014-05-30 1:41 ` Liviu Dudau
2014-05-30 1:41 ` Liviu Dudau
2014-05-30 1:41 ` Liviu Dudau
2014-05-30 20:37 ` Jason Gunthorpe
2014-05-30 20:37 ` Jason Gunthorpe
2014-05-30 20:37 ` Jason Gunthorpe
2014-05-30 20:44 ` Kumar Gala
2014-05-30 20:44 ` Kumar Gala
2014-05-30 20:44 ` Kumar Gala
2014-05-30 20:45 ` Kumar Gala
2014-05-30 20:45 ` Kumar Gala
2014-05-30 20:45 ` Kumar Gala
2014-05-30 23:11 ` Liviu Dudau
2014-05-30 23:11 ` Liviu Dudau
2014-05-30 23:11 ` Liviu Dudau
2014-05-30 23:16 ` Bjorn Helgaas
2014-05-30 23:16 ` Bjorn Helgaas
2014-05-30 23:16 ` Bjorn Helgaas
2014-05-30 23:30 ` Liviu Dudau
2014-05-30 23:30 ` Liviu Dudau
2014-05-30 23:30 ` Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 0:36 ` [PATCH 1/2] pci: Add IORESOURCE_BIT entry for PCIe ECAM resources Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 18:41 ` Arnd Bergmann
2014-05-31 18:41 ` Arnd Bergmann
2014-05-31 18:41 ` Arnd Bergmann
2014-06-01 11:26 ` Liviu Dudau
2014-06-01 11:26 ` Liviu Dudau
2014-06-01 11:26 ` Liviu Dudau
2014-06-02 15:09 ` Grant Likely
2014-06-02 15:09 ` Grant Likely
2014-06-02 15:09 ` Grant Likely
2014-06-02 15:40 ` Kumar Gala
2014-06-02 15:40 ` Kumar Gala
2014-06-02 15:40 ` Kumar Gala
2014-06-02 16:23 ` Grant Likely [this message]
2014-06-02 16:23 ` Grant Likely
2014-06-02 16:23 ` Grant Likely
2014-06-02 16:23 ` Grant Likely
2014-06-02 18:09 ` Kumar Gala
2014-06-02 18:09 ` Kumar Gala
2014-06-02 18:09 ` Kumar Gala
2014-06-02 19:15 ` Arnd Bergmann
2014-06-02 19:15 ` Arnd Bergmann
2014-06-02 19:15 ` Arnd Bergmann
2014-06-02 20:43 ` Kumar Gala
2014-06-02 20:43 ` Kumar Gala
2014-06-02 20:43 ` Kumar Gala
2014-06-02 20:44 ` Arnd Bergmann
2014-06-02 20:44 ` Arnd Bergmann
2014-06-02 20:44 ` Arnd Bergmann
2014-06-03 8:44 ` Grant Likely
2014-06-03 8:44 ` Grant Likely
2014-06-03 8:44 ` Grant Likely
2014-06-03 8:44 ` Grant Likely
2014-06-03 9:21 ` Arnd Bergmann
2014-06-03 9:21 ` Arnd Bergmann
2014-06-03 9:21 ` Arnd Bergmann
2014-06-03 11:38 ` Grant Likely
2014-06-03 11:38 ` Grant Likely
2014-06-03 11:38 ` Grant Likely
2014-05-31 0:36 ` [PATCH 2/2] of: treat PCI config space as IORESOURCE_MEM type with special flags Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
2014-05-31 0:36 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602162306.4AB0FC40476@trevor.secretlab.ca \
--to=grant.likely@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.