From: David Sterba <dsterba@suse.cz>
To: Christian Hesse <mail@eworm.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs-progs: fix compiler warning
Date: Tue, 3 Jun 2014 18:52:25 +0200 [thread overview]
Message-ID: <20140603165225.GR22324@twin.jikos.cz> (raw)
In-Reply-To: <1401794959-25907-1-git-send-email-mail@eworm.de>
On Tue, Jun 03, 2014 at 01:29:19PM +0200, Christian Hesse wrote:
> gcc 4.9.0 gives a warning: array subscript is above array bounds
>
> Checking for "greater or equal" instead of just "equal" fixes this.
That fixes the warning, but I don't see the code path that leads to
level >= BTRFS_MAX_LEVEL
On the first pass, when level = 1 and the first while() reaches at most
BTRFS_MAX_LEVEL, the equality test is enough. So it has to go through
the second while() where level is decremented and in the range
[1..BTRFS_MAX_LEVEL-1] before 'goto again' jumps to the first while
again.
next prev parent reply other threads:[~2014-06-03 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 11:29 [PATCH 1/1] btrfs-progs: fix compiler warning Christian Hesse
2014-06-03 16:52 ` David Sterba [this message]
2014-06-03 18:04 ` Christian Hesse
2014-06-04 6:48 ` Qu Wenruo
2014-06-04 7:19 ` Christian Hesse
2014-06-04 16:44 ` David Sterba
2014-06-05 8:59 ` Christian Hesse
2014-06-10 11:05 ` David Sterba
2014-06-03 11:37 Christian Hesse
2014-06-05 8:13 Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603165225.GR22324@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.