Re: [PATCH 1/1] btrfs-progs: fix compiler warning

From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Christian Hesse <mail@eworm.de>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] btrfs-progs: fix compiler warning
Date: Wed, 4 Jun 2014 14:48:21 +0800	[thread overview]
Message-ID: <538EC135.6060105@cn.fujitsu.com> (raw)
In-Reply-To: <1401794959-25907-1-git-send-email-mail@eworm.de>

-------- Original Message --------
Subject: [PATCH 1/1] btrfs-progs: fix compiler warning
From: Christian Hesse <mail@eworm.de>
To: linux-btrfs@vger.kernel.org
Date: 2014年06月03日 19:29
> gcc 4.9.0 gives a warning: array subscript is above array bounds
>
> Checking for "greater or equal" instead of just "equal" fixes this.
>
> Signed-off-by: Christian Hesse <mail@eworm.de>
> ---
>   cmds-restore.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmds-restore.c b/cmds-restore.c
> index 96b97e1..534a49e 100644
> --- a/cmds-restore.c
> +++ b/cmds-restore.c
> @@ -169,7 +169,7 @@ again:
>   			break;
>   	}
>   
> -	if (level == BTRFS_MAX_LEVEL)
> +	if (level >= BTRFS_MAX_LEVEL)
>   		return 1;
>   
>   	slot = path->slots[level] + 1;
Also I faied to reproduce the bug.
Using gcc-4.9.0-3 from Archlinux core repo.

It seems to be related to default gcc flags from distribution?

Thanks,
Qu