From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org, broonie@kernel.org,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ASoC: wm_adsp: Move DVFS control into codec driver
Date: Wed, 11 Jun 2014 11:54:25 +0100 [thread overview]
Message-ID: <20140611105425.GA12074@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140609150314.GC5229@opensource.wolfsonmicro.com>
On Mon, Jun 09, 2014 at 04:03:14PM +0100, Richard Fitzgerald wrote:
>
> -#define WM_ADSP2(wname, num) \
> +#define WM_ADSP2_E(wname, num, event_fn) \
> { .id = snd_soc_dapm_dai_link, .name = wname " Preloader", \
> - .reg = SND_SOC_NOPM, .shift = num, .event = wm_adsp2_early_event, \
> + .reg = SND_SOC_NOPM, .shift = num, .event = event_fn, \
> .event_flags = SND_SOC_DAPM_PRE_PMU }, \
You need to add a SND_SOC_DAPM_PRE_PMD in here otherwise your
wm5102_sysclk_ev won't get called on power down.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com,
tiwai@suse.de, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
broonie@kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH 2/4] ASoC: wm_adsp: Move DVFS control into codec driver
Date: Wed, 11 Jun 2014 11:54:25 +0100 [thread overview]
Message-ID: <20140611105425.GA12074@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140609150314.GC5229@opensource.wolfsonmicro.com>
On Mon, Jun 09, 2014 at 04:03:14PM +0100, Richard Fitzgerald wrote:
>
> -#define WM_ADSP2(wname, num) \
> +#define WM_ADSP2_E(wname, num, event_fn) \
> { .id = snd_soc_dapm_dai_link, .name = wname " Preloader", \
> - .reg = SND_SOC_NOPM, .shift = num, .event = wm_adsp2_early_event, \
> + .reg = SND_SOC_NOPM, .shift = num, .event = event_fn, \
> .event_flags = SND_SOC_DAPM_PRE_PMU }, \
You need to add a SND_SOC_DAPM_PRE_PMD in here otherwise your
wm5102_sysclk_ev won't get called on power down.
Thanks,
Charles
next prev parent reply other threads:[~2014-06-12 20:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:00 [PATCH 0/4] arizona: Improvements to codec DVFS control Richard Fitzgerald
2014-06-09 15:00 ` Richard Fitzgerald
2014-06-09 15:02 ` [PATCH 1/4] mfd: arizona: Export function to control subsystem DVFS Richard Fitzgerald
2014-06-16 16:42 ` Lee Jones
2014-06-16 16:48 ` Mark Brown
2014-06-16 17:09 ` Charles Keepax
2014-06-16 17:06 ` Charles Keepax
2014-06-09 15:03 ` [PATCH 2/4] ASoC: wm_adsp: Move DVFS control into codec driver Richard Fitzgerald
2014-06-11 10:54 ` Charles Keepax [this message]
2014-06-11 10:54 ` Charles Keepax
2014-06-09 15:03 ` [PATCH 3/4] ASoC: arizona: Add DVFS handling for sample rate control Richard Fitzgerald
2014-06-09 15:04 ` [PATCH 4/4] regulator: arizona-ldo1: Do not control clocking from regulator Richard Fitzgerald
2014-06-09 18:43 ` Mark Brown
2014-06-11 10:59 ` Charles Keepax
2014-06-11 10:59 ` Charles Keepax
2014-06-11 13:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611105425.GA12074@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.