All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/08] ARM: shmobile: Rework include path V2
Date: Tue, 17 Jun 2014 11:05:11 +0000	[thread overview]
Message-ID: <201406171305.12186.arnd@arndb.de> (raw)
In-Reply-To: <20140617074658.30008.53021.sendpatchset@w520>

On Tuesday 17 June 2014, Magnus Damm wrote:
> Please note that these are only lightly compile tested with a handful
> of defconfigs, but any potential issue should be trivial to fix.
> 
> Also, there are certain bits of arch/arm/mach-shmobile/include/mach/
> get included from places like arch/arm/boot/compressed/ (booting
> legacy kernel directly from reset vector) and also from SoC specific
> legacy code under drivers/pinctrl. My proposal is to keep those users
> as-is until we phase out legacy board support (2-3 kernels?), let me
> know if you would like to get rid of "include/mach" sooner!

If it's only about arch/arm/boot/compressed, you can just move the
header files to the same directory, as nothing else includes them.

I've played with a full multiplatform conversion of a few platforms
including shmobile in the past, and all I needed for the legacy pinctrl
drivers was to duplicate the irq_pin() definition, which is probably
a reasonable hack for code that we know is going away anyway, just
add a comment for both definitions explaining that they have to be
kept in sync. This one is less obvious than the boot header.

One general comment: please use 'git format-patch -M' or set the
'diff.renames' git option for sending patches for reviews that
rename files. No need to send this patch set again.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/08] ARM: shmobile: Rework include path V2
Date: Tue, 17 Jun 2014 13:05:11 +0200	[thread overview]
Message-ID: <201406171305.12186.arnd@arndb.de> (raw)
In-Reply-To: <20140617074658.30008.53021.sendpatchset@w520>

On Tuesday 17 June 2014, Magnus Damm wrote:
> Please note that these are only lightly compile tested with a handful
> of defconfigs, but any potential issue should be trivial to fix.
> 
> Also, there are certain bits of arch/arm/mach-shmobile/include/mach/
> get included from places like arch/arm/boot/compressed/ (booting
> legacy kernel directly from reset vector) and also from SoC specific
> legacy code under drivers/pinctrl. My proposal is to keep those users
> as-is until we phase out legacy board support (2-3 kernels?), let me
> know if you would like to get rid of "include/mach" sooner!

If it's only about arch/arm/boot/compressed, you can just move the
header files to the same directory, as nothing else includes them.

I've played with a full multiplatform conversion of a few platforms
including shmobile in the past, and all I needed for the legacy pinctrl
drivers was to duplicate the irq_pin() definition, which is probably
a reasonable hack for code that we know is going away anyway, just
add a comment for both definitions explaining that they have to be
kept in sync. This one is less obvious than the boot header.

One general comment: please use 'git format-patch -M' or set the
'diff.renames' git option for sending patches for reviews that
rename files. No need to send this patch set again.

	Arnd

  parent reply	other threads:[~2014-06-17 11:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17  7:46 [PATCH v2 00/08] ARM: shmobile: Rework include path V2 Magnus Damm
2014-06-17  7:46 ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 01/08] ARM: shmobile: Move intc.h, cleanup sh_intc.h usage Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 02/08] ARM: shmobile: Move dma-register.h Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 03/08] ARM: shmobile: Move clock.h Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 05/08] ARM: shmobile: Move common.h Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 06/08] ARM: shmobile: Move pm-rmobile.h, cleanup sh73xx.h Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:47 ` [PATCH v2 07/08] ARM: shmobile: Move pm-rcar.h, cleanup r8a7779 case Magnus Damm
2014-06-17  7:47   ` Magnus Damm
2014-06-17  7:48 ` [PATCH v2 08/08] ARM: shmobile: Move rcar-gen2.h, cleanup r8a7790 case Magnus Damm
2014-06-17  7:48   ` Magnus Damm
2014-06-17 11:05 ` Arnd Bergmann [this message]
2014-06-17 11:05   ` [PATCH v2 00/08] ARM: shmobile: Rework include path V2 Arnd Bergmann
2014-06-17 12:21 ` Simon Horman
2014-06-17 12:21   ` Simon Horman
2014-06-17  7:47 [PATCH v2 04/08] ARM: shmobile: Move most of irqs.h, keep some for pinctl Magnus Damm
2014-06-17  7:47 ` Magnus Damm
2014-06-18 14:55 ` Simon Horman
2014-06-18 14:55   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201406171305.12186.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.