Re: [PATCH v3 4/8] qcom: spm-devices: Add SPM device manager for the SoC

From: Lina Iyer <lina.iyer@linaro.org>
To: Pramod Gurav <pramod.gurav@smartplayin.com>
Cc: daniel.lezcano@linaro.org, khilman@linaro.org,
	sboyd@codeaurora.org, davidb@codeaurora.org,
	galak@codeaurora.org, linux-arm-msm@vger.kernel.org,
	lorenzo.pieralisi@arm.com, msivasub@codeauorora.org,
	Praveen Chidamabram <pchidamb@codeaurora.org>,
	Murali Nalajala <mnalajal@codeaurora.org>
Subject: Re: [PATCH v3 4/8] qcom: spm-devices: Add SPM device manager for the SoC
Date: Tue, 19 Aug 2014 08:51:21 -0600	[thread overview]
Message-ID: <20140819145121.GB53916@ilina-mac.local> (raw)
In-Reply-To: <53F31914.9040804@smartplayin.com>

On Tue, Aug 19, 2014 at 02:59:56PM +0530, Pramod Gurav wrote:
>Hi Lina,
>
>On Tuesday 19 August 2014 03:53 AM, Lina Iyer wrote:
>> +
>> +config QCOM_PM
>> +	tristate "Qualcomm Power Management"
>This does not compile as a module. making CONFIG_QCOM_PM=m causing
>redefinition of function 'msm_spm_set_low_power_mode' in header.
Good point. Let me make it a bool. I dont see a need for this to be a
loadable module.
>
>drivers/soc/qcom/spm-devices.c:48:5: error: redefinition of
>‘msm_spm_set_low_power_mode’
>In file included from drivers/soc/qcom/spm-devices.c:25:0:
>include/soc/qcom/spm.h:30:19: note: previous definition of
>‘msm_spm_set_low_power_mode’ was here
>
>
>> +	depends on PM && ARCH_QCOM && OF
>> +	help
>> +	  QCOM Platform specific power driver to manage cores and L2 low power
>> +	  modes. It interface with various system drivers to put the cores in
>> +	  low power modes.
>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
>> index 20b329f..9457b2a 100644
>> --- a/drivers/soc/qcom/Makefile
>> +++ b/drivers/soc/qcom/Makefile
>> @@ -1,4 +1,4 @@
>>  obj-$(CONFIG_QCOM_GSBI)	+=	qcom_gsbi.o
>> -obj-$(CONFIG_QCOM_PM)	+=	spm.o
>> +obj-$(CONFIG_QCOM_PM)	+=	spm.o spm-devices.o
>>  CFLAGS_scm.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
>>  obj-$(CONFIG_QCOM_SCM) += scm.o scm-boot.o
>
>