From: Lina Iyer <lina.iyer@linaro.org>
To: Kevin Hilman <khilman@linaro.org>
Cc: daniel.lezcano@linaro.org, sboyd@codeaurora.org,
davidb@codeaurora.org, galak@codeaurora.org,
linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com,
msivasub@codeauorora.org
Subject: Re: [PATCH v3 1/8] msm: scm: Move scm-boot files to drivers/soc and include/soc
Date: Wed, 27 Aug 2014 12:57:32 -0600 [thread overview]
Message-ID: <20140827185732.GD74960@ilina-mac.local> (raw)
In-Reply-To: <7h38chg8bj.fsf@paris.lan>
On Wed, Aug 27, 2014 at 10:18:24AM -0700, Kevin Hilman wrote:
>Lina Iyer <lina.iyer@linaro.org> writes:
>
>> Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>
>Why the move? It looks like scm-boot.c still calls into the main
>scm_call() stuff that still lives under arch/arm/mach-qcom, and not in
>arm64, so I'm not seeing the motiviation for the change (and the
>changelog didn't help explain either :)
>
>Kevin
I dint intend on moving the scm-boot for 64 bit purposes, but that
would be a good argument :) My motivation was to move the scm-boot.h, but
figured might as well clean up the mach-qcom in the process, per
guidance.
>
>
>> arch/arm/mach-qcom/Makefile | 1 -
>> arch/arm/mach-qcom/platsmp.c | 2 +-
>> drivers/soc/qcom/Makefile | 2 +-
>> {arch/arm/mach-qcom => drivers/soc/qcom}/scm-boot.c | 4 ++--
>> {arch/arm/mach-qcom => include/soc/qcom}/scm-boot.h | 0
>> 5 files changed, 4 insertions(+), 5 deletions(-)
>> rename {arch/arm/mach-qcom => drivers/soc/qcom}/scm-boot.c (97%)
>> rename {arch/arm/mach-qcom => include/soc/qcom}/scm-boot.h (100%)
>>
>> diff --git a/arch/arm/mach-qcom/Makefile b/arch/arm/mach-qcom/Makefile
>> index db41e8c..e324375 100644
>> --- a/arch/arm/mach-qcom/Makefile
>> +++ b/arch/arm/mach-qcom/Makefile
>> @@ -1,3 +1,2 @@
>> obj-y := board.o
>> obj-$(CONFIG_SMP) += platsmp.o
>> -obj-$(CONFIG_QCOM_SCM) += scm-boot.o
>> diff --git a/arch/arm/mach-qcom/platsmp.c b/arch/arm/mach-qcom/platsmp.c
>> index d690856..a692bcb 100644
>> --- a/arch/arm/mach-qcom/platsmp.c
>> +++ b/arch/arm/mach-qcom/platsmp.c
>> @@ -20,7 +20,7 @@
>>
>> #include <asm/smp_plat.h>
>>
>> -#include "scm-boot.h"
>> +#include <soc/qcom/scm-boot.h>
>>
>> #define VDD_SC1_ARRAY_CLAMP_GFS_CTL 0x35a0
>> #define SCSS_CPU1CORE_RESET 0x2d80
>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
>> index a39446d..70d52ed 100644
>> --- a/drivers/soc/qcom/Makefile
>> +++ b/drivers/soc/qcom/Makefile
>> @@ -1,3 +1,3 @@
>> obj-$(CONFIG_QCOM_GSBI) += qcom_gsbi.o
>> CFLAGS_scm.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
>> -obj-$(CONFIG_QCOM_SCM) += scm.o
>> +obj-$(CONFIG_QCOM_SCM) += scm.o scm-boot.o
>> diff --git a/arch/arm/mach-qcom/scm-boot.c b/drivers/soc/qcom/scm-boot.c
>> similarity index 97%
>> rename from arch/arm/mach-qcom/scm-boot.c
>> rename to drivers/soc/qcom/scm-boot.c
>> index 5add20e..60ff7b4 100644
>> --- a/arch/arm/mach-qcom/scm-boot.c
>> +++ b/drivers/soc/qcom/scm-boot.c
>> @@ -17,9 +17,9 @@
>>
>> #include <linux/module.h>
>> #include <linux/slab.h>
>> -#include <soc/qcom/scm.h>
>>
>> -#include "scm-boot.h"
>> +#include <soc/qcom/scm.h>
>> +#include <soc/qcom/scm-boot.h>
>>
>> /*
>> * Set the cold/warm boot address for one of the CPU cores.
>> diff --git a/arch/arm/mach-qcom/scm-boot.h b/include/soc/qcom/scm-boot.h
>> similarity index 100%
>> rename from arch/arm/mach-qcom/scm-boot.h
>> rename to include/soc/qcom/scm-boot.h
next prev parent reply other threads:[~2014-08-27 18:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 22:23 [PATCH v3 0/8] QCOM 8074 cpuidle driver Lina Iyer
2014-08-18 22:23 ` [PATCH v3 1/8] msm: scm: Move scm-boot files to drivers/soc and include/soc Lina Iyer
2014-08-27 17:18 ` Kevin Hilman
2014-08-27 18:57 ` Lina Iyer [this message]
2014-08-27 20:24 ` Kevin Hilman
2014-08-27 20:31 ` Lina Iyer
2014-08-18 22:23 ` [PATCH v3 2/8] msm: scm: Add SCM warmboot flags for quad core targets Lina Iyer
2014-08-18 22:23 ` [PATCH v3 3/8] qcom: spm: Add Subsystem Power Manager driver (SAW2) Lina Iyer
2014-08-19 14:07 ` Kumar Gala
2014-08-19 15:28 ` Lina Iyer
2014-08-18 22:23 ` [PATCH v3 4/8] qcom: spm-devices: Add SPM device manager for the SoC Lina Iyer
2014-08-19 9:29 ` Pramod Gurav
2014-08-19 14:51 ` Lina Iyer
2014-08-18 22:23 ` [PATCH v3 5/8] arm: dts: qcom: Add SPM device bindings for 8974 Lina Iyer
2014-08-18 22:23 ` [PATCH v3 6/8] qcom: msm-pm: Add cpu low power mode functions Lina Iyer
2014-08-18 22:23 ` [PATCH v3 7/8] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-08-19 7:41 ` Pramod Gurav
2014-08-19 14:54 ` Lina Iyer
2014-08-19 15:01 ` Pramod Gurav
2014-08-18 22:23 ` [PATCH v3 8/8] arm: dts: qcom: Add idle states device nodes for 8974 Lina Iyer
2014-08-19 15:30 ` [PATCH v3 0/8] QCOM 8074 cpuidle driver Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827185732.GD74960@ilina-mac.local \
--to=lina.iyer@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=khilman@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=msivasub@codeauorora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.