From: Jeff Layton <jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 00/10] locks/nfsd: internal lease API overhaul
Date: Sun, 24 Aug 2014 21:43:01 -0400 [thread overview]
Message-ID: <20140824214301.61019123@synchrony.poochiereds.net> (raw)
In-Reply-To: <20140824161046.GI15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Sun, 24 Aug 2014 09:10:46 -0700
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> One more wishlist item in addition to the one mentioned in the patches:
>
> - add a return value to lm_break so that the lock manager can tell the
> core code "you can delete this lease right now". That gets rid of
> the games with the timeout which require all kinds of race avoidance
> code in the users.
>
I'm not sure I understand what you're suggesting here. Isn't it just as
simple to have lm_break call lease_modify to just remove the lease?
> And a big one that doesn't seem easily addressable, but I'll drop it in
> anyway:
>
> - calling ->lm_break without i_lock would make everyones life a heck
> lot easier..
>
Indeed. I have some ideas for a larger cleanup of the file locking
code. This series is really sort of prep work for that overhaul, and
I'm hoping we'll be able to do something along those lines.
--
Jeff Layton <jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jeff.layton@primarydata.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org,
cluster-devel@redhat.com, linux-cifs@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 00/10] locks/nfsd: internal lease API overhaul
Date: Sun, 24 Aug 2014 21:43:01 -0400 [thread overview]
Message-ID: <20140824214301.61019123@synchrony.poochiereds.net> (raw)
In-Reply-To: <20140824161046.GI15908@infradead.org>
On Sun, 24 Aug 2014 09:10:46 -0700
Christoph Hellwig <hch@infradead.org> wrote:
> One more wishlist item in addition to the one mentioned in the patches:
>
> - add a return value to lm_break so that the lock manager can tell the
> core code "you can delete this lease right now". That gets rid of
> the games with the timeout which require all kinds of race avoidance
> code in the users.
>
I'm not sure I understand what you're suggesting here. Isn't it just as
simple to have lm_break call lease_modify to just remove the lease?
> And a big one that doesn't seem easily addressable, but I'll drop it in
> anyway:
>
> - calling ->lm_break without i_lock would make everyones life a heck
> lot easier..
>
Indeed. I have some ideas for a larger cleanup of the file locking
code. This series is really sort of prep work for that overhaul, and
I'm hoping we'll be able to do something along those lines.
--
Jeff Layton <jlayton@primarydata.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jeff.layton@primarydata.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 00/10] locks/nfsd: internal lease API overhaul
Date: Sun, 24 Aug 2014 21:43:01 -0400 [thread overview]
Message-ID: <20140824214301.61019123@synchrony.poochiereds.net> (raw)
In-Reply-To: <20140824161046.GI15908@infradead.org>
On Sun, 24 Aug 2014 09:10:46 -0700
Christoph Hellwig <hch@infradead.org> wrote:
> One more wishlist item in addition to the one mentioned in the patches:
>
> - add a return value to lm_break so that the lock manager can tell the
> core code "you can delete this lease right now". That gets rid of
> the games with the timeout which require all kinds of race avoidance
> code in the users.
>
I'm not sure I understand what you're suggesting here. Isn't it just as
simple to have lm_break call lease_modify to just remove the lease?
> And a big one that doesn't seem easily addressable, but I'll drop it in
> anyway:
>
> - calling ->lm_break without i_lock would make everyones life a heck
> lot easier..
>
Indeed. I have some ideas for a larger cleanup of the file locking
code. This series is really sort of prep work for that overhaul, and
I'm hoping we'll be able to do something along those lines.
--
Jeff Layton <jlayton@primarydata.com>
next prev parent reply other threads:[~2014-08-25 1:43 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 14:41 [PATCH 00/10] locks/nfsd: internal lease API overhaul Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
2014-08-23 14:41 ` [PATCH 04/10] locks: clean up vfs_setlease kerneldoc comments Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-24 15:51 ` Christoph Hellwig
2014-08-24 15:51 ` [Cluster-devel] " Christoph Hellwig
[not found] ` <20140824155117.GC15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-25 20:11 ` J. Bruce Fields
2014-08-25 20:11 ` [Cluster-devel] " J. Bruce Fields
2014-08-25 20:11 ` J. Bruce Fields
2014-08-23 14:41 ` [PATCH 07/10] locks: define a lm_setup handler for leases Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
[not found] ` <1408804878-1331-8-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 15:58 ` Christoph Hellwig
2014-08-24 15:58 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 15:58 ` Christoph Hellwig
2014-08-25 1:19 ` Jeff Layton
2014-08-25 1:19 ` [Cluster-devel] " Jeff Layton
2014-08-26 13:58 ` Christoph Hellwig
2014-08-26 13:58 ` [Cluster-devel] " Christoph Hellwig
2014-08-23 14:41 ` [PATCH 08/10] locks: move i_lock acquisition into generic_*_lease handlers Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
[not found] ` <1408804878-1331-9-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 16:06 ` Christoph Hellwig
2014-08-24 16:06 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 16:06 ` Christoph Hellwig
[not found] ` <20140824160634.GG15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-24 16:11 ` Christoph Hellwig
2014-08-24 16:11 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 16:11 ` Christoph Hellwig
[not found] ` <20140824161134.GJ15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-31 14:51 ` Jeff Layton
2014-08-31 14:51 ` [Cluster-devel] " Jeff Layton
2014-08-31 14:51 ` Jeff Layton
2014-08-25 1:36 ` Jeff Layton
2014-08-25 1:36 ` [Cluster-devel] " Jeff Layton
2014-08-25 1:36 ` Jeff Layton
[not found] ` <1408804878-1331-1-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-23 14:41 ` [PATCH 01/10] locks: close potential race in lease_get_mtime Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-2-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 15:48 ` Christoph Hellwig
2014-08-24 15:48 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 15:48 ` Christoph Hellwig
2014-08-25 20:01 ` J. Bruce Fields
2014-08-25 20:01 ` [Cluster-devel] " J. Bruce Fields
2014-08-23 14:41 ` [PATCH 02/10] nfsd: fix potential lease memory leak in nfs4_setlease Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-3-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 15:48 ` Christoph Hellwig
2014-08-24 15:48 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 15:48 ` Christoph Hellwig
2014-08-23 14:41 ` [PATCH 03/10] locks: generic_delete_lease doesn't need a file_lock at all Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-4-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 1:27 ` Christoph Hellwig
2014-08-24 1:27 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 1:27 ` Christoph Hellwig
[not found] ` <20140824012757.GA21609-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-24 10:09 ` Jeff Layton
2014-08-24 10:09 ` [Cluster-devel] " Jeff Layton
2014-08-24 10:09 ` Jeff Layton
2014-08-23 14:41 ` [PATCH 05/10] nfsd: don't keep a pointer to the lease in nfs4_file Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-6-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 15:51 ` Christoph Hellwig
2014-08-24 15:51 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 15:51 ` Christoph Hellwig
2014-08-23 14:41 ` [PATCH 06/10] locks: plumb an "aux" pointer into the setlease routines Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-7-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 1:33 ` Christoph Hellwig
2014-08-24 1:33 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 1:33 ` Christoph Hellwig
[not found] ` <20140824013305.GB21609-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-24 10:08 ` Jeff Layton
2014-08-24 10:08 ` [Cluster-devel] " Jeff Layton
2014-08-24 10:08 ` Jeff Layton
[not found] ` <20140824060801.5402880c-08S845evdOaAjSkqwZiSMmfYqLom42DlXqFh9Ls21Oc@public.gmane.org>
2014-08-24 15:54 ` Christoph Hellwig
2014-08-24 15:54 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 15:54 ` Christoph Hellwig
2014-08-25 20:28 ` J. Bruce Fields
2014-08-25 20:28 ` [Cluster-devel] " J. Bruce Fields
2014-08-25 20:28 ` J. Bruce Fields
[not found] ` <20140825202852.GD21957-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2014-08-26 10:53 ` Jeff Layton
2014-08-26 10:53 ` [Cluster-devel] " Jeff Layton
2014-08-26 10:53 ` Jeff Layton
2014-08-23 14:41 ` [PATCH 09/10] locks: move freeing of leases outside of i_lock Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
[not found] ` <1408804878-1331-10-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-08-24 16:08 ` Christoph Hellwig
2014-08-24 16:08 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 16:08 ` Christoph Hellwig
[not found] ` <20140824160804.GH15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-25 1:35 ` Jeff Layton
2014-08-25 1:35 ` [Cluster-devel] " Jeff Layton
2014-08-25 1:35 ` Jeff Layton
2014-08-23 14:41 ` [PATCH 10/10] locks: update Documentation/filesystems with lease API changes Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] " Jeff Layton
2014-08-23 14:41 ` Jeff Layton
2014-08-24 16:10 ` [PATCH 00/10] locks/nfsd: internal lease API overhaul Christoph Hellwig
2014-08-24 16:10 ` [Cluster-devel] " Christoph Hellwig
2014-08-24 16:10 ` Christoph Hellwig
[not found] ` <20140824161046.GI15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-25 1:43 ` Jeff Layton [this message]
2014-08-25 1:43 ` [Cluster-devel] " Jeff Layton
2014-08-25 1:43 ` Jeff Layton
[not found] ` <20140824214301.61019123-08S845evdOaAjSkqwZiSMmfYqLom42DlXqFh9Ls21Oc@public.gmane.org>
2014-08-26 13:59 ` Christoph Hellwig
2014-08-26 13:59 ` [Cluster-devel] " Christoph Hellwig
2014-08-26 13:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140824214301.61019123@synchrony.poochiereds.net \
--to=jeff.layton-7i+n7zu2hftekmmhf/gkza@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.