Re: [alsa-devel] [PATCH v2 1/2] mfd: arizona: Add support for INn_Mode register control

From: Inha Song <ideal.song@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, sameo@linux.intel.com,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
	robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	cw00.choi@samsung.com, broonie@kernel.org, galak@codeaurora.org,
	ckeepax@opensource.wolfsonmicro.com
Subject: Re: [alsa-devel] [PATCH v2 1/2] mfd: arizona: Add support for INn_Mode register control
Date: Mon, 25 Aug 2014 18:20:01 +0900	[thread overview]
Message-ID: <20140825182001.666bd966@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <20140821121219.GF4266@lee--X1>

Hi Lee,

On Thu, 21 Aug 2014 13:12:19 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> On Wed, 13 Aug 2014, Inha Song wrote:
> 
> > Some boards need to set the INn_MODE[1:0] register to change
> > the input signal patch. This wlf,inmode property is optional.
> > If present values must be specified by the number of
> > ARIZONA_MAX_INPUT.
> > 
> > Example:
> >    - wlf,inmode = <2 0 2 0>;	/* IN1, IN3 use DMIC */
> > 
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> >  drivers/mfd/arizona-core.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> This is going to require a DT Ack.
> 
> Is [2/2] adding the documentation?  I can't easily go and look because
> you send the patch-set unthreaded.  Please thread patch-sets.  See
> the man page for `git send-email` for more information.
> 

Sorry, I will resend this patch set to use "git send email".

Best regards,
Inha Song.

> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index 10a0cb9..2b68ccd 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> >  static int arizona_of_get_core_pdata(struct arizona *arizona)
> >  {
> >  	struct arizona_pdata *pdata = &arizona->pdata;
> > -	int ret, i;
> > +	int ret, i, proplen;
> >  
> >  	pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
> >  
> > @@ -560,6 +560,15 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> >  			ret);
> >  	}
> >  
> > +	proplen = of_property_count_u32_elems(arizona->dev->of_node,
> > +					      "wlf,inmode");
> > +	if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode)) {
> > +		for (i = 0; i < proplen; i++)
> > +			of_property_read_u32_index(arizona->dev->of_node,
> > +						   "wlf,inmode", i,
> > +						    &arizona->pdata.inmode[i]);
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel