From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Yuvaraj Cd <yuvaraj.lkml@gmail.com>,
Olof Johansson <olof@lixom.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Prashanth G <prashanth.g@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
sunil joshi <joshi@samsung.com>
Subject: Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators
Date: Tue, 26 Aug 2014 08:17:21 +0100 [thread overview]
Message-ID: <20140826071721.GV17528@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=V4TSKsbjj3dXCdSzVrh3sxH-FkpFEbEo+JA1bN9R-XWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Mon, Aug 25, 2014 at 08:40:40AM -0700, Doug Anderson wrote:
> On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas
> > I see, so probably until we have a way to define the operating mode for
> > each regulator using DT we should set the opmode to normal when enabling a
> > regulator independently of the value the hardware register reported on probe.
> > Can you please test the following change [0] so I can post as a proper
> > patch? Doug, Mark do you think that forcing the regulator to opmode normal
> > when enabling is the right solution here?
> IMHO that makes sense.
No, this doesn't make any obvious sense to me at all. Picking normal as
a default if the hardware reads back off due to overlapping
impelementation or something *might* make sense but not overwriting the
hardware state without explicit permission from the machine integration
is a key goal for the regulator API.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators
Date: Tue, 26 Aug 2014 08:17:21 +0100 [thread overview]
Message-ID: <20140826071721.GV17528@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=V4TSKsbjj3dXCdSzVrh3sxH-FkpFEbEo+JA1bN9R-XWA@mail.gmail.com>
On Mon, Aug 25, 2014 at 08:40:40AM -0700, Doug Anderson wrote:
> On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas
> > I see, so probably until we have a way to define the operating mode for
> > each regulator using DT we should set the opmode to normal when enabling a
> > regulator independently of the value the hardware register reported on probe.
> > Can you please test the following change [0] so I can post as a proper
> > patch? Doug, Mark do you think that forcing the regulator to opmode normal
> > when enabling is the right solution here?
> IMHO that makes sense.
No, this doesn't make any obvious sense to me at all. Picking normal as
a default if the hardware reads back off due to overlapping
impelementation or something *might* make sense but not overwriting the
hardware state without explicit permission from the machine integration
is a key goal for the regulator API.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140826/c34310de/attachment-0001.sig>
next prev parent reply other threads:[~2014-08-26 7:17 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:32 [PATCH v9 0/2] Add Maxim 77802 regulator support Javier Martinez Canillas
2014-08-18 8:32 ` Javier Martinez Canillas
2014-08-18 8:32 ` [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators Javier Martinez Canillas
2014-08-18 8:32 ` Javier Martinez Canillas
2014-08-18 8:32 ` Javier Martinez Canillas
2014-08-18 15:23 ` Mark Brown
2014-08-18 15:23 ` Mark Brown
2014-08-22 6:01 ` Yuvaraj Cd
2014-08-22 6:01 ` Yuvaraj Cd
2014-08-22 6:01 ` Yuvaraj Cd
2014-08-22 12:15 ` Javier Martinez Canillas
2014-08-22 12:15 ` Javier Martinez Canillas
2014-08-22 12:15 ` Javier Martinez Canillas
2014-08-22 14:45 ` Mark Brown
2014-08-22 14:45 ` Mark Brown
2014-08-22 14:45 ` Mark Brown
2014-08-22 17:53 ` Javier Martinez Canillas
2014-08-22 17:53 ` Javier Martinez Canillas
2014-08-22 17:53 ` Javier Martinez Canillas
2014-08-22 18:30 ` Mark Brown
2014-08-22 18:30 ` Mark Brown
2014-08-22 18:30 ` Mark Brown
2014-08-22 22:02 ` Javier Martinez Canillas
2014-08-22 22:02 ` Javier Martinez Canillas
2014-08-22 22:02 ` Javier Martinez Canillas
2014-08-22 22:15 ` Doug Anderson
2014-08-22 22:15 ` Doug Anderson
2014-08-22 22:15 ` Doug Anderson
2014-08-25 8:22 ` Yuvaraj Cd
2014-08-25 8:22 ` Yuvaraj Cd
2014-08-25 8:22 ` Yuvaraj Cd
2014-08-25 9:07 ` Javier Martinez Canillas
2014-08-25 9:07 ` Javier Martinez Canillas
2014-08-25 9:07 ` Javier Martinez Canillas
2014-08-25 10:46 ` Yuvaraj Cd
2014-08-25 10:46 ` Yuvaraj Cd
2014-08-25 10:46 ` Yuvaraj Cd
2014-08-25 15:40 ` Doug Anderson
2014-08-25 15:40 ` Doug Anderson
2014-08-25 15:40 ` Doug Anderson
2014-08-25 17:20 ` Javier Martinez Canillas
2014-08-25 17:20 ` Javier Martinez Canillas
2014-08-25 17:20 ` Javier Martinez Canillas
2014-08-26 7:17 ` Mark Brown [this message]
2014-08-26 7:17 ` Mark Brown
2014-08-26 7:17 ` Mark Brown
2014-08-26 9:08 ` Javier Martinez Canillas
2014-08-26 9:08 ` Javier Martinez Canillas
2014-08-26 9:08 ` Javier Martinez Canillas
2014-08-26 9:12 ` Mark Brown
2014-08-26 9:12 ` Mark Brown
2014-08-26 9:12 ` Mark Brown
2014-08-18 8:32 ` [PATCH v9 2/2] regulator: Add DT bindings for max77802 " Javier Martinez Canillas
2014-08-18 8:32 ` Javier Martinez Canillas
2014-08-18 8:32 ` Javier Martinez Canillas
2014-08-18 15:23 ` Mark Brown
2014-08-18 15:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826071721.GV17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=joshi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=prashanth.g@samsung.com \
--cc=yuvaraj.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.