From: Shawn Guo <shawn.guo@freescale.com> To: Lucas Stach <l.stach@pengutronix.de> Cc: Viresh Kumar <viresh.kumar@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 3/5] clk: imx: add CPU clock type Date: Fri, 26 Sep 2014 10:59:34 +0800 [thread overview] Message-ID: <20140926025933.GA31948@dragon> (raw) In-Reply-To: <1411143381-10516-4-git-send-email-l.stach@pengutronix.de> On Fri, Sep 19, 2014 at 06:16:19PM +0200, Lucas Stach wrote: > From: Lucas Stach <dev@lynxeye.de> > > This implements a virtual clock used to abstract away > all the steps needed in order to change the ARM clock, > so we don't have to push all this clock handling into > the cpufreq driver. > > While it will be used for i.MX53 at first it is generic > enough to be used on i.MX6 later on. > > Signed-off-by: Lucas Stach <dev@lynxeye.de> Is this intentional to use a different email address than your usual one? > --- > arch/arm/mach-imx/Makefile | 2 +- > arch/arm/mach-imx/clk-cpu.c | 104 ++++++++++++++++++++++++++++++++++++++++++++ > arch/arm/mach-imx/clk.h | 4 ++ > 3 files changed, 109 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/mach-imx/clk-cpu.c > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile > index ac88599ca080..4d6071351f4f 100644 > --- a/arch/arm/mach-imx/Makefile > +++ b/arch/arm/mach-imx/Makefile > @@ -12,7 +12,7 @@ obj-$(CONFIG_SOC_IMX31) += mm-imx3.o cpu-imx31.o clk-imx31.o iomux-imx31.o ehci- > obj-$(CONFIG_SOC_IMX35) += mm-imx3.o cpu-imx35.o clk-imx35.o ehci-imx35.o pm-imx3.o > > imx5-pm-$(CONFIG_PM) += pm-imx5.o > -obj-$(CONFIG_SOC_IMX5) += cpu-imx5.o clk-imx51-imx53.o $(imx5-pm-y) > +obj-$(CONFIG_SOC_IMX5) += cpu-imx5.o clk-imx51-imx53.o clk-cpu.o $(imx5-pm-y) > > obj-$(CONFIG_COMMON_CLK) += clk-pllv1.o clk-pllv2.o clk-pllv3.o clk-gate2.o \ > clk-pfd.o clk-busy.o clk.o \ > diff --git a/arch/arm/mach-imx/clk-cpu.c b/arch/arm/mach-imx/clk-cpu.c > new file mode 100644 > index 000000000000..ffba96228d3b > --- /dev/null > +++ b/arch/arm/mach-imx/clk-cpu.c > @@ -0,0 +1,104 @@ > +/* > + * Copyright (c) 2014 Lucas Stach <l.stach@pengutronix.de>, Pengutronix > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +#include <linux/clk.h> > +#include <linux/clk-provider.h> > +#include <linux/slab.h> > + > +struct clk_cpu { > + struct clk_hw hw; > + struct clk *div, *mux, *pll, *step; This is personal taste, so I'm not strong on this. But I feel having them on multiple lines makes the later addition/removal of struct clk pointers a bit easier. Other than these trivial comments, the patch looks good to me. Shawn > +};
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@freescale.com (Shawn Guo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/5] clk: imx: add CPU clock type Date: Fri, 26 Sep 2014 10:59:34 +0800 [thread overview] Message-ID: <20140926025933.GA31948@dragon> (raw) In-Reply-To: <1411143381-10516-4-git-send-email-l.stach@pengutronix.de> On Fri, Sep 19, 2014 at 06:16:19PM +0200, Lucas Stach wrote: > From: Lucas Stach <dev@lynxeye.de> > > This implements a virtual clock used to abstract away > all the steps needed in order to change the ARM clock, > so we don't have to push all this clock handling into > the cpufreq driver. > > While it will be used for i.MX53 at first it is generic > enough to be used on i.MX6 later on. > > Signed-off-by: Lucas Stach <dev@lynxeye.de> Is this intentional to use a different email address than your usual one? > --- > arch/arm/mach-imx/Makefile | 2 +- > arch/arm/mach-imx/clk-cpu.c | 104 ++++++++++++++++++++++++++++++++++++++++++++ > arch/arm/mach-imx/clk.h | 4 ++ > 3 files changed, 109 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/mach-imx/clk-cpu.c > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile > index ac88599ca080..4d6071351f4f 100644 > --- a/arch/arm/mach-imx/Makefile > +++ b/arch/arm/mach-imx/Makefile > @@ -12,7 +12,7 @@ obj-$(CONFIG_SOC_IMX31) += mm-imx3.o cpu-imx31.o clk-imx31.o iomux-imx31.o ehci- > obj-$(CONFIG_SOC_IMX35) += mm-imx3.o cpu-imx35.o clk-imx35.o ehci-imx35.o pm-imx3.o > > imx5-pm-$(CONFIG_PM) += pm-imx5.o > -obj-$(CONFIG_SOC_IMX5) += cpu-imx5.o clk-imx51-imx53.o $(imx5-pm-y) > +obj-$(CONFIG_SOC_IMX5) += cpu-imx5.o clk-imx51-imx53.o clk-cpu.o $(imx5-pm-y) > > obj-$(CONFIG_COMMON_CLK) += clk-pllv1.o clk-pllv2.o clk-pllv3.o clk-gate2.o \ > clk-pfd.o clk-busy.o clk.o \ > diff --git a/arch/arm/mach-imx/clk-cpu.c b/arch/arm/mach-imx/clk-cpu.c > new file mode 100644 > index 000000000000..ffba96228d3b > --- /dev/null > +++ b/arch/arm/mach-imx/clk-cpu.c > @@ -0,0 +1,104 @@ > +/* > + * Copyright (c) 2014 Lucas Stach <l.stach@pengutronix.de>, Pengutronix > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +#include <linux/clk.h> > +#include <linux/clk-provider.h> > +#include <linux/slab.h> > + > +struct clk_cpu { > + struct clk_hw hw; > + struct clk *div, *mux, *pll, *step; This is personal taste, so I'm not strong on this. But I feel having them on multiple lines makes the later addition/removal of struct clk pointers a bit easier. Other than these trivial comments, the patch looks good to me. Shawn > +};
next prev parent reply other threads:[~2014-09-26 3:00 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-19 16:16 [PATCH 0/5] i.MX53 cpufreq support Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-19 16:16 ` [PATCH 1/5] cpufreq: cpu0: disable unsupported OPPs Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-19 16:49 ` Viresh Kumar 2014-09-19 16:49 ` Viresh Kumar 2014-09-19 16:16 ` [PATCH 2/5] clk: imx5: add step clock, used when reprogramming PLL1 Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-19 16:16 ` [PATCH 3/5] clk: imx: add CPU clock type Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-26 2:59 ` Shawn Guo [this message] 2014-09-26 2:59 ` Shawn Guo 2014-09-26 10:10 ` Lucas Stach 2014-09-26 10:10 ` Lucas Stach 2014-09-19 16:16 ` [PATCH 4/5] arm: imx53: clk: add ARM clock Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-19 16:16 ` [PATCH 5/5] ARM: imx53: add cpufreq support Lucas Stach 2014-09-19 16:16 ` Lucas Stach 2014-09-26 3:02 ` Shawn Guo 2014-09-26 3:02 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140926025933.GA31948@dragon \ --to=shawn.guo@freescale.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.