From: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Josh Cartwright <joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064
Date: Wed, 1 Oct 2014 10:28:55 -0700 [thread overview]
Message-ID: <20141001172855.GL10233@codeaurora.org> (raw)
In-Reply-To: <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 10/01, Josh Cartwright wrote:
> @@ -96,6 +104,13 @@
> cpu-offset = <0x80000>;
> };
>
> + watchdog@208a038 {
> + compatible = "qcom,kpss-wdt-ipq8064";
> + reg = <0x0208a038 0x40>;
Not being aligned to 4k or 1k raises red flags.
The watchdog is part of the timer block (on this chip it's
"qcom,kpss-timer"). We should add qcom,kpss-wdt to the compatible
list in the timer binding and extend that binding to have clocks
and timeout-sec (watchdog-timeout-sec?). This would follow DT
best practices of having one node per device. We could also add
the interrupts too, even if they're not used by the driver right
now.
> + clocks = <&sleep_clk>;
> + timeout-sec = <10>;
> + };
> +
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Kumar Gala <galak@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-arm-msm@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064
Date: Wed, 1 Oct 2014 10:28:55 -0700 [thread overview]
Message-ID: <20141001172855.GL10233@codeaurora.org> (raw)
In-Reply-To: <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc@codeaurora.org>
On 10/01, Josh Cartwright wrote:
> @@ -96,6 +104,13 @@
> cpu-offset = <0x80000>;
> };
>
> + watchdog@208a038 {
> + compatible = "qcom,kpss-wdt-ipq8064";
> + reg = <0x0208a038 0x40>;
Not being aligned to 4k or 1k raises red flags.
The watchdog is part of the timer block (on this chip it's
"qcom,kpss-timer"). We should add qcom,kpss-wdt to the compatible
list in the timer binding and extend that binding to have clocks
and timeout-sec (watchdog-timeout-sec?). This would follow DT
best practices of having one node per device. We could also add
the interrupts too, even if they're not used by the driver right
now.
> + clocks = <&sleep_clk>;
> + timeout-sec = <10>;
> + };
> +
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064
Date: Wed, 1 Oct 2014 10:28:55 -0700 [thread overview]
Message-ID: <20141001172855.GL10233@codeaurora.org> (raw)
In-Reply-To: <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc@codeaurora.org>
On 10/01, Josh Cartwright wrote:
> @@ -96,6 +104,13 @@
> cpu-offset = <0x80000>;
> };
>
> + watchdog at 208a038 {
> + compatible = "qcom,kpss-wdt-ipq8064";
> + reg = <0x0208a038 0x40>;
Not being aligned to 4k or 1k raises red flags.
The watchdog is part of the timer block (on this chip it's
"qcom,kpss-timer"). We should add qcom,kpss-wdt to the compatible
list in the timer binding and extend that binding to have clocks
and timeout-sec (watchdog-timeout-sec?). This would follow DT
best practices of having one node per device. We could also add
the interrupts too, even if they're not used by the driver right
now.
> + clocks = <&sleep_clk>;
> + timeout-sec = <10>;
> + };
> +
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-10-01 17:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:03 [PATCH 0/4] Add KPSS watchdog driver to relevant device trees Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
2014-10-01 17:03 ` [PATCH 1/4] ARM: qcom: add QCOM_WDT driver to qcom_defconfig Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
2014-10-01 17:03 ` [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064 Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
[not found] ` <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-10-01 17:28 ` Stephen Boyd [this message]
2014-10-01 17:28 ` Stephen Boyd
2014-10-01 17:28 ` Stephen Boyd
2014-10-01 18:15 ` Josh Cartwright
2014-10-01 18:15 ` Josh Cartwright
2014-10-02 19:08 ` Stephen Boyd
2014-10-02 19:08 ` Stephen Boyd
2014-10-07 22:10 ` Josh Cartwright
2014-10-07 22:10 ` Josh Cartwright
2014-10-07 23:07 ` Stephen Boyd
2014-10-07 23:07 ` Stephen Boyd
[not found] ` <5434723F.70800-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-10-08 16:06 ` Josh Cartwright
2014-10-08 16:06 ` Josh Cartwright
2014-10-08 16:06 ` Josh Cartwright
2014-10-01 17:03 ` [PATCH 3/4] ARM: qcom: add description of KPSS WDT for APQ8064 Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
2014-10-01 17:03 ` [PATCH 4/4] ARM: qcom: add description of KPSS WDT for MSM8960 Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
2014-10-01 17:03 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001172855.GL10233@codeaurora.org \
--to=sboyd-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.