From: Mark Rutland <mark.rutland@arm.com> To: David Woodhouse <dwmw2@infradead.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Aaron Lu <aaron.lu@intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Bryan Wu <cooloney@gmail.com>, "grant.likely@linaro.org" <grant.likely@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Darren Hart <dvhart@linux.intel.com> Subject: Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support Date: Wed, 15 Oct 2014 14:15:51 +0100 [thread overview] Message-ID: <20141015131551.GC20034@leverpostej> (raw) In-Reply-To: <1413378271.2762.77.camel@infradead.org> On Wed, Oct 15, 2014 at 02:04:31PM +0100, David Woodhouse wrote: > Here's a completely untested patch to convert of_serial to be usable via > ACPI properties too. The properties themselves were fairly > straightforward; the interesting part is converting to > platform_get_irq() and platform_get_resource() — in the latter case > first trying IORESOURCE_MEM then IORESOURCE_IO if that fails. > > Does this look sane? We'll probably want to think about renaming the > module and the config option too, but that can come after the basic > functionality. The majority of these properties look like they constrained to the device in question, so make sense for _DSD too. However... > @@ -155,7 +168,7 @@ static int of_platform_serial_probe(struct platform_device *ofdev) > if (!match) > return -EINVAL; > > - if (of_find_property(ofdev->dev.of_node, "used-by-rtas", NULL)) > + if (!device_get_property(&ofdev->dev, "used-by-rtas", NULL)) > return -EBUSY; This property should never be present on an ACPI system. RTAS is a completely different firmware interface on PowerPC. As a general note, I would hope that we're not going to blindly convert drivers and subsystems over to a common property interface without considering each property w.r.t. the particular FW interface. Each addition to _DSD, especially if through a common accessor needs _more_ scrutiny than is applied to DT bindings, and we hardly manage to review DT bindings. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: David Woodhouse <dwmw2@infradead.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Aaron Lu <aaron.lu@intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Bryan Wu <cooloney@gmail.com>, "grant.likely@linaro.org" <grant.likely@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Darren Hart <dvhart@linux.intel.com> Subject: Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support Date: Wed, 15 Oct 2014 14:15:51 +0100 [thread overview] Message-ID: <20141015131551.GC20034@leverpostej> (raw) In-Reply-To: <1413378271.2762.77.camel@infradead.org> On Wed, Oct 15, 2014 at 02:04:31PM +0100, David Woodhouse wrote: > Here's a completely untested patch to convert of_serial to be usable via > ACPI properties too. The properties themselves were fairly > straightforward; the interesting part is converting to > platform_get_irq() and platform_get_resource() — in the latter case > first trying IORESOURCE_MEM then IORESOURCE_IO if that fails. > > Does this look sane? We'll probably want to think about renaming the > module and the config option too, but that can come after the basic > functionality. The majority of these properties look like they constrained to the device in question, so make sense for _DSD too. However... > @@ -155,7 +168,7 @@ static int of_platform_serial_probe(struct platform_device *ofdev) > if (!match) > return -EINVAL; > > - if (of_find_property(ofdev->dev.of_node, "used-by-rtas", NULL)) > + if (!device_get_property(&ofdev->dev, "used-by-rtas", NULL)) > return -EBUSY; This property should never be present on an ACPI system. RTAS is a completely different firmware interface on PowerPC. As a general note, I would hope that we're not going to blindly convert drivers and subsystems over to a common property interface without considering each property w.r.t. the particular FW interface. Each addition to _DSD, especially if through a common accessor needs _more_ scrutiny than is applied to DT bindings, and we hardly manage to review DT bindings. Mark.
next prev parent reply other threads:[~2014-10-15 13:15 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-07 0:10 [PATCH v4 00/13] Add ACPI _DSD and unified device properties support Rafael J. Wysocki 2014-10-07 0:12 ` [PATCH 01/13] ACPI: Add support for device specific properties Rafael J. Wysocki 2014-10-13 12:47 ` Grant Likely 2014-10-07 0:12 ` [PATCH 02/13] Driver core: Unified device properties interface for platform firmware Rafael J. Wysocki 2014-10-07 0:13 ` [PATCH 03/13] ACPI: Allow drivers to match using Device Tree compatible property Rafael J. Wysocki 2014-10-14 13:38 ` Grant Likely 2014-10-07 0:14 ` [PATCH 04/13] ACPI: Document ACPI device specific properties Rafael J. Wysocki 2014-10-13 12:41 ` Grant Likely 2014-10-14 9:42 ` Mika Westerberg 2014-10-07 0:14 ` [PATCH 05/13] misc: at25: Make use of device property API Rafael J. Wysocki 2014-10-07 9:10 ` Geert Uytterhoeven 2014-10-07 9:32 ` Mika Westerberg 2014-10-07 0:15 ` [PATCH 06/13] gpio / ACPI: Add support for _DSD device properties Rafael J. Wysocki 2014-10-14 13:44 ` Grant Likely 2014-10-15 8:46 ` Mika Westerberg 2014-10-07 0:15 ` [PATCH 07/13] gpio: sch: Consolidate core and resume banks Rafael J. Wysocki 2014-10-07 0:16 ` [PATCH 08/13] leds: leds-gpio: Add support for GPIO descriptors Rafael J. Wysocki [not found] ` <2660541.BycO7TFnA2-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> 2014-10-07 0:16 ` [PATCH 09/12] input: gpio_keys_polled - " Rafael J. Wysocki 2014-10-07 0:16 ` Rafael J. Wysocki [not found] ` <1740633.d3tSWZ2Q0u-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> 2014-10-07 17:29 ` Dmitry Torokhov 2014-10-07 17:29 ` Dmitry Torokhov 2014-10-07 0:17 ` [PATCH 10/13] Driver core: Child node properties for devices Rafael J. Wysocki 2014-10-07 0:18 ` [PATCH 11/13] gpio: Support for unified device properties interface Rafael J. Wysocki 2014-10-07 10:22 ` Alexandre Courbot 2014-10-07 10:40 ` Mika Westerberg 2014-10-07 10:52 ` Alexandre Courbot 2014-10-08 0:09 ` Rafael J. Wysocki 2014-10-08 2:55 ` Alexandre Courbot 2014-10-08 14:01 ` Rafael J. Wysocki 2014-10-07 0:18 ` [PATCH 12/13] leds: leds-gpio: Make use of device property API Rafael J. Wysocki 2014-10-08 14:04 ` Rafael J. Wysocki [not found] ` <2960802.kPr8UT7PvT-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> 2014-10-08 17:47 ` Bryan Wu 2014-10-08 17:47 ` Bryan Wu 2014-10-08 22:02 ` Rafael J. Wysocki 2014-10-07 0:19 ` [PATCH 13/13] input: gpio_keys_polled - " Rafael J. Wysocki 2014-10-07 17:30 ` Dmitry Torokhov 2014-10-07 0:39 ` [PATCH v4 00/13] Add ACPI _DSD and unified device properties support Rafael J. Wysocki 2014-10-07 2:28 ` Greg Kroah-Hartman 2014-10-15 13:04 ` David Woodhouse 2014-10-15 13:15 ` Mark Rutland [this message] 2014-10-15 13:15 ` Mark Rutland 2014-10-15 13:28 ` David Woodhouse 2014-10-15 13:42 ` Mark Rutland 2014-10-15 14:08 ` David Woodhouse 2014-10-15 14:46 ` Darren Hart 2014-10-15 15:11 ` David Woodhouse 2014-10-15 15:17 ` Mark Rutland 2014-10-15 15:43 ` Darren Hart 2014-10-16 10:05 ` Rafael J. Wysocki 2014-10-16 14:55 ` David Woodhouse 2014-10-18 8:37 ` Grant Likely 2014-10-18 8:39 ` Grant Likely 2014-10-18 8:35 ` Grant Likely 2014-10-21 21:50 ` [PATCH v4 00/13] Add ACPI _DSD and unified device properties? support Darren Hart 2015-01-14 18:42 ` [PATCH v4 00/13] Add ACPI _DSD and unified device properties support David Woodhouse 2015-01-15 9:12 ` Rafael J. Wysocki 2014-10-17 12:01 ` [PATCH v5 00/12] " Rafael J. Wysocki 2014-10-17 12:03 ` [PATCH v5 01/12] ACPI: Add support for device specific properties Rafael J. Wysocki 2014-10-17 12:04 ` [PATCH v5 02/12] Driver core: Unified device properties interface for platform firmware Rafael J. Wysocki 2014-10-20 0:07 ` [Update][PATCH " Rafael J. Wysocki 2014-10-17 12:05 ` [PATCH v5 03/12] ACPI: Allow drivers to match using Device Tree compatible property Rafael J. Wysocki 2014-10-20 14:05 ` Grant Likely 2014-10-20 22:19 ` Rafael J. Wysocki 2014-10-17 12:07 ` [PATCH v5 04/12] misc: at25: Make use of device property API Rafael J. Wysocki 2014-10-17 12:09 ` [PATCH v5 05/12] gpio / ACPI: Add support for _DSD device properties Rafael J. Wysocki 2014-10-17 12:10 ` [PATCH v5 06/12] gpio: sch: Consolidate core and resume banks Rafael J. Wysocki 2014-10-17 12:11 ` [PATCH v5 07/12] leds: leds-gpio: Add support for GPIO descriptors Rafael J. Wysocki 2014-10-28 15:26 ` Linus Walleij 2014-10-28 21:56 ` Rafael J. Wysocki 2014-10-29 8:53 ` Mika Westerberg 2014-10-30 15:40 ` Linus Walleij 2014-10-30 16:15 ` Mika Westerberg 2014-10-31 9:41 ` Linus Walleij 2014-10-31 9:55 ` Mika Westerberg 2014-10-30 15:34 ` Linus Walleij 2014-10-17 12:12 ` [PATCH v5 08/12] input: gpio_keys_polled - " Rafael J. Wysocki 2014-10-17 12:14 ` [PATCH v5 09/12] Driver core: Unified interface for firmware node properties Rafael J. Wysocki 2014-10-18 9:35 ` Arnd Bergmann 2014-10-19 23:30 ` Rafael J. Wysocki 2014-10-20 14:14 ` Arnd Bergmann 2014-10-18 14:55 ` Grant Likely 2014-10-19 23:46 ` Rafael J. Wysocki [not found] ` <7821406.D7i8JfDpzX-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> 2014-10-20 14:18 ` Grant Likely 2014-10-20 14:18 ` Grant Likely 2014-10-20 22:14 ` Rafael J. Wysocki 2014-10-20 14:19 ` Arnd Bergmann 2014-10-20 14:55 ` Grant Likely 2014-10-20 22:22 ` Rafael J. Wysocki 2014-10-19 22:14 ` Greg Kroah-Hartman 2014-10-19 23:31 ` Rafael J. Wysocki 2014-10-20 0:15 ` [Update][PATCH " Rafael J. Wysocki 2014-10-17 12:16 ` [PATCH v5 10/12] gpio: Support for unified device properties interface Rafael J. Wysocki 2014-10-17 18:09 ` Arnd Bergmann 2014-10-18 9:47 ` Arnd Bergmann 2014-10-19 23:58 ` Rafael J. Wysocki 2014-10-20 14:22 ` Arnd Bergmann 2014-10-20 6:12 ` Alexandre Courbot 2014-10-20 14:26 ` Arnd Bergmann 2014-10-17 12:17 ` [PATCH v5 11/12] leds: leds-gpio: Make use of device property API Rafael J. Wysocki 2014-10-17 12:18 ` [PATCH v5 12/12] input: gpio_keys_polled - " Rafael J. Wysocki 2014-10-17 12:22 ` [PATCH v5 00/12] Add ACPI _DSD and unified device properties support Rafael J. Wysocki 2014-10-17 15:40 ` Greg Kroah-Hartman 2014-10-17 19:23 ` Darren Hart 2014-10-17 21:49 ` Rafael J. Wysocki 2014-10-19 22:14 ` Greg Kroah-Hartman 2014-10-17 18:04 ` Arnd Bergmann 2014-10-17 22:50 ` Rafael J. Wysocki 2014-10-18 8:49 ` Grant Likely 2014-10-19 23:32 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141015131551.GC20034@leverpostej \ --to=mark.rutland@arm.com \ --cc=aaron.lu@intel.com \ --cc=arnd@arndb.de \ --cc=cooloney@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=dvhart@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=gnurou@gmail.com \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.