From: Mark Brown <broonie@kernel.org>
To: Jianqun <jay.xu@rock-chips.com>
Cc: heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, huangtao@rock-chips.com,
cf@rock-chips.com
Subject: Re: [PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig
Date: Wed, 22 Oct 2014 11:49:47 +0100 [thread overview]
Message-ID: <20141022104947.GP2344@sirena.org.uk> (raw)
In-Reply-To: <1413946799-20834-1-git-send-email-jay.xu@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Wed, Oct 22, 2014 at 10:59:59AM +0800, Jianqun wrote:
> +config SND_SOC_MAX98090
> + tristate "ASoC support for max98090 driver"
> + depends on I2C && GPIOLIB
> + help
> + Say Y or M here if you want to add support for max98090 codec.
No, you're missing what Lars was saying here - there's already a Kconfig
symbol for the CODEC in the codecs directory, you should add the help
text to that in order to allow the user to enable it. Do this in a
separate patch to making your I2S driver selectable since it's not
directly related code wise.
Please also drop the "ASoC" -> "SoC audio" transition or at least make
it a separate patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig
Date: Wed, 22 Oct 2014 11:49:47 +0100 [thread overview]
Message-ID: <20141022104947.GP2344@sirena.org.uk> (raw)
In-Reply-To: <1413946799-20834-1-git-send-email-jay.xu@rock-chips.com>
On Wed, Oct 22, 2014 at 10:59:59AM +0800, Jianqun wrote:
> +config SND_SOC_MAX98090
> + tristate "ASoC support for max98090 driver"
> + depends on I2C && GPIOLIB
> + help
> + Say Y or M here if you want to add support for max98090 codec.
No, you're missing what Lars was saying here - there's already a Kconfig
symbol for the CODEC in the codecs directory, you should add the help
text to that in order to allow the user to enable it. Do this in a
separate patch to making your I2S driver selectable since it's not
directly related code wise.
Please also drop the "ASoC" -> "SoC audio" transition or at least make
it a separate patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141022/2bb10004/attachment.sig>
next prev parent reply other threads:[~2014-10-22 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 11:31 [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support Jianqun
2014-10-21 11:31 ` Jianqun
2014-10-21 12:39 ` [alsa-devel] " Lars-Peter Clausen
2014-10-21 12:39 ` Lars-Peter Clausen
2014-10-22 0:40 ` Jianqun
2014-10-22 0:40 ` Jianqun
2014-10-31 18:11 ` Mark Brown
2014-10-31 18:11 ` Mark Brown
2014-10-22 2:59 ` [PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig Jianqun
2014-10-22 2:59 ` Jianqun
2014-10-22 10:49 ` Mark Brown [this message]
2014-10-22 10:49 ` Mark Brown
2014-11-01 2:58 ` [PATCH v2] ASoC: rockchip: i2s: add text after tristate for SND_SOC_ROCKCHIP_I2S Jianqun
2014-11-01 2:58 ` Jianqun
2014-11-03 12:09 ` Mark Brown
2014-11-03 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022104947.GP2344@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cf@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.