From: Eduardo Valentin <edubezval@gmail.com> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Caesar Wang <caesar.wang@rock-chips.com>, heiko@sntech.de, rui.zhang@intel.com, zyf@rock-chips.com, dianders@chromium.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, cf@rock-chips.com, dbasehore@chromium.org, huangtao@rock-chips.com, cjf@rock-chips.com, zhengsq@rock-chips.com, fzf@rock-chips.com Subject: Re: [PATCH v17 1/5] thermal: rockchip: add driver for thermal Date: Fri, 7 Nov 2014 19:39:58 -0400 [thread overview] Message-ID: <20141107233956.GA27665@developer> (raw) In-Reply-To: <20141107015728.GF34214@dtor-ws> [-- Attachment #1: Type: text/plain, Size: 3723 bytes --] Hello Dmitry, On Thu, Nov 06, 2014 at 05:57:28PM -0800, Dmitry Torokhov wrote: > Hi Eduardo, > > On Thu, Nov 06, 2014 at 09:30:20PM -0400, Eduardo Valentin wrote: > > Hello Caesar, > > > > On Sat, Nov 01, 2014 at 10:44:29AM +0800, Caesar Wang wrote: > > > Thermal is TS-ADC Controller module supports > > > user-defined mode and automatic mode. > > > > > > User-defined mode refers,TSADC all the control signals entirely by > > > software writing to register for direct control. > > > > > > Automaic mode refers to the module automatically poll TSADC output, > > > and the results were checked.If you find that the temperature High > > > in a period of time,an interrupt is generated to the processor > > > down-measures taken;If the temperature over a period of time High, > > > the resulting TSHUT gave CRU module,let it reset the entire chip, > > > or via GPIO give PMIC. > > > > > > > First thing, very good progress in this driver! > > > > > Signed-off-by: zhaoyifeng <zyf@rock-chips.com> > > > Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com> > > > Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > Just for the sake of code / documentation history, this patch, which > > adds the driver, should come after patch 2, which adds dt documentation. > > > > > --- > > > drivers/thermal/Kconfig | 9 + > > > drivers/thermal/Makefile | 1 + > > > drivers/thermal/rockchip_thermal.c | 711 +++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 721 insertions(+) > > > create mode 100644 drivers/thermal/rockchip_thermal.c > > > > <big cut> > > > > > +static int > > > +rockchip_thermal_register_sensor(struct platform_device *pdev, > > > + struct rockchip_thermal_data *thermal, > > > + struct rockchip_thermal_sensor *sensor, > > > + enum sensor_id id) > > > +{ > > > + const struct rockchip_tsadc_chip *tsadc = thermal->chip; > > > + int error; > > > + > > > + tsadc->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); > > > + tsadc->set_tshut_temp(id, thermal->regs, thermal->tshut_temp); > > > + > > > + sensor->thermal = thermal; > > > + sensor->id = id; > > > + sensor->tzd = thermal_zone_of_sensor_register(&pdev->dev, id, sensor, > > > + rockchip_thermal_get_temp, > > > + NULL, > > > + rockchip_thermal_set_trips); > > > > So, did I miss something here? Looks like you have extended the of > > thermal, and I haven't seen the patch. > > CC [M] drivers/thermal/rockchip_thermal.o > > drivers/thermal/rockchip_thermal.c: In function > > `rockchip_thermal_register_sensor': > > drivers/thermal/rockchip_thermal.c:482:7: error: too many arguments to > > function `thermal_zone_of_sensor_register' > > rockchip_thermal_set_trips); > > Yes, it relies on patch by Mikko Perttunen adding support for > hardware-supported trip points. It allows us to reduce polling frequency > while still being able to react when we cross the tripping point. > > See https://lkml.org/lkml/2014/6/27/76 > Yeah, that thread needs to be re-taken. Today I merged nvidia's driver, but only a simpler version of it. I expect that they take the missing parts through after updating / refreshing the patches. And on that front, as I requested, there must be also equivalent mapping in the thermal core, to avoid spreading / growing of-thermal as a secondary thermal API. One thing for sure that must be done is a little refactoring in the of-thermal registration functions. I had a similar discussion about this with Lukasz, who is also interested in improving the of-thermal callbacks. Cheers, > Thanks. > > -- > Dmitry [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v17 1/5] thermal: rockchip: add driver for thermal Date: Fri, 7 Nov 2014 19:39:58 -0400 [thread overview] Message-ID: <20141107233956.GA27665@developer> (raw) In-Reply-To: <20141107015728.GF34214@dtor-ws> Hello Dmitry, On Thu, Nov 06, 2014 at 05:57:28PM -0800, Dmitry Torokhov wrote: > Hi Eduardo, > > On Thu, Nov 06, 2014 at 09:30:20PM -0400, Eduardo Valentin wrote: > > Hello Caesar, > > > > On Sat, Nov 01, 2014 at 10:44:29AM +0800, Caesar Wang wrote: > > > Thermal is TS-ADC Controller module supports > > > user-defined mode and automatic mode. > > > > > > User-defined mode refers,TSADC all the control signals entirely by > > > software writing to register for direct control. > > > > > > Automaic mode refers to the module automatically poll TSADC output, > > > and the results were checked.If you find that the temperature High > > > in a period of time,an interrupt is generated to the processor > > > down-measures taken;If the temperature over a period of time High, > > > the resulting TSHUT gave CRU module,let it reset the entire chip, > > > or via GPIO give PMIC. > > > > > > > First thing, very good progress in this driver! > > > > > Signed-off-by: zhaoyifeng <zyf@rock-chips.com> > > > Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com> > > > Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > Just for the sake of code / documentation history, this patch, which > > adds the driver, should come after patch 2, which adds dt documentation. > > > > > --- > > > drivers/thermal/Kconfig | 9 + > > > drivers/thermal/Makefile | 1 + > > > drivers/thermal/rockchip_thermal.c | 711 +++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 721 insertions(+) > > > create mode 100644 drivers/thermal/rockchip_thermal.c > > > > <big cut> > > > > > +static int > > > +rockchip_thermal_register_sensor(struct platform_device *pdev, > > > + struct rockchip_thermal_data *thermal, > > > + struct rockchip_thermal_sensor *sensor, > > > + enum sensor_id id) > > > +{ > > > + const struct rockchip_tsadc_chip *tsadc = thermal->chip; > > > + int error; > > > + > > > + tsadc->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); > > > + tsadc->set_tshut_temp(id, thermal->regs, thermal->tshut_temp); > > > + > > > + sensor->thermal = thermal; > > > + sensor->id = id; > > > + sensor->tzd = thermal_zone_of_sensor_register(&pdev->dev, id, sensor, > > > + rockchip_thermal_get_temp, > > > + NULL, > > > + rockchip_thermal_set_trips); > > > > So, did I miss something here? Looks like you have extended the of > > thermal, and I haven't seen the patch. > > CC [M] drivers/thermal/rockchip_thermal.o > > drivers/thermal/rockchip_thermal.c: In function > > `rockchip_thermal_register_sensor': > > drivers/thermal/rockchip_thermal.c:482:7: error: too many arguments to > > function `thermal_zone_of_sensor_register' > > rockchip_thermal_set_trips); > > Yes, it relies on patch by Mikko Perttunen adding support for > hardware-supported trip points. It allows us to reduce polling frequency > while still being able to react when we cross the tripping point. > > See https://lkml.org/lkml/2014/6/27/76 > Yeah, that thread needs to be re-taken. Today I merged nvidia's driver, but only a simpler version of it. I expect that they take the missing parts through after updating / refreshing the patches. And on that front, as I requested, there must be also equivalent mapping in the thermal core, to avoid spreading / growing of-thermal as a secondary thermal API. One thing for sure that must be done is a little refactoring in the of-thermal registration functions. I had a similar discussion about this with Lukasz, who is also interested in improving the of-thermal callbacks. Cheers, > Thanks. > > -- > Dmitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141107/53498e5b/attachment.sig>
next prev parent reply other threads:[~2014-11-07 23:41 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-01 2:44 [PATCH v17 0/5] Rockchip soc thermal driver Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` [PATCH v17 1/5] thermal: rockchip: add driver for thermal Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-05 10:11 ` [v17,1/5] " Caesar Wang 2014-11-05 10:11 ` Caesar Wang 2014-11-07 1:30 ` [PATCH v17 1/5] " Eduardo Valentin 2014-11-07 1:30 ` Eduardo Valentin 2014-11-07 1:57 ` Dmitry Torokhov 2014-11-07 1:57 ` Dmitry Torokhov 2014-11-07 23:39 ` Eduardo Valentin [this message] 2014-11-07 23:39 ` Eduardo Valentin 2014-11-01 2:44 ` [PATCH v17 2/5] dt-bindings: document Rockchip thermal Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` [PATCH v17 3/5] ARM: dts: add RK3288 Thermal data Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` [PATCH v17 4/5] ARM: dts: add main Thermal info to rk3288 Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` Caesar Wang 2014-11-01 2:44 ` [PATCH v17 5/5] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang 2014-11-01 2:44 ` Caesar Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141107233956.GA27665@developer \ --to=edubezval@gmail.com \ --cc=caesar.wang@rock-chips.com \ --cc=cf@rock-chips.com \ --cc=cjf@rock-chips.com \ --cc=dbasehore@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=fzf@rock-chips.com \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=rui.zhang@intel.com \ --cc=zhengsq@rock-chips.com \ --cc=zyf@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.