From: Lee Jones <lee.jones@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
edubezval@gmail.com, kernel@stlinux.com,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
Date: Wed, 19 Nov 2014 16:40:40 +0000 [thread overview]
Message-ID: <20141119164040.GG1875@x1> (raw)
In-Reply-To: <CAOMZO5CwFSRUoVb2j=X=fzaqVN1gUyRki70ewrGrwqLWSHMoAg@mail.gmail.com>
On Wed, 19 Nov 2014, Fabio Estevam wrote:
> On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >
> > v1 => v2:
> > - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
>
> You should also update the Subject to 'when !PM_SLEEP'
I guess we should, yes.
Zhang, Eduardo,
Are you happy to do that, or would you like me to re-spin again?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
Date: Wed, 19 Nov 2014 16:40:40 +0000 [thread overview]
Message-ID: <20141119164040.GG1875@x1> (raw)
In-Reply-To: <CAOMZO5CwFSRUoVb2j=X=fzaqVN1gUyRki70ewrGrwqLWSHMoAg@mail.gmail.com>
On Wed, 19 Nov 2014, Fabio Estevam wrote:
> On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> > warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> > warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >
> > v1 => v2:
> > - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
>
> You should also update the Subject to 'when !PM_SLEEP'
I guess we should, yes.
Zhang, Eduardo,
Are you happy to do that, or would you like me to re-spin again?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-19 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 15:50 [PATCH] thermal: sti: Ignore suspend/resume functions when !PM Lee Jones
2014-11-19 15:50 ` Lee Jones
2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:40 ` Lee Jones [this message]
2014-11-19 16:40 ` Lee Jones
2014-11-19 16:40 ` Lee Jones
2014-11-21 18:31 ` Eduardo Valentin
2014-11-21 18:31 ` Eduardo Valentin
2014-11-21 18:31 ` Eduardo Valentin
-- strict thread matches above, loose matches on Subject: below --
2014-11-19 13:48 Lee Jones
2014-11-19 13:48 ` Lee Jones
2014-11-19 14:57 ` Fabio Estevam
2014-11-19 14:57 ` Fabio Estevam
2014-11-19 14:57 ` Fabio Estevam
2014-11-19 15:49 ` Lee Jones
2014-11-19 15:49 ` Lee Jones
2014-11-19 15:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119164040.GG1875@x1 \
--to=lee.jones@linaro.org \
--cc=edubezval@gmail.com \
--cc=festevam@gmail.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.