From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Alexandru Stan <amstan@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sonny Rao <sonnyrao@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] regulator: core: Support trying to get close to a certain voltage
Date: Thu, 11 Dec 2014 17:09:34 +0000 [thread overview]
Message-ID: <20141211170934.GZ11764@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=U4RFYx9NXOACrXJZK2bKkosyYnmTZRHkXuaSz-FS9kNQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Thu, Dec 11, 2014 at 08:09:13AM -0800, Doug Anderson wrote:
> On Thu, Dec 11, 2014 at 4:31 AM, Mark Brown <broonie@kernel.org> wrote:
> > This is just an implementation detail, everything you're saying here
> > applies equally to any user specifying by tolerance rather than range.
> > If the reason for doing this is to fix that problem then a new API isn't
> > the way to go about it.
> OK, I'll give a shot at taking my code and using it as a new
> implementation for regulator_set_voltage_tol(). In the SD card code
> I'll pick some reasonable tolerances--they won't be exactly what the
> spec says, but they ought to be good enough. If Ulf comes back and
> yells at me then we can revisit adding a new API.
OK, thanks. Even if a new interface does get added the implementation
needs to be shared with that for setting by tolerance, they're doing the
same thing.
Please also bear in mind the need to handle shared supplies in your
implementation.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] regulator: core: Support trying to get close to a certain voltage
Date: Thu, 11 Dec 2014 17:09:34 +0000 [thread overview]
Message-ID: <20141211170934.GZ11764@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=U4RFYx9NXOACrXJZK2bKkosyYnmTZRHkXuaSz-FS9kNQ@mail.gmail.com>
On Thu, Dec 11, 2014 at 08:09:13AM -0800, Doug Anderson wrote:
> On Thu, Dec 11, 2014 at 4:31 AM, Mark Brown <broonie@kernel.org> wrote:
> > This is just an implementation detail, everything you're saying here
> > applies equally to any user specifying by tolerance rather than range.
> > If the reason for doing this is to fix that problem then a new API isn't
> > the way to go about it.
> OK, I'll give a shot at taking my code and using it as a new
> implementation for regulator_set_voltage_tol(). In the SD card code
> I'll pick some reasonable tolerances--they won't be exactly what the
> spec says, but they ought to be good enough. If Ulf comes back and
> yells at me then we can revisit adding a new API.
OK, thanks. Even if a new interface does get added the implementation
needs to be shared with that for setting by tolerance, they're doing the
same thing.
Please also bear in mind the need to handle shared supplies in your
implementation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141211/f1c36788/attachment.sig>
next prev parent reply other threads:[~2014-12-11 17:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:58 [PATCH 1/4] regulator: core: Support trying to get close to a certain voltage Doug Anderson
2014-12-10 20:58 ` Doug Anderson
2014-12-10 20:58 ` [PATCH 2/4] mmc: core: Add mmc_regulator_set_vqmmc() Doug Anderson
2014-12-10 20:58 ` Doug Anderson
2014-12-10 20:58 ` [PATCH 3/4] mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch Doug Anderson
2014-12-10 20:58 ` Doug Anderson
2014-12-10 20:58 ` [PATCH 4/4] ARK: dts: Specify VMMC and VQMMC on rk3288-evb Doug Anderson
2014-12-10 20:58 ` Doug Anderson
2014-12-10 20:58 ` Doug Anderson
2014-12-10 23:53 ` [PATCH 1/4] regulator: core: Support trying to get close to a certain voltage Mark Brown
2014-12-10 23:53 ` Mark Brown
2014-12-11 1:08 ` Alexandru Stan
2014-12-11 1:08 ` Alexandru Stan
2014-12-11 12:31 ` Mark Brown
2014-12-11 12:31 ` Mark Brown
2014-12-11 16:09 ` Doug Anderson
2014-12-11 16:09 ` Doug Anderson
2014-12-11 17:09 ` Mark Brown [this message]
2014-12-11 17:09 ` Mark Brown
2014-12-11 19:55 ` Doug Anderson
2014-12-11 19:55 ` Doug Anderson
2014-12-12 0:24 ` Mark Brown
2014-12-12 0:24 ` Mark Brown
2014-12-12 3:31 ` Doug Anderson
2014-12-12 3:31 ` Doug Anderson
2014-12-12 12:59 ` Mark Brown
2014-12-12 12:59 ` Mark Brown
2014-12-15 22:11 ` Doug Anderson
2014-12-15 22:11 ` Doug Anderson
2014-12-16 13:13 ` Mark Brown
2014-12-16 13:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211170934.GZ11764@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=alim.akhtar@samsung.com \
--cc=amstan@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.