From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info
Date: Mon, 12 Jan 2015 13:36:06 +0100 [thread overview]
Message-ID: <20150112123606.GB29325@lst.de> (raw)
In-Reply-To: <20150111181651.GN25319@htj.dyndns.org>
On Sun, Jan 11, 2015 at 01:16:51PM -0500, Tejun Heo wrote:
> > +struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > {
> > struct super_block *sb = inode->i_sb;
> > #ifdef CONFIG_BLOCK
> > @@ -75,6 +75,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > #endif
> > return sb->s_bdi;
> > }
> > +EXPORT_SYMBOL_GPL(inode_to_bdi);
>
> This is rather trivial. Maybe we wanna make this an inline function?
Without splitting backing-dev.h this leads recursive includes. With
the split of that file in your series we could make it inline again.
Another thing I've through of would be to always dynamically allocate
bdis instead of embedding them. This would stop the need to have
backing-dev.h included in blkdev.h and would greatly simply the filesystems
that allocated bdis on their own.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info
Date: Mon, 12 Jan 2015 13:36:06 +0100 [thread overview]
Message-ID: <20150112123606.GB29325@lst.de> (raw)
In-Reply-To: <20150111181651.GN25319@htj.dyndns.org>
On Sun, Jan 11, 2015 at 01:16:51PM -0500, Tejun Heo wrote:
> > +struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > {
> > struct super_block *sb = inode->i_sb;
> > #ifdef CONFIG_BLOCK
> > @@ -75,6 +75,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > #endif
> > return sb->s_bdi;
> > }
> > +EXPORT_SYMBOL_GPL(inode_to_bdi);
>
> This is rather trivial. Maybe we wanna make this an inline function?
Without splitting backing-dev.h this leads recursive includes. With
the split of that file in your series we could make it inline again.
Another thing I've through of would be to always dynamically allocate
bdis instead of embedding them. This would stop the need to have
backing-dev.h included in blkdev.h and would greatly simply the filesystems
that allocated bdis on their own.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
linux-nfs@vger.kernel.org, Jens Axboe <axboe@fb.com>,
linux-mm@kvack.org, linux-mtd@lists.infradead.org,
linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info
Date: Mon, 12 Jan 2015 13:36:06 +0100 [thread overview]
Message-ID: <20150112123606.GB29325@lst.de> (raw)
In-Reply-To: <20150111181651.GN25319@htj.dyndns.org>
On Sun, Jan 11, 2015 at 01:16:51PM -0500, Tejun Heo wrote:
> > +struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > {
> > struct super_block *sb = inode->i_sb;
> > #ifdef CONFIG_BLOCK
> > @@ -75,6 +75,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > #endif
> > return sb->s_bdi;
> > }
> > +EXPORT_SYMBOL_GPL(inode_to_bdi);
>
> This is rather trivial. Maybe we wanna make this an inline function?
Without splitting backing-dev.h this leads recursive includes. With
the split of that file in your series we could make it inline again.
Another thing I've through of would be to always dynamically allocate
bdis instead of embedding them. This would stop the need to have
backing-dev.h included in blkdev.h and would greatly simply the filesystems
that allocated bdis on their own.
next prev parent reply other threads:[~2015-01-12 12:36 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 17:45 backing_dev_info cleanups & lifetime rule fixes Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` [PATCH 01/12] fs: deduplicate noop_backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:00 ` Tejun Heo
2015-01-11 17:00 ` Tejun Heo
2015-01-11 17:00 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 02/12] fs: kill BDI_CAP_SWAP_BACKED Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:05 ` Tejun Heo
2015-01-11 17:05 ` Tejun Heo
2015-01-11 17:05 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 03/12] fs: introduce f_op->mmap_capabilities for nommu mmap support Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:24 ` Tejun Heo
2015-01-11 17:24 ` Tejun Heo
2015-01-11 17:24 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 04/12] block_dev: only write bdev inode on close Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:32 ` Tejun Heo
2015-01-11 17:32 ` Tejun Heo
2015-01-11 17:32 ` Tejun Heo
2015-01-12 12:33 ` Christoph Hellwig
2015-01-12 12:33 ` Christoph Hellwig
2015-01-12 12:33 ` Christoph Hellwig
[not found] ` <1420739133-27514-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-01-08 17:45 ` [PATCH 05/12] block_dev: get bdev inode bdi directly from the block device Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:40 ` Tejun Heo
2015-01-11 17:40 ` Tejun Heo
2015-01-11 17:40 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 09/12] ceph: remove call to bdi_unregister Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` [PATCH 06/12] nilfs2: set up s_bdi like the generic mount_bdev code Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 17:41 ` Tejun Heo
2015-01-11 17:41 ` Tejun Heo
2015-01-11 17:41 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
[not found] ` <1420739133-27514-8-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-01-11 18:16 ` Tejun Heo
2015-01-11 18:16 ` Tejun Heo
2015-01-11 18:16 ` Tejun Heo
2015-01-11 18:16 ` Tejun Heo
2015-01-12 12:36 ` Christoph Hellwig [this message]
2015-01-12 12:36 ` Christoph Hellwig
2015-01-12 12:36 ` Christoph Hellwig
2015-01-08 17:45 ` [PATCH 08/12] fs: remove mapping->backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 18:20 ` Tejun Heo
2015-01-11 18:20 ` Tejun Heo
2015-01-11 18:20 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 10/12] nfs: don't call bdi_unregister Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 18:33 ` Tejun Heo
2015-01-11 18:33 ` Tejun Heo
2015-01-11 18:33 ` Tejun Heo
2015-01-08 17:45 ` [PATCH 12/12] fs: remove default_backing_dev_info Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-08 17:45 ` Christoph Hellwig
2015-01-11 18:39 ` Tejun Heo
2015-01-11 18:39 ` Tejun Heo
2015-01-11 18:39 ` Tejun Heo
2015-01-14 9:42 backing_dev_info cleanups & lifetime rule fixes V2 Christoph Hellwig
2015-01-14 9:42 ` [PATCH 07/12] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 9:42 ` Christoph Hellwig
2015-01-14 13:31 ` Jan Kara
2015-01-14 13:31 ` Jan Kara
2015-01-14 13:31 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112123606.GB29325@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.