From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff
Date: Mon, 19 Jan 2015 01:03:47 -0800 [thread overview]
Message-ID: <20150119090347.GE27474@infradead.org> (raw)
In-Reply-To: <1421412471-4747-6-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote:
> Ocfs2 can just use the generic helpers provided by quota code for
> turning quotas on and off when quota files are stored as system inodes.
> The only difference is the feature test in ocfs2_quota_on() and that is
> covered by dquot_quota_enable() checking whether usage tracking is
> enabled (which can happen only if the filesystem has the quota feature
> set).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ocfs2/super.c | 32 +-------------------------------
> 1 file changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 83723179e1ec..706c71c2955d 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1000,36 +1000,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> }
> }
>
> -/* Handle quota on quotactl */
> -static int ocfs2_quota_on(struct super_block *sb, int type, int format_id)
> -{
> - unsigned int feature[OCFS2_MAXQUOTAS] = {
> - OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
> - OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
> -
> - if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
> - return -EINVAL;
Where are we doing this feature check now?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff
Date: Mon, 19 Jan 2015 01:03:47 -0800 [thread overview]
Message-ID: <20150119090347.GE27474@infradead.org> (raw)
In-Reply-To: <1421412471-4747-6-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote:
> Ocfs2 can just use the generic helpers provided by quota code for
> turning quotas on and off when quota files are stored as system inodes.
> The only difference is the feature test in ocfs2_quota_on() and that is
> covered by dquot_quota_enable() checking whether usage tracking is
> enabled (which can happen only if the filesystem has the quota feature
> set).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ocfs2/super.c | 32 +-------------------------------
> 1 file changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 83723179e1ec..706c71c2955d 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1000,36 +1000,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> }
> }
>
> -/* Handle quota on quotactl */
> -static int ocfs2_quota_on(struct super_block *sb, int type, int format_id)
> -{
> - unsigned int feature[OCFS2_MAXQUOTAS] = {
> - OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
> - OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
> -
> - if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
> - return -EINVAL;
Where are we doing this feature check now?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff
Date: Mon, 19 Jan 2015 01:03:47 -0800 [thread overview]
Message-ID: <20150119090347.GE27474@infradead.org> (raw)
In-Reply-To: <1421412471-4747-6-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote:
> Ocfs2 can just use the generic helpers provided by quota code for
> turning quotas on and off when quota files are stored as system inodes.
> The only difference is the feature test in ocfs2_quota_on() and that is
> covered by dquot_quota_enable() checking whether usage tracking is
> enabled (which can happen only if the filesystem has the quota feature
> set).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ocfs2/super.c | 32 +-------------------------------
> 1 file changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 83723179e1ec..706c71c2955d 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1000,36 +1000,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> }
> }
>
> -/* Handle quota on quotactl */
> -static int ocfs2_quota_on(struct super_block *sb, int type, int format_id)
> -{
> - unsigned int feature[OCFS2_MAXQUOTAS] = {
> - OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
> - OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
> -
> - if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
> - return -EINVAL;
Where are we doing this feature check now?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff
Date: Mon, 19 Jan 2015 01:03:47 -0800 [thread overview]
Message-ID: <20150119090347.GE27474@infradead.org> (raw)
In-Reply-To: <1421412471-4747-6-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote:
> Ocfs2 can just use the generic helpers provided by quota code for
> turning quotas on and off when quota files are stored as system inodes.
> The only difference is the feature test in ocfs2_quota_on() and that is
> covered by dquot_quota_enable() checking whether usage tracking is
> enabled (which can happen only if the filesystem has the quota feature
> set).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ocfs2/super.c | 32 +-------------------------------
> 1 file changed, 1 insertion(+), 31 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 83723179e1ec..706c71c2955d 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1000,36 +1000,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> }
> }
>
> -/* Handle quota on quotactl */
> -static int ocfs2_quota_on(struct super_block *sb, int type, int format_id)
> -{
> - unsigned int feature[OCFS2_MAXQUOTAS] = {
> - OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
> - OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
> -
> - if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
> - return -EINVAL;
Where are we doing this feature check now?
next prev parent reply other threads:[~2015-01-19 9:03 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:47 [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [PATCH 01/17] quota: Split ->set_xstate callback into two Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:00 ` Christoph Hellwig
2015-01-19 9:00 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:00 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:00 ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:01 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-19 9:01 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Christoph Hellwig
2015-01-19 9:01 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:01 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-20 17:01 ` Jan Kara
2015-01-20 17:01 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-20 17:01 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` [PATCH 03/17] quota: Add ->quota_{enable, disable} callbacks for VFS quotas Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-19 9:02 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-19 9:02 ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Christoph Hellwig
2015-01-19 9:02 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:02 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-20 17:08 ` Jan Kara
2015-01-20 17:08 ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Jan Kara
2015-01-20 17:08 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:08 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Jan Kara
2015-01-16 12:47 ` [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-19 9:03 ` Christoph Hellwig
2015-01-19 9:03 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:03 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 05/17] ocfs2: " Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:03 ` Christoph Hellwig [this message]
2015-01-19 9:03 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:03 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:03 ` Christoph Hellwig
2015-01-20 17:13 ` Jan Kara
2015-01-20 17:13 ` [Cluster-devel] " Jan Kara
2015-01-20 17:13 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` [PATCH 06/17] quota: Remove quota_on_meta callback Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:04 ` Christoph Hellwig
2015-01-19 9:04 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:04 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:07 ` Christoph Hellwig
2015-01-19 9:07 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:07 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-20 16:53 ` Jan Kara
2015-01-20 16:53 ` [Cluster-devel] " Jan Kara
2015-01-20 16:53 ` [Ocfs2-devel] " Jan Kara
2015-01-20 16:53 ` Jan Kara
2015-01-16 12:47 ` [PATCH 08/17] quota: Store maximum space limit in bytes Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:07 ` Christoph Hellwig
2015-01-19 9:07 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:07 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:09 ` Christoph Hellwig
2015-01-19 9:09 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:09 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:09 ` Christoph Hellwig
2015-01-20 17:16 ` Jan Kara
2015-01-20 17:16 ` [Cluster-devel] " Jan Kara
2015-01-20 17:16 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:16 ` Jan Kara
2015-01-16 12:47 ` [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:10 ` Christoph Hellwig
2015-01-19 9:10 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:10 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:11 ` Christoph Hellwig
2015-01-19 9:11 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:11 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 12/17] xfs: Convert to using ->get_state callback Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:38 ` Christoph Hellwig
2015-01-19 9:38 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:38 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-20 17:33 ` Jan Kara
2015-01-20 17:33 ` [Cluster-devel] " Jan Kara
2015-01-20 17:33 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:33 ` Jan Kara
2015-01-16 12:47 ` [PATCH 13/17] gfs2: " Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:38 ` Christoph Hellwig
2015-01-19 9:38 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:38 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:38 ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 15/17] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [PATCH 16/17] xfs: Add support for Q_SETINFO Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [PATCH 17/17] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2015-01-16 12:47 ` [Cluster-devel] " Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-21 21:38 ` [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Dave Chinner
2015-01-21 21:38 ` [Cluster-devel] " Dave Chinner
2015-01-21 21:38 ` [Ocfs2-devel] " Dave Chinner
2015-01-21 21:38 ` Dave Chinner
2015-01-21 22:23 ` Jan Kara
2015-01-21 22:23 ` [Cluster-devel] " Jan Kara
2015-01-21 22:23 ` [Ocfs2-devel] " Jan Kara
2015-01-21 22:23 ` Jan Kara
2015-01-21 23:10 ` Dave Chinner
2015-01-21 23:10 ` [Cluster-devel] " Dave Chinner
2015-01-21 23:10 ` [Ocfs2-devel] " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119090347.GE27474@infradead.org \
--to=hch@infradead.org \
--cc=cluster-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.