From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Sumit Semwal <sumit.semwal@linaro.org>
Cc: inki.dae@samsung.com, linaro-kernel@lists.linaro.org,
pawel@osciak.com, airlied@linux.ie, gregkh@linuxfoundation.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
robdclark@gmail.com, kgene@kernel.org, thierry.reding@gmail.com,
daniel@ffwll.ch, daniel.vetter@intel.com,
linux-tegra@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 11:23:39 -0200 [thread overview]
Message-ID: <20150128112339.164c55fd@recife.lan> (raw)
In-Reply-To: <1422449643-7829-1-git-send-email-sumit.semwal@linaro.org>
Em Wed, 28 Jan 2015 18:24:03 +0530
Sumit Semwal <sumit.semwal@linaro.org> escreveu:
> +/**
> + * helper macro for exporters; zeros and fills in most common values
> + */
> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> + struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
> +
I suspect that this will let the other fields not initialized.
You likely need to do:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { \
.exp_name = KBUILD_MODNAME; \
.fields = 0; \
...
}
Regards,
Mauro
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Sumit Semwal <sumit.semwal@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
rmk+kernel@arm.linux.org.uk, airlied@linux.ie, kgene@kernel.org,
daniel.vetter@intel.com, thierry.reding@gmail.com,
pawel@osciak.com, m.szyprowski@samsung.com,
gregkh@linuxfoundation.org, linaro-kernel@lists.linaro.org,
robdclark@gmail.com, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org,
inki.dae@samsung.com
Subject: Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 11:23:39 -0200 [thread overview]
Message-ID: <20150128112339.164c55fd@recife.lan> (raw)
In-Reply-To: <1422449643-7829-1-git-send-email-sumit.semwal@linaro.org>
Em Wed, 28 Jan 2015 18:24:03 +0530
Sumit Semwal <sumit.semwal@linaro.org> escreveu:
> +/**
> + * helper macro for exporters; zeros and fills in most common values
> + */
> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> + struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
> +
I suspect that this will let the other fields not initialized.
You likely need to do:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { \
.exp_name = KBUILD_MODNAME; \
.fields = 0; \
...
}
Regards,
Mauro
WARNING: multiple messages have this Message-ID (diff)
From: mchehab@osg.samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible
Date: Wed, 28 Jan 2015 11:23:39 -0200 [thread overview]
Message-ID: <20150128112339.164c55fd@recife.lan> (raw)
In-Reply-To: <1422449643-7829-1-git-send-email-sumit.semwal@linaro.org>
Em Wed, 28 Jan 2015 18:24:03 +0530
Sumit Semwal <sumit.semwal@linaro.org> escreveu:
> +/**
> + * helper macro for exporters; zeros and fills in most common values
> + */
> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
> + struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
> +
I suspect that this will let the other fields not initialized.
You likely need to do:
#define DEFINE_DMA_BUF_EXPORT_INFO(a) \
struct dma_buf_export_info a = { \
.exp_name = KBUILD_MODNAME; \
.fields = 0; \
...
}
Regards,
Mauro
next prev parent reply other threads:[~2015-01-28 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 12:54 [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible Sumit Semwal
2015-01-28 12:54 ` Sumit Semwal
2015-01-28 12:54 ` Sumit Semwal
2015-01-28 13:23 ` Mauro Carvalho Chehab [this message]
2015-01-28 13:23 ` Mauro Carvalho Chehab
2015-01-28 13:23 ` Mauro Carvalho Chehab
2015-01-28 13:30 ` Sumit Semwal
2015-01-28 13:30 ` Sumit Semwal
2015-01-28 13:30 ` Sumit Semwal
2015-01-28 13:30 ` Sumit Semwal
2015-01-28 15:00 ` Maarten Lankhorst
2015-01-28 15:00 ` Maarten Lankhorst
2015-01-28 15:00 ` Maarten Lankhorst
2015-02-03 9:29 ` Daniel Thompson
2015-02-03 9:29 ` Daniel Thompson
2015-02-03 9:29 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128112339.164c55fd@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.