Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900

From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: linux-omap@vger.kernel.org, Kevin Hilman <khilman@kernel.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Sebastian Reichel <sre@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900
Date: Wed, 18 Feb 2015 14:42:06 -0800	[thread overview]
Message-ID: <20150218224206.GC32521@atomide.com> (raw)
In-Reply-To: <201502182004.03195@pali>

* Pali Rohár <pali.rohar@gmail.com> [150218 11:07]:
> On Wednesday 18 February 2015 17:33:53 Tony Lindgren wrote:
> > > */ +//		reg = <1 0x300 0xf>;		/* 16 byte IO range at 
> offset
> > > 0x300 */ +		reg = <1 0x0 0xf>;		/* 16 byte IO range 
> at
> > > offset 0x300 */
> > > 
> > >  		bank-width = <2>;
> > >  		pinctrl-names = "default";
> > >  		pinctrl-0 = <&ethernet_pins>;
> > 
> > Oh cool, the 0x300 offset is there mostly to suppress warnings
> > about non-standard location.
...

> > OK that's good news. Care to do a patch to set the offset 0x0
> > with added comment that qemu needs it? I'll test to make sure
> > it works on the real hardware as well.
> 
> Yes, I can send proper git format-patch, but first let me know if 
> that change does not break your HW...

Yes using reg = <1 0 0xf> works, it just adds this extra warning:

smc91x 2000000.ethernet (unnamed net_device) (uninitialized):
smc91x: IOADDR d09d6000 doesn't match configuration (300).

And I'm pretty sure that can be fixed by setting the EEPROM
offset to 0 instead of the default 0x300. People with smc91x
most likely want to write at least the MAC address to the
EEPROM, so might as well set the offset to zero then too.

Of course it's always possible to do do a omap3-n900-qemu.dts
if larger changes are needed :)

Regards,

Tony