From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-sh@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>
Subject: Re: fs: dax: do not build on ARC or SH
Date: Mon, 23 Feb 2015 22:15:38 +0000 [thread overview]
Message-ID: <20150223221538.GA25109@roeck-us.net> (raw)
In-Reply-To: <20150223215847.GA29052@infradead.org>
On Mon, Feb 23, 2015 at 01:58:47PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 23, 2015 at 01:56:34PM -0800, Guenter Roeck wrote:
> > Guess there a philosophical difference in opinion if the architecture code
> > should (have to) provide copy_user_page() or not outside the architecture
> > code itself. After all, fs/dax.c _is_ the only user of this function outside
> > the architecture code.
>
> Given that copy_user_page just is an optimized version of copy_page
> all these architectures should just grab the trivial macro defintion
> from the asm-generic version so that we could avoid this discussion.
>
I tried to do just that, for mips, with little success.
https://patchwork.linux-mips.org/patch/9175/
Presumably, if copy_page() followed by a conditional flush_data_cache_page()
does not work on mips, I would assume that copy_page() without flush does not
work either.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-sh@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>
Subject: Re: fs: dax: do not build on ARC or SH
Date: Mon, 23 Feb 2015 14:15:38 -0800 [thread overview]
Message-ID: <20150223221538.GA25109@roeck-us.net> (raw)
In-Reply-To: <20150223215847.GA29052@infradead.org>
On Mon, Feb 23, 2015 at 01:58:47PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 23, 2015 at 01:56:34PM -0800, Guenter Roeck wrote:
> > Guess there a philosophical difference in opinion if the architecture code
> > should (have to) provide copy_user_page() or not outside the architecture
> > code itself. After all, fs/dax.c _is_ the only user of this function outside
> > the architecture code.
>
> Given that copy_user_page just is an optimized version of copy_page
> all these architectures should just grab the trivial macro defintion
> from the asm-generic version so that we could avoid this discussion.
>
I tried to do just that, for mips, with little success.
https://patchwork.linux-mips.org/patch/9175/
Presumably, if copy_page() followed by a conditional flush_data_cache_page()
does not work on mips, I would assume that copy_page() without flush does not
work either.
Guenter
next prev parent reply other threads:[~2015-02-23 22:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:29 fs: dax: do not build on ARC or SH Arnd Bergmann
2015-02-23 18:40 ` Matthew Wilcox
2015-02-23 18:40 ` Matthew Wilcox
2015-02-23 21:31 ` Arnd Bergmann
2015-02-23 21:31 ` Arnd Bergmann
2015-02-23 21:56 ` Guenter Roeck
2015-02-23 21:56 ` Guenter Roeck
2015-02-23 21:58 ` Christoph Hellwig
2015-02-23 21:58 ` Christoph Hellwig
2015-02-23 22:15 ` Guenter Roeck [this message]
2015-02-23 22:15 ` Guenter Roeck
2015-02-28 0:59 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223221538.GA25109@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=vgupta@synopsys.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.