From: Bjorn Helgaas <bhelgaas@google.com> To: Ray Jui <rjui@broadcom.com> Cc: Arnd Bergmann <arnd@arndb.de>, Hauke Mehrtens <hauke@hauke-m.de>, Paul Bolle <pebolle@tiscali.nl>, Florian Fainelli <f.fainelli@gmail.com>, Dmitry Torokhov <dtor@google.com>, Anatol Pomazau <anatol@google.com>, Scott Branden <sbranden@broadcom.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/4] PCI: Export symbols of PCI functions Date: Tue, 10 Mar 2015 15:56:51 -0500 [thread overview] Message-ID: <20150310205651.GA32204@google.com> (raw) In-Reply-To: <1425947886-23705-2-git-send-email-rjui@broadcom.com> On Mon, Mar 09, 2015 at 05:38:03PM -0700, Ray Jui wrote: > Export symbols of the following PCI functions so they can be referenced > by a PCI driver compiled as a kernel loadable module: > > pci_common_swizzle > pci_create_root_bus > pci_stop_root_bus > pci_remove_root_bus > pci_assign_unassigned_bus_resources > pci_fixup_irqs Have you tested your driver as a loadable module? If it works to load/unload/reload/etc., I'm OK with exporting these symbols. I would prefer EXPORT_SYMBOL_GPL, though, because these don't constitute a very coherent interface right now, and they will likely be reworked. For example, see Yijing Wang's work to sort out the pci_bus_add_devices() / resource assignment mess. Bjorn > Signed-off-by: Ray Jui <rjui@broadcom.com> > --- > drivers/pci/pci.c | 1 + > drivers/pci/probe.c | 1 + > drivers/pci/remove.c | 2 ++ > drivers/pci/setup-bus.c | 1 + > drivers/pci/setup-irq.c | 1 + > 5 files changed, 6 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 81f06e8..fb4a3da 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2492,6 +2492,7 @@ u8 pci_common_swizzle(struct pci_dev *dev, u8 *pinp) > *pinp = pin; > return PCI_SLOT(dev->devfn); > } > +EXPORT_SYMBOL(pci_common_swizzle); > > /** > * pci_release_region - Release a PCI bar > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8d2f400..eb24ef9 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1993,6 +1993,7 @@ err_out: > kfree(b); > return NULL; > } > +EXPORT_SYMBOL(pci_create_root_bus); > > int pci_bus_insert_busn_res(struct pci_bus *b, int bus, int bus_max) > { > diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c > index 8bd76c9..c523159 100644 > --- a/drivers/pci/remove.c > +++ b/drivers/pci/remove.c > @@ -139,6 +139,7 @@ void pci_stop_root_bus(struct pci_bus *bus) > /* stop the host bridge */ > device_release_driver(&host_bridge->dev); > } > +EXPORT_SYMBOL(pci_stop_root_bus); > > void pci_remove_root_bus(struct pci_bus *bus) > { > @@ -158,3 +159,4 @@ void pci_remove_root_bus(struct pci_bus *bus) > /* remove the host bridge */ > device_unregister(&host_bridge->dev); > } > +EXPORT_SYMBOL(pci_remove_root_bus); > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c > index e3e17f3..932c9e5 100644 > --- a/drivers/pci/setup-bus.c > +++ b/drivers/pci/setup-bus.c > @@ -1750,3 +1750,4 @@ void pci_assign_unassigned_bus_resources(struct pci_bus *bus) > __pci_bus_assign_resources(bus, &add_list, NULL); > BUG_ON(!list_empty(&add_list)); > } > +EXPORT_SYMBOL(pci_assign_unassigned_bus_resources); > diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c > index 4e2d595..9d2bbb6 100644 > --- a/drivers/pci/setup-irq.c > +++ b/drivers/pci/setup-irq.c > @@ -65,3 +65,4 @@ void pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *), > for_each_pci_dev(dev) > pdev_fixup_irq(dev, swizzle, map_irq); > } > +EXPORT_SYMBOL(pci_fixup_irqs); > -- > 1.7.9.5 >
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 1/4] PCI: Export symbols of PCI functions Date: Tue, 10 Mar 2015 15:56:51 -0500 [thread overview] Message-ID: <20150310205651.GA32204@google.com> (raw) In-Reply-To: <1425947886-23705-2-git-send-email-rjui@broadcom.com> On Mon, Mar 09, 2015 at 05:38:03PM -0700, Ray Jui wrote: > Export symbols of the following PCI functions so they can be referenced > by a PCI driver compiled as a kernel loadable module: > > pci_common_swizzle > pci_create_root_bus > pci_stop_root_bus > pci_remove_root_bus > pci_assign_unassigned_bus_resources > pci_fixup_irqs Have you tested your driver as a loadable module? If it works to load/unload/reload/etc., I'm OK with exporting these symbols. I would prefer EXPORT_SYMBOL_GPL, though, because these don't constitute a very coherent interface right now, and they will likely be reworked. For example, see Yijing Wang's work to sort out the pci_bus_add_devices() / resource assignment mess. Bjorn > Signed-off-by: Ray Jui <rjui@broadcom.com> > --- > drivers/pci/pci.c | 1 + > drivers/pci/probe.c | 1 + > drivers/pci/remove.c | 2 ++ > drivers/pci/setup-bus.c | 1 + > drivers/pci/setup-irq.c | 1 + > 5 files changed, 6 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 81f06e8..fb4a3da 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2492,6 +2492,7 @@ u8 pci_common_swizzle(struct pci_dev *dev, u8 *pinp) > *pinp = pin; > return PCI_SLOT(dev->devfn); > } > +EXPORT_SYMBOL(pci_common_swizzle); > > /** > * pci_release_region - Release a PCI bar > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8d2f400..eb24ef9 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1993,6 +1993,7 @@ err_out: > kfree(b); > return NULL; > } > +EXPORT_SYMBOL(pci_create_root_bus); > > int pci_bus_insert_busn_res(struct pci_bus *b, int bus, int bus_max) > { > diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c > index 8bd76c9..c523159 100644 > --- a/drivers/pci/remove.c > +++ b/drivers/pci/remove.c > @@ -139,6 +139,7 @@ void pci_stop_root_bus(struct pci_bus *bus) > /* stop the host bridge */ > device_release_driver(&host_bridge->dev); > } > +EXPORT_SYMBOL(pci_stop_root_bus); > > void pci_remove_root_bus(struct pci_bus *bus) > { > @@ -158,3 +159,4 @@ void pci_remove_root_bus(struct pci_bus *bus) > /* remove the host bridge */ > device_unregister(&host_bridge->dev); > } > +EXPORT_SYMBOL(pci_remove_root_bus); > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c > index e3e17f3..932c9e5 100644 > --- a/drivers/pci/setup-bus.c > +++ b/drivers/pci/setup-bus.c > @@ -1750,3 +1750,4 @@ void pci_assign_unassigned_bus_resources(struct pci_bus *bus) > __pci_bus_assign_resources(bus, &add_list, NULL); > BUG_ON(!list_empty(&add_list)); > } > +EXPORT_SYMBOL(pci_assign_unassigned_bus_resources); > diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c > index 4e2d595..9d2bbb6 100644 > --- a/drivers/pci/setup-irq.c > +++ b/drivers/pci/setup-irq.c > @@ -65,3 +65,4 @@ void pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *), > for_each_pci_dev(dev) > pdev_fixup_irq(dev, swizzle, map_irq); > } > +EXPORT_SYMBOL(pci_fixup_irqs); > -- > 1.7.9.5 >
next prev parent reply other threads:[~2015-03-10 20:56 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-10 0:38 [PATCH v5 0/4] pci: iproc: Add Broadcom iProc PCIe support Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` [PATCH v5 1/4] PCI: Export symbols of PCI functions Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 20:56 ` Bjorn Helgaas [this message] 2015-03-10 20:56 ` Bjorn Helgaas 2015-03-10 21:02 ` Ray Jui 2015-03-10 21:02 ` Ray Jui 2015-03-10 21:02 ` Ray Jui 2015-03-10 0:38 ` [PATCH v5 2/4] pci: iProc: define iProc PCIe platform bus binding Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` [PATCH v5 3/4] pci: iproc: Add Broadcom iProc PCIe support Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 21:40 ` Bjorn Helgaas 2015-03-10 21:40 ` Bjorn Helgaas 2015-03-10 22:22 ` Ray Jui 2015-03-10 22:22 ` Ray Jui 2015-03-10 22:22 ` Ray Jui 2015-03-10 22:39 ` Arnd Bergmann 2015-03-10 22:39 ` Arnd Bergmann 2015-03-10 22:46 ` Bjorn Helgaas 2015-03-10 22:46 ` Bjorn Helgaas 2015-03-11 1:11 ` Yijing Wang 2015-03-11 1:11 ` Yijing Wang 2015-03-11 1:11 ` Yijing Wang 2015-03-10 0:38 ` [PATCH v5 4/4] ARM: dts: enable PCIe support for Cygnus Ray Jui 2015-03-10 0:38 ` Ray Jui 2015-03-10 0:38 ` Ray Jui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150310205651.GA32204@google.com \ --to=bhelgaas@google.com \ --cc=anatol@google.com \ --cc=arnd@arndb.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=dtor@google.com \ --cc=f.fainelli@gmail.com \ --cc=hauke@hauke-m.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=pebolle@tiscali.nl \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.