From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Mike Turquette <mturquette@linaro.org>,
James Liao <jamesjj.liao@mediatek.com>,
YH Chen <yh.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
Henry Chen <henryc.chen@mediatek.com>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.
Date: Mon, 16 Mar 2015 08:03:39 +0100 [thread overview]
Message-ID: <20150316070339.GA25487@pengutronix.de> (raw)
In-Reply-To: <1426485311-31428-4-git-send-email-s.hauer@pengutronix.de>
Hello Sascha,
On Mon, Mar 16, 2015 at 06:55:09AM +0100, Sascha Hauer wrote:
> +static const char *axi_parents[] __initconst = {
> + "clk26m",
> + "syspll_d3",
> + "syspll_d4",
> + "syspll_d6",
> + "univpll_d5",
> + "univpll2_d2",
> + "syspll_d3p5"
> +};
__initconst should only be used for const data, but this array isn't
const. Only the strings the pointer in this array point to are constant.
So you have to use either
static const char *axi_parents[] __initdata = {
or
static const char * const axi_parents[] __initconst = {
.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135.
Date: Mon, 16 Mar 2015 08:03:39 +0100 [thread overview]
Message-ID: <20150316070339.GA25487@pengutronix.de> (raw)
In-Reply-To: <1426485311-31428-4-git-send-email-s.hauer@pengutronix.de>
Hello Sascha,
On Mon, Mar 16, 2015 at 06:55:09AM +0100, Sascha Hauer wrote:
> +static const char *axi_parents[] __initconst = {
> + "clk26m",
> + "syspll_d3",
> + "syspll_d4",
> + "syspll_d6",
> + "univpll_d5",
> + "univpll2_d2",
> + "syspll_d3p5"
> +};
__initconst should only be used for const data, but this array isn't
const. Only the strings the pointer in this array point to are constant.
So you have to use either
static const char *axi_parents[] __initdata = {
or
static const char * const axi_parents[] __initconst = {
.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-03-16 7:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 5:55 [PATCH v7]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` [PATCH 1/5] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` [PATCH 2/5] clk: mediatek: Add reset controller support Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 7:03 ` Uwe Kleine-König [this message]
2015-03-16 7:03 ` Uwe Kleine-König
2015-03-17 9:47 ` Sascha Hauer
2015-03-17 9:47 ` Sascha Hauer
2015-03-17 9:47 ` Sascha Hauer
2015-03-17 13:54 ` Uwe Kleine-König
2015-03-17 13:54 ` Uwe Kleine-König
2015-03-16 5:55 ` [PATCH 4/5] clk: mediatek: Add basic clocks for Mediatek MT8173 Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
2015-03-16 5:55 ` [PATCH 5/5] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers Sascha Hauer
2015-03-16 5:55 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2015-02-22 11:49 [PATCH v6]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-02-22 11:49 ` [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-02-22 11:49 ` Sascha Hauer
2015-03-13 7:44 ` Henry Chen
2015-03-13 7:44 ` Henry Chen
2015-03-16 5:33 ` Sascha Hauer
2015-03-16 5:33 ` Sascha Hauer
2015-03-15 16:27 ` Daniel Kurtz
2015-03-15 16:27 ` Daniel Kurtz
2015-03-15 16:27 ` Daniel Kurtz
2015-03-16 5:33 ` Sascha Hauer
2015-03-16 5:33 ` Sascha Hauer
2015-03-16 5:33 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316070339.GA25487@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Yingjoe.Chen@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=yh.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.