Re: [PATCH 2/2] i2c: driver for the Conexant Digicolor I2C controller

From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: driver for the Conexant Digicolor I2C controller
Date: Wed, 18 Mar 2015 22:07:30 +0100	[thread overview]
Message-ID: <20150318210730.GA12960@katana> (raw)
In-Reply-To: <a106023efa9fd648f46021cd063437df798528de.1424092804.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hi,

On Mon, Feb 16, 2015 at 03:20:04PM +0200, Baruch Siach wrote:
> This commit adds a driver for the I2C master controller on the CX92755 SoC. The
> CX92755 is one SoC in the Conexant Digicolor series. This driver should support
> other SoCs from that series.
> 
> Only 7bit slave addresses are currently supported.
> 
> Tested on the Equinox CX92755 EVK, using i2c-tools utilities to read and write
> the on-chip (sic) audio codec.
> 
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

Looks mostly good.

> +static u32 dc_i2c_func(struct i2c_adapter *adap)
> +{
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +}

You probably want to advertise I2C_FUNC_NOSTART here, too?

And if you could rebase to something after 4.0-rc1, that would be much
appreciated.

Thanks,

   Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]